[PATCH net-next 0/2] net: phy: add comments for LAN8742 phy support

[PATCH net-next 0/2] net: phy: add comments for LAN8742 phy support

[Yuiko Oshino]

Add comments for 0xfffffff2 phy ID mask for the LAN8742 and the LAN88xx, explaining that they can coexist and allow future hardware revisions.
Also add one missing tab in smsc.c.

Yuiko Oshino (2):
  net: phy: microchip: add comments for the modified LAN88xx phy ID
    mask.
  net: phy: smsc: add comments for the LAN8742 phy ID mask.

 drivers/net/phy/microchip.c | 4 ++++
 drivers/net/phy/smsc.c      | 6 +++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

-- 
2.25.1

[PATCH net-next 1/2] net: phy: microchip: add comments for the modified LAN88xx phy ID mask.

[Yuiko Oshino]

add comments for the updated LAN88xx phy ID mask in the previous patch.

Signed-off-by: Yuiko Oshino <yuiko.oshino@microchip.com>
---
 drivers/net/phy/microchip.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/phy/microchip.c b/drivers/net/phy/microchip.c
index 131caf659ed2..ccecee2524ce 100644
--- a/drivers/net/phy/microchip.c
+++ b/drivers/net/phy/microchip.c
@@ -345,6 +345,10 @@ static int lan88xx_config_aneg(struct phy_device *phydev)
 static struct phy_driver microchip_phy_driver[] = {
 {
 	.phy_id		= 0x0007c132,
+	/* This mask (0xfffffff2) is to differentiate from
+	 * LAN8742 (phy_id 0x0007c130 and 0x0007c131)
+	 * and allows future phy_id revisions.
+	 */
 	.phy_id_mask	= 0xfffffff2,
 	.name		= "Microchip LAN88xx",
 
-- 
2.25.1

[PATCH net-next 2/2] net: phy: smsc: add comments for the LAN8742 phy ID mask.

[Yuiko Oshino]

add comments for the LAN8742 phy ID mask in the previous patch.
add one missing tab in the LAN8742 phy ID line.

Signed-off-by: Yuiko Oshino <yuiko.oshino@microchip.com>
---
 drivers/net/phy/smsc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
index 44fa9e00cc50..92225d0fc246 100644
--- a/drivers/net/phy/smsc.c
+++ b/drivers/net/phy/smsc.c
@@ -484,7 +484,11 @@ static struct phy_driver smsc_phy_driver[] = {
 	.suspend	= genphy_suspend,
 	.resume		= genphy_resume,
 }, {
-	.phy_id	= 0x0007c130,	/* 0x0007c130 and 0x0007c131 */
+	.phy_id		= 0x0007c130,	/* 0x0007c130 and 0x0007c131 */
+	/* This mask (0xfffffff2) is to differentiate from
+	 * LAN88xx (phy_id 0x0007c132)
+	 * and allows future phy_id revisions.
+	 */
 	.phy_id_mask	= 0xfffffff2,
 	.name		= "Microchip LAN8742",
 
-- 
2.25.1

Re: [PATCH net-next 0/2] net: phy: add comments for LAN8742 phy support

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 9 May 2022 11:58:02 -0700 you wrote:
> Add comments for 0xfffffff2 phy ID mask for the LAN8742 and the LAN88xx, explaining that they can coexist and allow future hardware revisions.
> Also add one missing tab in smsc.c.
> 
> Yuiko Oshino (2):
>   net: phy: microchip: add comments for the modified LAN88xx phy ID
>     mask.
>   net: phy: smsc: add comments for the LAN8742 phy ID mask.
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] net: phy: microchip: add comments for the modified LAN88xx phy ID mask.
    https://git.kernel.org/netdev/net-next/c/70a40ecfcb7d
  - [net-next,2/2] net: phy: smsc: add comments for the LAN8742 phy ID mask.
    https://git.kernel.org/netdev/net-next/c/b2be075139fa

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html