* [Buildroot] [PATCH 1/2] package/python-orjson: bump version to 3.6.8.
@ 2022-05-09 19:06 Graeme Smecher
2022-05-09 19:06 ` [Buildroot] [PATCH 2/2] package/python-orjson: disallow build when using musl Graeme Smecher
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Graeme Smecher @ 2022-05-09 19:06 UTC (permalink / raw)
To: buildroot; +Cc: Graeme Smecher, Asaf Kahlon
Signed-off-by: Graeme Smecher <gsmecher@threespeedlogic.com>
---
package/python-orjson/python-orjson.hash | 2 +-
package/python-orjson/python-orjson.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/python-orjson/python-orjson.hash b/package/python-orjson/python-orjson.hash
index 5ef2726d82..2c00164702 100644
--- a/package/python-orjson/python-orjson.hash
+++ b/package/python-orjson/python-orjson.hash
@@ -1,4 +1,4 @@
# Locally calculated
-sha256 4713b120ad86b1b273f5952cbf9578c13d0f453064bd26d823e04a10c84824e6 python-orjson-3.6.7.tar.gz
+sha256 2b0259ff26455c4f9ad2290b49ba184a35e98eea4839f0d6d5c2b7d91383b3d9 python-orjson-3.6.8.tar.gz
sha256 a60eea817514531668d7e00765731449fe14d059d3249e0bc93b36de45f759f2 LICENSE-APACHE
sha256 23f18e03dc49df91622fe2a76176497404e46ced8a715d9d2b67a7446571cca3 LICENSE-MIT
diff --git a/package/python-orjson/python-orjson.mk b/package/python-orjson/python-orjson.mk
index 5de4b2c5fa..cfcaedc280 100644
--- a/package/python-orjson/python-orjson.mk
+++ b/package/python-orjson/python-orjson.mk
@@ -4,7 +4,7 @@
#
################################################################################
-PYTHON_ORJSON_VERSION = 3.6.7
+PYTHON_ORJSON_VERSION = 3.6.8
PYTHON_ORJSON_SITE = $(call github,ijl,orjson,$(PYTHON_ORJSON_VERSION))
PYTHON_ORJSON_LICENSE = Apache-2.0 or MIT
PYTHON_ORJSON_LICENSE_FILES = LICENSE-APACHE LICENSE-MIT
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Buildroot] [PATCH 2/2] package/python-orjson: disallow build when using musl. 2022-05-09 19:06 [Buildroot] [PATCH 1/2] package/python-orjson: bump version to 3.6.8 Graeme Smecher @ 2022-05-09 19:06 ` Graeme Smecher 2022-05-19 16:02 ` [Buildroot] [PATCH v2] " Graeme Smecher 2022-05-09 22:14 ` [Buildroot] [PATCH 1/2] package/python-orjson: bump version to 3.6.8 James Hilliard 2022-07-24 7:40 ` Thomas Petazzoni via buildroot 2 siblings, 1 reply; 9+ messages in thread From: Graeme Smecher @ 2022-05-09 19:06 UTC (permalink / raw) To: buildroot; +Cc: Graeme Smecher, Asaf Kahlon The python-orjson build bails as follows when using musl libc: error: cannot produce cdylib for `orjson v3.6.7 (...)` as the target `i586-unknown-linux-musl` does not support these crate types It's not machine-specific (it occurs on i586, s389x, and arm platforms), and is tied to what appears to be relatively arcane details for rust/musl: https://github.com/rust-lang/rust/issues/59302 At some point, it will be possible to remove this restriction - but not yet. Signed-off-by: Graeme Smecher <gsmecher@threespeedlogic.com> --- package/python-orjson/Config.in | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/package/python-orjson/Config.in b/package/python-orjson/Config.in index 420e023b0a..b2ad9062cc 100644 --- a/package/python-orjson/Config.in +++ b/package/python-orjson/Config.in @@ -1,6 +1,8 @@ config BR2_PACKAGE_PYTHON_ORJSON bool "python-orjson" depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS + # doesn't build with musl until rust's cdylib targets work with it + depends on !BR2_TOOLCHAIN_USES_MUSL select BR2_PACKAGE_PYTHON_CFFI # runtime help orjson is a fast, correct JSON library for Python. It @@ -10,3 +12,6 @@ config BR2_PACKAGE_PYTHON_ORJSON instances natively. https://github.com/ijl/orjson + +comment "python-orjson requires rust cdylib support, which musl doesn't have yet" + depends on BR2_TOOLCHAIN_USES_MUSL -- 2.35.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2] package/python-orjson: disallow build when using musl. 2022-05-09 19:06 ` [Buildroot] [PATCH 2/2] package/python-orjson: disallow build when using musl Graeme Smecher @ 2022-05-19 16:02 ` Graeme Smecher 2023-02-07 16:38 ` Yann E. MORIN 0 siblings, 1 reply; 9+ messages in thread From: Graeme Smecher @ 2022-05-19 16:02 UTC (permalink / raw) To: buildroot; +Cc: Graeme Smecher The python-orjson build bails as follows when using musl libc: error: cannot produce cdylib for `orjson v3.6.7 (...)` as the target `i586-unknown-linux-musl` does not support these crate types It's not machine-specific (it occurs on i586, s389x, and arm platforms), and is tied to what appears to be relatively arcane details for rust/musl: https://github.com/rust-lang/rust/issues/59302 At some point, it will be possible to remove this restriction - but not yet. Signed-off-by: Graeme Smecher <gsmecher@threespeedlogic.com> --- package/python-orjson/Config.in | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/package/python-orjson/Config.in b/package/python-orjson/Config.in index 420e023b0a..b2ad9062cc 100644 --- a/package/python-orjson/Config.in +++ b/package/python-orjson/Config.in @@ -1,6 +1,8 @@ config BR2_PACKAGE_PYTHON_ORJSON bool "python-orjson" depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS + # doesn't build with musl until rust's cdylib targets work with it + depends on !BR2_TOOLCHAIN_USES_MUSL select BR2_PACKAGE_PYTHON_CFFI # runtime help orjson is a fast, correct JSON library for Python. It @@ -10,3 +12,6 @@ config BR2_PACKAGE_PYTHON_ORJSON instances natively. https://github.com/ijl/orjson + +comment "python-orjson requires rust cdylib support, which musl doesn't have yet" + depends on BR2_TOOLCHAIN_USES_MUSL -- 2.35.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH v2] package/python-orjson: disallow build when using musl. 2022-05-19 16:02 ` [Buildroot] [PATCH v2] " Graeme Smecher @ 2023-02-07 16:38 ` Yann E. MORIN 2023-02-07 17:14 ` Graeme Smecher 0 siblings, 1 reply; 9+ messages in thread From: Yann E. MORIN @ 2023-02-07 16:38 UTC (permalink / raw) To: Graeme Smecher; +Cc: buildroot Graeme, All, On 2022-05-19 09:02 -0700, Graeme Smecher spake thusly: > The python-orjson build bails as follows when using musl libc: > > error: cannot produce cdylib for `orjson v3.6.7 (...)` as the > target `i586-unknown-linux-musl` does not support these crate types I could not reproduce such an error wit the following defconfig: BR2_TOOLCHAIN_BUILDROOT_MUSL=y BR2_TOOLCHAIN_BUILDROOT_CXX=y BR2_PER_PACKAGE_DIRECTORIES=y BR2_PACKAGE_PYTHON3=y BR2_PACKAGE_PYTHON_ORJSON=y Since you submitted this patch, pythn-orjson was bumped multiple times, and we've also bumped rust to 1.66.1, so maybe that was fixed now. Could you have a further look into this, please? Regards, Yann E. MORIN. > It's not machine-specific (it occurs on i586, s389x, and arm platforms), > and is tied to what appears to be relatively arcane details for > rust/musl: > > https://github.com/rust-lang/rust/issues/59302 > > At some point, it will be possible to remove this restriction - but not > yet. > > Signed-off-by: Graeme Smecher <gsmecher@threespeedlogic.com> > --- > package/python-orjson/Config.in | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/package/python-orjson/Config.in b/package/python-orjson/Config.in > index 420e023b0a..b2ad9062cc 100644 > --- a/package/python-orjson/Config.in > +++ b/package/python-orjson/Config.in > @@ -1,6 +1,8 @@ > config BR2_PACKAGE_PYTHON_ORJSON > bool "python-orjson" > depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS > + # doesn't build with musl until rust's cdylib targets work with it > + depends on !BR2_TOOLCHAIN_USES_MUSL > select BR2_PACKAGE_PYTHON_CFFI # runtime > help > orjson is a fast, correct JSON library for Python. It > @@ -10,3 +12,6 @@ config BR2_PACKAGE_PYTHON_ORJSON > instances natively. > > https://github.com/ijl/orjson > + > +comment "python-orjson requires rust cdylib support, which musl doesn't have yet" > + depends on BR2_TOOLCHAIN_USES_MUSL > -- > 2.35.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH v2] package/python-orjson: disallow build when using musl. 2023-02-07 16:38 ` Yann E. MORIN @ 2023-02-07 17:14 ` Graeme Smecher 2023-02-07 17:29 ` Yann E. MORIN 0 siblings, 1 reply; 9+ messages in thread From: Graeme Smecher @ 2023-02-07 17:14 UTC (permalink / raw) To: Yann E. MORIN; +Cc: buildroot Hi Yann, On 2023-02-07 08:38, Yann E. MORIN wrote: > Graeme, All, > > On 2022-05-19 09:02 -0700, Graeme Smecher spake thusly: >> The python-orjson build bails as follows when using musl libc: >> >> error: cannot produce cdylib for `orjson v3.6.7 (...)` as the >> target `i586-unknown-linux-musl` does not support these crate types > > I could not reproduce such an error wit the following defconfig: > > BR2_TOOLCHAIN_BUILDROOT_MUSL=y > BR2_TOOLCHAIN_BUILDROOT_CXX=y > BR2_PER_PACKAGE_DIRECTORIES=y > BR2_PACKAGE_PYTHON3=y > BR2_PACKAGE_PYTHON_ORJSON=y > > Since you submitted this patch, pythn-orjson was bumped multiple times, > and we've also bumped rust to 1.66.1, so maybe that was fixed now. > > Could you have a further look into this, please? This patch is obsolete. I used to receive orjson build failures associated with musl on a regular basis - they have tapered off since mid-2022. Over the past ~6 months or so, only the mips autobuilds have failed with the following message: - maturin failed Caused by: The architecture mips is not supported http://autobuild.buildroot.net/results/7291d123479411e632b8380f0045a18814dc23ae I am happy to drop the patch. best, Graeme > > Regards, > Yann E. MORIN. > >> It's not machine-specific (it occurs on i586, s389x, and arm platforms), >> and is tied to what appears to be relatively arcane details for >> rust/musl: >> >> https://github.com/rust-lang/rust/issues/59302 >> >> At some point, it will be possible to remove this restriction - but not >> yet. >> >> Signed-off-by: Graeme Smecher <gsmecher@threespeedlogic.com> >> --- >> package/python-orjson/Config.in | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/package/python-orjson/Config.in b/package/python-orjson/Config.in >> index 420e023b0a..b2ad9062cc 100644 >> --- a/package/python-orjson/Config.in >> +++ b/package/python-orjson/Config.in >> @@ -1,6 +1,8 @@ >> config BR2_PACKAGE_PYTHON_ORJSON >> bool "python-orjson" >> depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS >> + # doesn't build with musl until rust's cdylib targets work with it >> + depends on !BR2_TOOLCHAIN_USES_MUSL >> select BR2_PACKAGE_PYTHON_CFFI # runtime >> help >> orjson is a fast, correct JSON library for Python. It >> @@ -10,3 +12,6 @@ config BR2_PACKAGE_PYTHON_ORJSON >> instances natively. >> >> https://github.com/ijl/orjson >> + >> +comment "python-orjson requires rust cdylib support, which musl doesn't have yet" >> + depends on BR2_TOOLCHAIN_USES_MUSL >> -- >> 2.35.1 >> >> _______________________________________________ >> buildroot mailing list >> buildroot@buildroot.org >> https://lists.buildroot.org/mailman/listinfo/buildroot > _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH v2] package/python-orjson: disallow build when using musl. 2023-02-07 17:14 ` Graeme Smecher @ 2023-02-07 17:29 ` Yann E. MORIN 2023-02-07 17:56 ` Graeme Smecher 0 siblings, 1 reply; 9+ messages in thread From: Yann E. MORIN @ 2023-02-07 17:29 UTC (permalink / raw) To: Graeme Smecher; +Cc: Thomas Petazzoni, buildroot Graeme, All, On 2023-02-07 09:14 -0800, Graeme Smecher spake thusly: > On 2023-02-07 08:38, Yann E. MORIN wrote: > >On 2022-05-19 09:02 -0700, Graeme Smecher spake thusly: > >>The python-orjson build bails as follows when using musl libc: > >I could not reproduce such an error wit the following defconfig: [--SNIP--] > This patch is obsolete. I used to receive orjson build failures > associated with musl on a regular basis - they have tapered off since > mid-2022. In the meantime, Thomas has bisected the resolution to that commit from James: 2cbf1e4d3a1a package/python-orjson: convert to use the python-package infrastructure The commit before, it fails to build; with that commit, the build succeeds. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH v2] package/python-orjson: disallow build when using musl. 2023-02-07 17:29 ` Yann E. MORIN @ 2023-02-07 17:56 ` Graeme Smecher 0 siblings, 0 replies; 9+ messages in thread From: Graeme Smecher @ 2023-02-07 17:56 UTC (permalink / raw) To: Yann E. MORIN; +Cc: Thomas Petazzoni, buildroot Hi Yann, On 2023-02-07 09:29, Yann E. MORIN wrote: > Graeme, All, > > On 2023-02-07 09:14 -0800, Graeme Smecher spake thusly: >> On 2023-02-07 08:38, Yann E. MORIN wrote: >>> On 2022-05-19 09:02 -0700, Graeme Smecher spake thusly: >>>> The python-orjson build bails as follows when using musl libc: >>> I could not reproduce such an error wit the following defconfig: > [--SNIP--] >> This patch is obsolete. I used to receive orjson build failures >> associated with musl on a regular basis - they have tapered off since >> mid-2022. > > In the meantime, Thomas has bisected the resolution to that commit from > James: > > 2cbf1e4d3a1a package/python-orjson: convert to use the python-package infrastructure > > The commit before, it fails to build; with that commit, the build > succeeds. Excellent - two birds, one stone. Thanks again for all your work. best, Graeme _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/python-orjson: bump version to 3.6.8. 2022-05-09 19:06 [Buildroot] [PATCH 1/2] package/python-orjson: bump version to 3.6.8 Graeme Smecher 2022-05-09 19:06 ` [Buildroot] [PATCH 2/2] package/python-orjson: disallow build when using musl Graeme Smecher @ 2022-05-09 22:14 ` James Hilliard 2022-07-24 7:40 ` Thomas Petazzoni via buildroot 2 siblings, 0 replies; 9+ messages in thread From: James Hilliard @ 2022-05-09 22:14 UTC (permalink / raw) To: Graeme Smecher; +Cc: Asaf Kahlon, buildroot On Mon, May 9, 2022 at 1:07 PM Graeme Smecher <gsmecher@threespeedlogic.com> wrote: > > Signed-off-by: Graeme Smecher <gsmecher@threespeedlogic.com> > --- > package/python-orjson/python-orjson.hash | 2 +- > package/python-orjson/python-orjson.mk | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/python-orjson/python-orjson.hash b/package/python-orjson/python-orjson.hash > index 5ef2726d82..2c00164702 100644 > --- a/package/python-orjson/python-orjson.hash > +++ b/package/python-orjson/python-orjson.hash > @@ -1,4 +1,4 @@ > # Locally calculated > -sha256 4713b120ad86b1b273f5952cbf9578c13d0f453064bd26d823e04a10c84824e6 python-orjson-3.6.7.tar.gz > +sha256 2b0259ff26455c4f9ad2290b49ba184a35e98eea4839f0d6d5c2b7d91383b3d9 python-orjson-3.6.8.tar.gz > sha256 a60eea817514531668d7e00765731449fe14d059d3249e0bc93b36de45f759f2 LICENSE-APACHE > sha256 23f18e03dc49df91622fe2a76176497404e46ced8a715d9d2b67a7446571cca3 LICENSE-MIT > diff --git a/package/python-orjson/python-orjson.mk b/package/python-orjson/python-orjson.mk > index 5de4b2c5fa..cfcaedc280 100644 > --- a/package/python-orjson/python-orjson.mk > +++ b/package/python-orjson/python-orjson.mk > @@ -4,7 +4,7 @@ > # > ################################################################################ > > -PYTHON_ORJSON_VERSION = 3.6.7 > +PYTHON_ORJSON_VERSION = 3.6.8 > PYTHON_ORJSON_SITE = $(call github,ijl,orjson,$(PYTHON_ORJSON_VERSION)) This package should be using the python package infrastructure instead of cargo, I went ahead and converted it here: https://patchwork.ozlabs.org/project/buildroot/patch/20220509221055.335263-2-james.hilliard1@gmail.com/ I just needed to add the maturin pep517 backend here: https://patchwork.ozlabs.org/project/buildroot/patch/20220509221055.335263-1-james.hilliard1@gmail.com/ > PYTHON_ORJSON_LICENSE = Apache-2.0 or MIT > PYTHON_ORJSON_LICENSE_FILES = LICENSE-APACHE LICENSE-MIT > -- > 2.35.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/python-orjson: bump version to 3.6.8. 2022-05-09 19:06 [Buildroot] [PATCH 1/2] package/python-orjson: bump version to 3.6.8 Graeme Smecher 2022-05-09 19:06 ` [Buildroot] [PATCH 2/2] package/python-orjson: disallow build when using musl Graeme Smecher 2022-05-09 22:14 ` [Buildroot] [PATCH 1/2] package/python-orjson: bump version to 3.6.8 James Hilliard @ 2022-07-24 7:40 ` Thomas Petazzoni via buildroot 2 siblings, 0 replies; 9+ messages in thread From: Thomas Petazzoni via buildroot @ 2022-07-24 7:40 UTC (permalink / raw) To: Graeme Smecher; +Cc: Asaf Kahlon, buildroot On Mon, 9 May 2022 12:06:49 -0700 Graeme Smecher <gsmecher@threespeedlogic.com> wrote: > Signed-off-by: Graeme Smecher <gsmecher@threespeedlogic.com> > --- > package/python-orjson/python-orjson.hash | 2 +- > package/python-orjson/python-orjson.mk | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Applied to master, thanks. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-02-07 17:57 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-05-09 19:06 [Buildroot] [PATCH 1/2] package/python-orjson: bump version to 3.6.8 Graeme Smecher 2022-05-09 19:06 ` [Buildroot] [PATCH 2/2] package/python-orjson: disallow build when using musl Graeme Smecher 2022-05-19 16:02 ` [Buildroot] [PATCH v2] " Graeme Smecher 2023-02-07 16:38 ` Yann E. MORIN 2023-02-07 17:14 ` Graeme Smecher 2023-02-07 17:29 ` Yann E. MORIN 2023-02-07 17:56 ` Graeme Smecher 2022-05-09 22:14 ` [Buildroot] [PATCH 1/2] package/python-orjson: bump version to 3.6.8 James Hilliard 2022-07-24 7:40 ` Thomas Petazzoni via buildroot
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.