* [PATCH] virtio_net: Remove unused case in virtio_skb_set_hash()
@ 2022-05-09 13:14 Tang Bin
2022-05-10 2:05 ` Jason Wang
2022-05-10 5:22 ` Michael S. Tsirkin
0 siblings, 2 replies; 5+ messages in thread
From: Tang Bin @ 2022-05-09 13:14 UTC (permalink / raw)
To: mst, jasowang, davem, kuba, pabeni
Cc: virtualization, netdev, linux-kernel, Tang Bin
In this function, "VIRTIO_NET_HASH_REPORT_NONE" is included
in "default", so it canbe removed.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/net/virtio_net.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 87838cbe3..b3e5d8637 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1172,7 +1172,6 @@ static void virtio_skb_set_hash(const struct virtio_net_hdr_v1_hash *hdr_hash,
case VIRTIO_NET_HASH_REPORT_IPv6_EX:
rss_hash_type = PKT_HASH_TYPE_L3;
break;
- case VIRTIO_NET_HASH_REPORT_NONE:
default:
rss_hash_type = PKT_HASH_TYPE_NONE;
}
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] virtio_net: Remove unused case in virtio_skb_set_hash()
2022-05-09 13:14 [PATCH] virtio_net: Remove unused case in virtio_skb_set_hash() Tang Bin
@ 2022-05-10 2:05 ` Jason Wang
2022-05-10 5:22 ` Michael S. Tsirkin
1 sibling, 0 replies; 5+ messages in thread
From: Jason Wang @ 2022-05-10 2:05 UTC (permalink / raw)
To: Tang Bin
Cc: mst, davem, Jakub Kicinski, Paolo Abeni, virtualization, netdev,
linux-kernel
On Mon, May 9, 2022 at 9:17 PM Tang Bin <tangbin@cmss.chinamobile.com> wrote:
>
> In this function, "VIRTIO_NET_HASH_REPORT_NONE" is included
> in "default", so it canbe removed.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> drivers/net/virtio_net.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 87838cbe3..b3e5d8637 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1172,7 +1172,6 @@ static void virtio_skb_set_hash(const struct virtio_net_hdr_v1_hash *hdr_hash,
> case VIRTIO_NET_HASH_REPORT_IPv6_EX:
> rss_hash_type = PKT_HASH_TYPE_L3;
> break;
> - case VIRTIO_NET_HASH_REPORT_NONE:
> default:
> rss_hash_type = PKT_HASH_TYPE_NONE;
I wonder if we need to do things in the reverse. Warn for default and
only set NONE when it's NONE?
Thanks
> }
> --
> 2.20.1.windows.1
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] virtio_net: Remove unused case in virtio_skb_set_hash()
@ 2022-05-10 2:05 ` Jason Wang
0 siblings, 0 replies; 5+ messages in thread
From: Jason Wang @ 2022-05-10 2:05 UTC (permalink / raw)
To: Tang Bin
Cc: mst, netdev, linux-kernel, virtualization, Jakub Kicinski,
Paolo Abeni, davem
On Mon, May 9, 2022 at 9:17 PM Tang Bin <tangbin@cmss.chinamobile.com> wrote:
>
> In this function, "VIRTIO_NET_HASH_REPORT_NONE" is included
> in "default", so it canbe removed.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> drivers/net/virtio_net.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 87838cbe3..b3e5d8637 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1172,7 +1172,6 @@ static void virtio_skb_set_hash(const struct virtio_net_hdr_v1_hash *hdr_hash,
> case VIRTIO_NET_HASH_REPORT_IPv6_EX:
> rss_hash_type = PKT_HASH_TYPE_L3;
> break;
> - case VIRTIO_NET_HASH_REPORT_NONE:
> default:
> rss_hash_type = PKT_HASH_TYPE_NONE;
I wonder if we need to do things in the reverse. Warn for default and
only set NONE when it's NONE?
Thanks
> }
> --
> 2.20.1.windows.1
>
>
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] virtio_net: Remove unused case in virtio_skb_set_hash()
2022-05-09 13:14 [PATCH] virtio_net: Remove unused case in virtio_skb_set_hash() Tang Bin
@ 2022-05-10 5:22 ` Michael S. Tsirkin
2022-05-10 5:22 ` Michael S. Tsirkin
1 sibling, 0 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2022-05-10 5:22 UTC (permalink / raw)
To: Tang Bin
Cc: jasowang, davem, kuba, pabeni, virtualization, netdev, linux-kernel
On Mon, May 09, 2022 at 09:14:32PM +0800, Tang Bin wrote:
> In this function, "VIRTIO_NET_HASH_REPORT_NONE" is included
> in "default", so it canbe removed.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
What's the point of this?
> ---
> drivers/net/virtio_net.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 87838cbe3..b3e5d8637 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1172,7 +1172,6 @@ static void virtio_skb_set_hash(const struct virtio_net_hdr_v1_hash *hdr_hash,
> case VIRTIO_NET_HASH_REPORT_IPv6_EX:
> rss_hash_type = PKT_HASH_TYPE_L3;
> break;
> - case VIRTIO_NET_HASH_REPORT_NONE:
> default:
> rss_hash_type = PKT_HASH_TYPE_NONE;
> }
> --
> 2.20.1.windows.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] virtio_net: Remove unused case in virtio_skb_set_hash()
@ 2022-05-10 5:22 ` Michael S. Tsirkin
0 siblings, 0 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2022-05-10 5:22 UTC (permalink / raw)
To: Tang Bin; +Cc: netdev, linux-kernel, virtualization, kuba, pabeni, davem
On Mon, May 09, 2022 at 09:14:32PM +0800, Tang Bin wrote:
> In this function, "VIRTIO_NET_HASH_REPORT_NONE" is included
> in "default", so it canbe removed.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
What's the point of this?
> ---
> drivers/net/virtio_net.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 87838cbe3..b3e5d8637 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1172,7 +1172,6 @@ static void virtio_skb_set_hash(const struct virtio_net_hdr_v1_hash *hdr_hash,
> case VIRTIO_NET_HASH_REPORT_IPv6_EX:
> rss_hash_type = PKT_HASH_TYPE_L3;
> break;
> - case VIRTIO_NET_HASH_REPORT_NONE:
> default:
> rss_hash_type = PKT_HASH_TYPE_NONE;
> }
> --
> 2.20.1.windows.1
>
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-05-10 5:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-09 13:14 [PATCH] virtio_net: Remove unused case in virtio_skb_set_hash() Tang Bin
2022-05-10 2:05 ` Jason Wang
2022-05-10 2:05 ` Jason Wang
2022-05-10 5:22 ` Michael S. Tsirkin
2022-05-10 5:22 ` Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.