* [PATCH] toshiba_acpi: use kobj_to_dev()
@ 2022-05-10 10:52 cgel.zte
2022-05-10 12:14 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: cgel.zte @ 2022-05-10 10:52 UTC (permalink / raw)
To: coproscefalo
Cc: hdegoede, markgross, platform-driver-x86, linux-kernel,
Minghao Chi, Zeal Robot
From: Minghao Chi <chi.minghao@zte.com.cn>
Use kobj_to_dev() instead of open-coding it.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/platform/x86/toshiba_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
index f113dec98e21..0fc9e8b8827b 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
@@ -2353,7 +2353,7 @@ static struct attribute *toshiba_attributes[] = {
static umode_t toshiba_sysfs_is_visible(struct kobject *kobj,
struct attribute *attr, int idx)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct toshiba_acpi_dev *drv = dev_get_drvdata(dev);
bool exists = true;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] toshiba_acpi: use kobj_to_dev()
2022-05-10 10:52 [PATCH] toshiba_acpi: use kobj_to_dev() cgel.zte
@ 2022-05-10 12:14 ` Andy Shevchenko
2022-05-11 2:16 ` [PATCH V2] " cgel.zte
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2022-05-10 12:14 UTC (permalink / raw)
To: cgel.zte
Cc: Azael Avalos, Hans de Goede, Mark Gross, Platform Driver,
Linux Kernel Mailing List, Minghao Chi, Zeal Robot
On Tue, May 10, 2022 at 1:58 PM <cgel.zte@gmail.com> wrote:
>
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Use kobj_to_dev() instead of open-coding it.
> Reported-by: Zeal Robot <zealci@zte.com.cn>
Same comment as per your other patch.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V2] toshiba_acpi: use kobj_to_dev()
2022-05-10 12:14 ` Andy Shevchenko
@ 2022-05-11 2:16 ` cgel.zte
2022-05-11 9:19 ` Andy Shevchenko
2022-05-11 16:04 ` Hans de Goede
0 siblings, 2 replies; 5+ messages in thread
From: cgel.zte @ 2022-05-11 2:16 UTC (permalink / raw)
To: andy.shevchenko
Cc: cgel.zte, chi.minghao, coproscefalo, hdegoede, linux-kernel,
markgross, platform-driver-x86, zealci
From: Minghao Chi <chi.minghao@zte.com.cn>
Use kobj_to_dev() instead of open-coding it.
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
v1->v2:
remove Reported-by: Zeal Robot <zealci@zte.com.cn>
drivers/platform/x86/toshiba_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index f113dec98e21..0fc9e8b8827b 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
@@ -2353,7 +2353,7 @@ static struct attribute *toshiba_attributes[] = {
static umode_t toshiba_sysfs_is_visible(struct kobject *kobj,
struct attribute *attr, int idx)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct toshiba_acpi_dev *drv = dev_get_drvdata(dev);
bool exists = true;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH V2] toshiba_acpi: use kobj_to_dev()
2022-05-11 2:16 ` [PATCH V2] " cgel.zte
@ 2022-05-11 9:19 ` Andy Shevchenko
2022-05-11 16:04 ` Hans de Goede
1 sibling, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2022-05-11 9:19 UTC (permalink / raw)
To: cgel.zte
Cc: Minghao Chi, Azael Avalos, Hans de Goede,
Linux Kernel Mailing List, Mark Gross, Platform Driver,
Zeal Robot
On Wed, May 11, 2022 at 4:16 AM <cgel.zte@gmail.com> wrote:
>
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Use kobj_to_dev() instead of open-coding it.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> v1->v2:
> remove Reported-by: Zeal Robot <zealci@zte.com.cn>
>
> drivers/platform/x86/toshiba_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/toshiba_acpi.c
> b/drivers/platform/x86/toshiba_acpi.c
> index f113dec98e21..0fc9e8b8827b 100644
> --- a/drivers/platform/x86/toshiba_acpi.c
> +++ b/drivers/platform/x86/toshiba_acpi.c
> @@ -2353,7 +2353,7 @@ static struct attribute *toshiba_attributes[] = {
> static umode_t toshiba_sysfs_is_visible(struct kobject *kobj,
> struct attribute *attr, int idx)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct toshiba_acpi_dev *drv = dev_get_drvdata(dev);
> bool exists = true;
>
> --
> 2.25.1
>
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH V2] toshiba_acpi: use kobj_to_dev()
2022-05-11 2:16 ` [PATCH V2] " cgel.zte
2022-05-11 9:19 ` Andy Shevchenko
@ 2022-05-11 16:04 ` Hans de Goede
1 sibling, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2022-05-11 16:04 UTC (permalink / raw)
To: cgel.zte, andy.shevchenko
Cc: chi.minghao, coproscefalo, linux-kernel, markgross,
platform-driver-x86, zealci
Hi,
On 5/11/22 04:16, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Use kobj_to_dev() instead of open-coding it.
>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> v1->v2:
> remove Reported-by: Zeal Robot <zealci@zte.com.cn>
>
> drivers/platform/x86/toshiba_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/toshiba_acpi.c
> b/drivers/platform/x86/toshiba_acpi.c
> index f113dec98e21..0fc9e8b8827b 100644
> --- a/drivers/platform/x86/toshiba_acpi.c
> +++ b/drivers/platform/x86/toshiba_acpi.c
> @@ -2353,7 +2353,7 @@ static struct attribute *toshiba_attributes[] = {
> static umode_t toshiba_sysfs_is_visible(struct kobject *kobj,
> struct attribute *attr, int idx)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct toshiba_acpi_dev *drv = dev_get_drvdata(dev);
> bool exists = true;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-05-11 16:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10 10:52 [PATCH] toshiba_acpi: use kobj_to_dev() cgel.zte
2022-05-10 12:14 ` Andy Shevchenko
2022-05-11 2:16 ` [PATCH V2] " cgel.zte
2022-05-11 9:19 ` Andy Shevchenko
2022-05-11 16:04 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.