From: Sasha Levin <sashal@kernel.org> To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sasha Levin <sashal@kernel.org>, alsa-devel@alsa-project.org, lgirdwood@gmail.com, pierre-louis.bossart@linux.intel.com, tiwai@suse.com, Mark Brown <broonie@kernel.org> Subject: [PATCH AUTOSEL 5.4 3/8] ASoC: max98090: Generate notifications on changes for custom control Date: Tue, 10 May 2022 11:45:31 -0400 [thread overview] Message-ID: <20220510154536.154070-3-sashal@kernel.org> (raw) In-Reply-To: <20220510154536.154070-1-sashal@kernel.org> From: Mark Brown <broonie@kernel.org> [ Upstream commit 13fcf676d9e102594effc686d98521ff5c90b925 ] The max98090 driver has some custom controls which share a put() function which returns 0 unconditionally, meaning that events are not generated when the value changes. Fix that. Signed-off-by: Mark Brown <broonie@kernel.org> Link: https://lore.kernel.org/r/20220420193454.2647908-2-broonie@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- sound/soc/codecs/max98090.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index 207cdcfb6ebb..ce9f99dd3e87 100644 --- a/sound/soc/codecs/max98090.c +++ b/sound/soc/codecs/max98090.c @@ -430,7 +430,7 @@ static int max98090_put_enab_tlv(struct snd_kcontrol *kcontrol, mask << mc->shift, sel << mc->shift); - return 0; + return *select != val; } static const char *max98090_perf_pwr_text[] = -- 2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sashal@kernel.org> To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mark Brown <broonie@kernel.org>, Sasha Levin <sashal@kernel.org>, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.4 3/8] ASoC: max98090: Generate notifications on changes for custom control Date: Tue, 10 May 2022 11:45:31 -0400 [thread overview] Message-ID: <20220510154536.154070-3-sashal@kernel.org> (raw) In-Reply-To: <20220510154536.154070-1-sashal@kernel.org> From: Mark Brown <broonie@kernel.org> [ Upstream commit 13fcf676d9e102594effc686d98521ff5c90b925 ] The max98090 driver has some custom controls which share a put() function which returns 0 unconditionally, meaning that events are not generated when the value changes. Fix that. Signed-off-by: Mark Brown <broonie@kernel.org> Link: https://lore.kernel.org/r/20220420193454.2647908-2-broonie@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- sound/soc/codecs/max98090.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index 207cdcfb6ebb..ce9f99dd3e87 100644 --- a/sound/soc/codecs/max98090.c +++ b/sound/soc/codecs/max98090.c @@ -430,7 +430,7 @@ static int max98090_put_enab_tlv(struct snd_kcontrol *kcontrol, mask << mc->shift, sel << mc->shift); - return 0; + return *select != val; } static const char *max98090_perf_pwr_text[] = -- 2.35.1
next prev parent reply other threads:[~2022-05-10 15:48 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-10 15:45 [PATCH AUTOSEL 5.4 1/8] hwmon: (f71882fg) Fix negative temperature Sasha Levin 2022-05-10 15:45 ` [PATCH AUTOSEL 5.4 2/8] ASoC: max98090: Reject invalid values in custom control put() Sasha Levin 2022-05-10 15:45 ` Sasha Levin 2022-05-10 15:45 ` Sasha Levin [this message] 2022-05-10 15:45 ` [PATCH AUTOSEL 5.4 3/8] ASoC: max98090: Generate notifications on changes for custom control Sasha Levin 2022-05-10 15:45 ` [PATCH AUTOSEL 5.4 4/8] ASoC: ops: Validate input values in snd_soc_put_volsw_range() Sasha Levin 2022-05-10 15:45 ` Sasha Levin 2022-05-10 15:45 ` [PATCH AUTOSEL 5.4 5/8] s390: disable -Warray-bounds Sasha Levin 2022-05-10 15:45 ` [PATCH AUTOSEL 5.4 6/8] net: emaclite: Don't advertise 1000BASE-T and do auto negotiation Sasha Levin 2022-05-10 15:45 ` Sasha Levin 2022-05-10 15:45 ` [PATCH AUTOSEL 5.4 7/8] tcp: resalt the secret every 10 seconds Sasha Levin 2022-05-10 15:45 ` [PATCH AUTOSEL 5.4 8/8] Revert "parisc: Fix patch code locking and flushing" Sasha Levin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220510154536.154070-3-sashal@kernel.org \ --to=sashal@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=stable@vger.kernel.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.