From: Douglas Anderson <dianders@chromium.org> To: dri-devel@lists.freedesktop.org Cc: Hsin-Yi Wang <hsinyi@chromium.org>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Philip Chen <philipchen@chromium.org>, Sankeerth Billakanti <quic_sbillaka@quicinc.com>, Robert Foss <robert.foss@linaro.org>, freedreno@lists.freedesktop.org, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, linux-arm-msm@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>, Douglas Anderson <dianders@chromium.org>, Alex Deucher <alexander.deucher@amd.com>, Andrzej Hajda <andrzej.hajda@intel.com>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, Javier Martinez Canillas <javierm@redhat.com>, Jernej Skrabec <jernej.skrabec@gmail.com>, Jonas Karlman <jonas@kwiboo.se>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Linus Walleij <linus.walleij@linaro.org>, Lyude Paul <lyude@redhat.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Neil Armstrong <narmstrong@baylibre.com>, Thomas Zimmermann <tzimmermann@suse.de>, linux-kernel@vger.kernel.org Subject: [PATCH v3 0/4] drm/dp: Make DP AUX bus usage easier; use it on ps8640 Date: Tue, 10 May 2022 12:29:40 -0700 [thread overview] Message-ID: <20220510192944.2408515-1-dianders@chromium.org> (raw) This patch is v3 of the first 2 patches from my RFC series ("drm/dp: Improvements for DP AUX channel") [1]. I've broken the series in two so we can make progress on the two halves separately. v2 of this series tries to incorporate all the feedback from v1. Hopefully things are less confusing and simpler this time around. The one thing that got slightly more confusing is that the done_probing() callback can't return -EPROBE_DEFER in most cases so we have to adjust drivers a little more. v3 takes Dmitry's advice on v2. This now introduces devm_drm_bridge_add() (in an extra patch), splits some fixups into their own patch, uses a new name for functions, and requires an explicit call to done_probing if you have no children. The idea for this series came up during the review process of Sankeerth's series trying to add eDP for Qualcomm SoCs [2]. This _doesn't_ attempt to fix the Analogix driver. If this works out, ideally someone can post a patch up to do that. NOTE: I don't have any ps8640 devices that _don't_ use the aux panel underneath them, so I'm relying on code inspection to make sure I didn't break those. If someone sees that I did something wrong for that case then please yell! [1] https://lore.kernel.org/r/20220409023628.2104952-1-dianders@chromium.org/ [2] https://lore.kernel.org/r/1648656179-10347-2-git-send-email-quic_sbillaka@quicinc.com/ Changes in v3: - Adapt to v3 changes in aux bus. - Don't call done_probing() if there are no children; return -ENODEV. - Patch ("drm/bridge: Add devm_drm_bridge_add()") new for v3. - Patch ("drm/dp: Export symbol / kerneldoc fixes...") split for v3. - Split out EXPORT_SYMBOL and kerneldoc fixes to its own patch. - Use devm_drm_bridge_add() to simplify. - Used Dmitry's proposed name: of_dp_aux_populate_bus() Changes in v2: - Change to assume exactly one device. - Have a probe callback instead of an extra sub device. - Rewrote atop new method introduced by patch #1. Douglas Anderson (4): drm/dp: Export symbol / kerneldoc fixes for DP AUX bus drm/dp: Add callbacks to make using DP AUX bus properly easier drm/bridge: Add devm_drm_bridge_add() drm/bridge: parade-ps8640: Handle DP AUX more properly drivers/gpu/drm/bridge/parade-ps8640.c | 74 +++++--- drivers/gpu/drm/display/drm_dp_aux_bus.c | 211 +++++++++++++++-------- drivers/gpu/drm/drm_bridge.c | 23 +++ include/drm/display/drm_dp_aux_bus.h | 34 +++- include/drm/drm_bridge.h | 1 + 5 files changed, 238 insertions(+), 105 deletions(-) -- 2.36.0.550.gb090851708-goog
WARNING: multiple messages have this Message-ID (diff)
From: Douglas Anderson <dianders@chromium.org> To: dri-devel@lists.freedesktop.org Cc: Sankeerth Billakanti <quic_sbillaka@quicinc.com>, Neil Armstrong <narmstrong@baylibre.com>, David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Andrzej Hajda <andrzej.hajda@intel.com>, Javier Martinez Canillas <javierm@redhat.com>, Jernej Skrabec <jernej.skrabec@gmail.com>, Thomas Zimmermann <tzimmermann@suse.de>, Jonas Karlman <jonas@kwiboo.se>, linux-arm-msm@vger.kernel.org, Abhinav Kumar <quic_abhinavk@quicinc.com>, Stephen Boyd <swboyd@chromium.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Hsin-Yi Wang <hsinyi@chromium.org>, Philip Chen <philipchen@chromium.org>, Douglas Anderson <dianders@chromium.org>, Robert Foss <robert.foss@linaro.org>, Alex Deucher <alexander.deucher@amd.com>, freedreno@lists.freedesktop.org Subject: [PATCH v3 0/4] drm/dp: Make DP AUX bus usage easier; use it on ps8640 Date: Tue, 10 May 2022 12:29:40 -0700 [thread overview] Message-ID: <20220510192944.2408515-1-dianders@chromium.org> (raw) This patch is v3 of the first 2 patches from my RFC series ("drm/dp: Improvements for DP AUX channel") [1]. I've broken the series in two so we can make progress on the two halves separately. v2 of this series tries to incorporate all the feedback from v1. Hopefully things are less confusing and simpler this time around. The one thing that got slightly more confusing is that the done_probing() callback can't return -EPROBE_DEFER in most cases so we have to adjust drivers a little more. v3 takes Dmitry's advice on v2. This now introduces devm_drm_bridge_add() (in an extra patch), splits some fixups into their own patch, uses a new name for functions, and requires an explicit call to done_probing if you have no children. The idea for this series came up during the review process of Sankeerth's series trying to add eDP for Qualcomm SoCs [2]. This _doesn't_ attempt to fix the Analogix driver. If this works out, ideally someone can post a patch up to do that. NOTE: I don't have any ps8640 devices that _don't_ use the aux panel underneath them, so I'm relying on code inspection to make sure I didn't break those. If someone sees that I did something wrong for that case then please yell! [1] https://lore.kernel.org/r/20220409023628.2104952-1-dianders@chromium.org/ [2] https://lore.kernel.org/r/1648656179-10347-2-git-send-email-quic_sbillaka@quicinc.com/ Changes in v3: - Adapt to v3 changes in aux bus. - Don't call done_probing() if there are no children; return -ENODEV. - Patch ("drm/bridge: Add devm_drm_bridge_add()") new for v3. - Patch ("drm/dp: Export symbol / kerneldoc fixes...") split for v3. - Split out EXPORT_SYMBOL and kerneldoc fixes to its own patch. - Use devm_drm_bridge_add() to simplify. - Used Dmitry's proposed name: of_dp_aux_populate_bus() Changes in v2: - Change to assume exactly one device. - Have a probe callback instead of an extra sub device. - Rewrote atop new method introduced by patch #1. Douglas Anderson (4): drm/dp: Export symbol / kerneldoc fixes for DP AUX bus drm/dp: Add callbacks to make using DP AUX bus properly easier drm/bridge: Add devm_drm_bridge_add() drm/bridge: parade-ps8640: Handle DP AUX more properly drivers/gpu/drm/bridge/parade-ps8640.c | 74 +++++--- drivers/gpu/drm/display/drm_dp_aux_bus.c | 211 +++++++++++++++-------- drivers/gpu/drm/drm_bridge.c | 23 +++ include/drm/display/drm_dp_aux_bus.h | 34 +++- include/drm/drm_bridge.h | 1 + 5 files changed, 238 insertions(+), 105 deletions(-) -- 2.36.0.550.gb090851708-goog
next reply other threads:[~2022-05-10 19:30 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-10 19:29 Douglas Anderson [this message] 2022-05-10 19:29 ` [PATCH v3 0/4] drm/dp: Make DP AUX bus usage easier; use it on ps8640 Douglas Anderson 2022-05-10 19:29 ` [PATCH v3 1/4] drm/dp: Export symbol / kerneldoc fixes for DP AUX bus Douglas Anderson 2022-05-10 19:29 ` Douglas Anderson 2022-05-11 0:20 ` Dmitry Baryshkov 2022-05-11 0:20 ` Dmitry Baryshkov 2022-05-20 20:27 ` Doug Anderson 2022-05-20 20:27 ` Doug Anderson 2022-06-01 20:29 ` Dmitry Baryshkov 2022-06-01 20:29 ` Dmitry Baryshkov 2022-05-10 19:29 ` [PATCH v3 2/4] drm/dp: Add callbacks to make using DP AUX bus properly easier Douglas Anderson 2022-05-10 19:29 ` Douglas Anderson 2022-06-01 20:35 ` Dmitry Baryshkov 2022-06-01 20:35 ` Dmitry Baryshkov 2022-05-10 19:29 ` [PATCH v3 3/4] drm/bridge: Add devm_drm_bridge_add() Douglas Anderson 2022-05-10 19:29 ` Douglas Anderson 2022-05-11 0:22 ` Dmitry Baryshkov 2022-05-11 0:22 ` Dmitry Baryshkov 2022-05-20 20:28 ` Doug Anderson 2022-05-20 20:28 ` Doug Anderson 2022-05-21 9:17 ` Maxime Ripard 2022-05-21 9:17 ` Maxime Ripard 2022-05-23 17:00 ` Doug Anderson 2022-05-23 17:00 ` Doug Anderson 2022-05-31 21:06 ` Doug Anderson 2022-05-31 21:06 ` Doug Anderson 2022-06-03 8:21 ` Maxime Ripard 2022-06-03 8:21 ` Maxime Ripard 2022-06-03 10:19 ` Dmitry Baryshkov 2022-06-03 10:19 ` Dmitry Baryshkov 2022-06-03 13:52 ` Doug Anderson 2022-06-03 13:52 ` Doug Anderson 2022-06-03 14:16 ` Maxime Ripard 2022-06-03 14:16 ` Maxime Ripard 2022-06-03 14:14 ` Maxime Ripard 2022-06-03 14:14 ` Maxime Ripard 2022-06-03 14:56 ` Doug Anderson 2022-06-03 14:56 ` Doug Anderson 2022-06-09 13:30 ` Maxime Ripard 2022-06-09 13:30 ` Maxime Ripard 2022-06-08 15:50 ` Daniel Vetter 2022-06-08 15:50 ` Daniel Vetter 2022-05-10 19:29 ` [PATCH v3 4/4] drm/bridge: parade-ps8640: Handle DP AUX more properly Douglas Anderson 2022-05-10 19:29 ` Douglas Anderson 2022-06-01 20:46 ` Dmitry Baryshkov 2022-06-01 20:46 ` Dmitry Baryshkov 2022-05-31 21:03 ` [PATCH v3 0/4] drm/dp: Make DP AUX bus usage easier; use it on ps8640 Doug Anderson 2022-05-31 21:03 ` Doug Anderson 2022-06-02 22:18 ` Doug Anderson 2022-06-02 22:18 ` Doug Anderson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220510192944.2408515-1-dianders@chromium.org \ --to=dianders@chromium.org \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=airlied@linux.ie \ --cc=alexander.deucher@amd.com \ --cc=andrzej.hajda@intel.com \ --cc=daniel@ffwll.ch \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=hsinyi@chromium.org \ --cc=javierm@redhat.com \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lyude@redhat.com \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=narmstrong@baylibre.com \ --cc=philipchen@chromium.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_sbillaka@quicinc.com \ --cc=robert.foss@linaro.org \ --cc=swboyd@chromium.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.