All of lore.kernel.org
 help / color / mirror / Atom feed
* [mtd:spi-nor/next 16/18] drivers/mtd/spi-nor/debugfs.c:84 spi_nor_params_show() warn: '%ph' cannot be followed by 'n'
@ 2022-05-11 10:17 ` Dan Carpenter
  0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2022-05-10 19:10 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 8188 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Michael Walle <michael@walle.cc>
CC: Pratyush Yadav <p.yadav@ti.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next
head:   cdbc44dbb2c73d8bafa1a8ae0d780608be5dbd40
commit: 0257be79fc4a16a3252ce80aa13b3640f728c425 [16/18] mtd: spi-nor: expose internal parameters via debugfs
:::::: branch date: 32 hours ago
:::::: commit date: 32 hours ago
config: x86_64-randconfig-m001-20220509 (https://download.01.org/0day-ci/archive/20220511/202205110320.WNi7ZQaB-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/mtd/spi-nor/debugfs.c:84 spi_nor_params_show() warn: '%ph' cannot be followed by 'n'

vim +84 drivers/mtd/spi-nor/debugfs.c

0257be79fc4a16 Michael Walle 2022-04-29   72  
0257be79fc4a16 Michael Walle 2022-04-29   73  static int spi_nor_params_show(struct seq_file *s, void *data)
0257be79fc4a16 Michael Walle 2022-04-29   74  {
0257be79fc4a16 Michael Walle 2022-04-29   75  	struct spi_nor *nor = s->private;
0257be79fc4a16 Michael Walle 2022-04-29   76  	struct spi_nor_flash_parameter *params = nor->params;
0257be79fc4a16 Michael Walle 2022-04-29   77  	struct spi_nor_erase_map *erase_map = &params->erase_map;
0257be79fc4a16 Michael Walle 2022-04-29   78  	struct spi_nor_erase_region *region;
0257be79fc4a16 Michael Walle 2022-04-29   79  	const struct flash_info *info = nor->info;
0257be79fc4a16 Michael Walle 2022-04-29   80  	char buf[16], *str;
0257be79fc4a16 Michael Walle 2022-04-29   81  	int i;
0257be79fc4a16 Michael Walle 2022-04-29   82  
0257be79fc4a16 Michael Walle 2022-04-29   83  	seq_printf(s, "name\t\t%s\n", info->name);
0257be79fc4a16 Michael Walle 2022-04-29  @84  	seq_printf(s, "id\t\t%*phn\n", info->id_len, info->id);
0257be79fc4a16 Michael Walle 2022-04-29   85  	string_get_size(params->size, 1, STRING_UNITS_2, buf, sizeof(buf));
0257be79fc4a16 Michael Walle 2022-04-29   86  	seq_printf(s, "size\t\t%s\n", buf);
0257be79fc4a16 Michael Walle 2022-04-29   87  	seq_printf(s, "write size\t%u\n", params->writesize);
0257be79fc4a16 Michael Walle 2022-04-29   88  	seq_printf(s, "page size\t%u\n", params->page_size);
0257be79fc4a16 Michael Walle 2022-04-29   89  	seq_printf(s, "address width\t%u\n", nor->addr_width);
0257be79fc4a16 Michael Walle 2022-04-29   90  
0257be79fc4a16 Michael Walle 2022-04-29   91  	seq_puts(s, "flags\t\t");
0257be79fc4a16 Michael Walle 2022-04-29   92  	spi_nor_print_flags(s, nor->flags, snor_f_names, sizeof(snor_f_names));
0257be79fc4a16 Michael Walle 2022-04-29   93  	seq_puts(s, "\n");
0257be79fc4a16 Michael Walle 2022-04-29   94  
0257be79fc4a16 Michael Walle 2022-04-29   95  	seq_puts(s, "\nopcodes\n");
0257be79fc4a16 Michael Walle 2022-04-29   96  	seq_printf(s, " read\t\t0x%02x\n", nor->read_opcode);
0257be79fc4a16 Michael Walle 2022-04-29   97  	seq_printf(s, "  dummy cycles\t%u\n", nor->read_dummy);
0257be79fc4a16 Michael Walle 2022-04-29   98  	seq_printf(s, " erase\t\t0x%02x\n", nor->erase_opcode);
0257be79fc4a16 Michael Walle 2022-04-29   99  	seq_printf(s, " program\t0x%02x\n", nor->program_opcode);
0257be79fc4a16 Michael Walle 2022-04-29  100  
0257be79fc4a16 Michael Walle 2022-04-29  101  	switch (nor->cmd_ext_type) {
0257be79fc4a16 Michael Walle 2022-04-29  102  	case SPI_NOR_EXT_NONE:
0257be79fc4a16 Michael Walle 2022-04-29  103  		str = "none";
0257be79fc4a16 Michael Walle 2022-04-29  104  		break;
0257be79fc4a16 Michael Walle 2022-04-29  105  	case SPI_NOR_EXT_REPEAT:
0257be79fc4a16 Michael Walle 2022-04-29  106  		str = "repeat";
0257be79fc4a16 Michael Walle 2022-04-29  107  		break;
0257be79fc4a16 Michael Walle 2022-04-29  108  	case SPI_NOR_EXT_INVERT:
0257be79fc4a16 Michael Walle 2022-04-29  109  		str = "invert";
0257be79fc4a16 Michael Walle 2022-04-29  110  		break;
0257be79fc4a16 Michael Walle 2022-04-29  111  	default:
0257be79fc4a16 Michael Walle 2022-04-29  112  		str = "<unknown>";
0257be79fc4a16 Michael Walle 2022-04-29  113  		break;
0257be79fc4a16 Michael Walle 2022-04-29  114  	}
0257be79fc4a16 Michael Walle 2022-04-29  115  	seq_printf(s, " 8D extension\t%s\n", str);
0257be79fc4a16 Michael Walle 2022-04-29  116  
0257be79fc4a16 Michael Walle 2022-04-29  117  	seq_puts(s, "\nprotocols\n");
0257be79fc4a16 Michael Walle 2022-04-29  118  	seq_printf(s, " read\t\t%s\n",
0257be79fc4a16 Michael Walle 2022-04-29  119  		   spi_nor_protocol_name(nor->read_proto));
0257be79fc4a16 Michael Walle 2022-04-29  120  	seq_printf(s, " write\t\t%s\n",
0257be79fc4a16 Michael Walle 2022-04-29  121  		   spi_nor_protocol_name(nor->write_proto));
0257be79fc4a16 Michael Walle 2022-04-29  122  	seq_printf(s, " register\t%s\n",
0257be79fc4a16 Michael Walle 2022-04-29  123  		   spi_nor_protocol_name(nor->reg_proto));
0257be79fc4a16 Michael Walle 2022-04-29  124  
0257be79fc4a16 Michael Walle 2022-04-29  125  	seq_puts(s, "\nerase commands\n");
0257be79fc4a16 Michael Walle 2022-04-29  126  	for (i = 0; i < SNOR_ERASE_TYPE_MAX; i++) {
0257be79fc4a16 Michael Walle 2022-04-29  127  		struct spi_nor_erase_type *et = &erase_map->erase_type[i];
0257be79fc4a16 Michael Walle 2022-04-29  128  
0257be79fc4a16 Michael Walle 2022-04-29  129  		if (et->size) {
0257be79fc4a16 Michael Walle 2022-04-29  130  			string_get_size(et->size, 1, STRING_UNITS_2, buf,
0257be79fc4a16 Michael Walle 2022-04-29  131  					sizeof(buf));
0257be79fc4a16 Michael Walle 2022-04-29  132  			seq_printf(s, " %02x (%s) [%d]\n", et->opcode, buf, i);
0257be79fc4a16 Michael Walle 2022-04-29  133  		}
0257be79fc4a16 Michael Walle 2022-04-29  134  	}
0257be79fc4a16 Michael Walle 2022-04-29  135  
0257be79fc4a16 Michael Walle 2022-04-29  136  	if (!(nor->flags & SNOR_F_NO_OP_CHIP_ERASE)) {
0257be79fc4a16 Michael Walle 2022-04-29  137  		string_get_size(params->size, 1, STRING_UNITS_2, buf, sizeof(buf));
0257be79fc4a16 Michael Walle 2022-04-29  138  		seq_printf(s, " %02x (%s)\n", SPINOR_OP_CHIP_ERASE, buf);
0257be79fc4a16 Michael Walle 2022-04-29  139  	}
0257be79fc4a16 Michael Walle 2022-04-29  140  
0257be79fc4a16 Michael Walle 2022-04-29  141  	seq_puts(s, "\nsector map\n");
0257be79fc4a16 Michael Walle 2022-04-29  142  	seq_puts(s, " region (in hex)   | erase mask | flags\n");
0257be79fc4a16 Michael Walle 2022-04-29  143  	seq_puts(s, " ------------------+------------+----------\n");
0257be79fc4a16 Michael Walle 2022-04-29  144  	for (region = erase_map->regions;
0257be79fc4a16 Michael Walle 2022-04-29  145  	     region;
0257be79fc4a16 Michael Walle 2022-04-29  146  	     region = spi_nor_region_next(region)) {
0257be79fc4a16 Michael Walle 2022-04-29  147  		u64 start = region->offset & ~SNOR_ERASE_FLAGS_MASK;
0257be79fc4a16 Michael Walle 2022-04-29  148  		u64 flags = region->offset & SNOR_ERASE_FLAGS_MASK;
0257be79fc4a16 Michael Walle 2022-04-29  149  		u64 end = start + region->size - 1;
0257be79fc4a16 Michael Walle 2022-04-29  150  
0257be79fc4a16 Michael Walle 2022-04-29  151  		seq_printf(s, " %08llx-%08llx |     [%c%c%c%c] | %s\n",
0257be79fc4a16 Michael Walle 2022-04-29  152  			   start, end,
0257be79fc4a16 Michael Walle 2022-04-29  153  			   flags & BIT(0) ? '0' : ' ',
0257be79fc4a16 Michael Walle 2022-04-29  154  			   flags & BIT(1) ? '1' : ' ',
0257be79fc4a16 Michael Walle 2022-04-29  155  			   flags & BIT(2) ? '2' : ' ',
0257be79fc4a16 Michael Walle 2022-04-29  156  			   flags & BIT(3) ? '3' : ' ',
0257be79fc4a16 Michael Walle 2022-04-29  157  			   flags & SNOR_OVERLAID_REGION ? "overlaid" : "");
0257be79fc4a16 Michael Walle 2022-04-29  158  	}
0257be79fc4a16 Michael Walle 2022-04-29  159  
0257be79fc4a16 Michael Walle 2022-04-29  160  	return 0;
0257be79fc4a16 Michael Walle 2022-04-29  161  }
0257be79fc4a16 Michael Walle 2022-04-29  162  DEFINE_SHOW_ATTRIBUTE(spi_nor_params);
0257be79fc4a16 Michael Walle 2022-04-29  163  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [mtd:spi-nor/next 16/18] drivers/mtd/spi-nor/debugfs.c:84 spi_nor_params_show() warn: '%ph' cannot be followed by 'n'
@ 2022-05-11 10:17 ` Dan Carpenter
  0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2022-05-11 10:17 UTC (permalink / raw)
  To: kbuild, Michael Walle; +Cc: lkp, kbuild-all, linux-kernel, Pratyush Yadav

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next
head:   cdbc44dbb2c73d8bafa1a8ae0d780608be5dbd40
commit: 0257be79fc4a16a3252ce80aa13b3640f728c425 [16/18] mtd: spi-nor: expose internal parameters via debugfs
config: x86_64-randconfig-m001-20220509 (https://download.01.org/0day-ci/archive/20220511/202205110320.WNi7ZQaB-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/mtd/spi-nor/debugfs.c:84 spi_nor_params_show() warn: '%ph' cannot be followed by 'n'

vim +84 drivers/mtd/spi-nor/debugfs.c

0257be79fc4a16 Michael Walle 2022-04-29   73  static int spi_nor_params_show(struct seq_file *s, void *data)
0257be79fc4a16 Michael Walle 2022-04-29   74  {
0257be79fc4a16 Michael Walle 2022-04-29   75  	struct spi_nor *nor = s->private;
0257be79fc4a16 Michael Walle 2022-04-29   76  	struct spi_nor_flash_parameter *params = nor->params;
0257be79fc4a16 Michael Walle 2022-04-29   77  	struct spi_nor_erase_map *erase_map = &params->erase_map;
0257be79fc4a16 Michael Walle 2022-04-29   78  	struct spi_nor_erase_region *region;
0257be79fc4a16 Michael Walle 2022-04-29   79  	const struct flash_info *info = nor->info;
0257be79fc4a16 Michael Walle 2022-04-29   80  	char buf[16], *str;
0257be79fc4a16 Michael Walle 2022-04-29   81  	int i;
0257be79fc4a16 Michael Walle 2022-04-29   82  
0257be79fc4a16 Michael Walle 2022-04-29   83  	seq_printf(s, "name\t\t%s\n", info->name);
0257be79fc4a16 Michael Walle 2022-04-29  @84  	seq_printf(s, "id\t\t%*phn\n", info->id_len, info->id);

Maybe N was intended instead of n?  (I have no idea).

0257be79fc4a16 Michael Walle 2022-04-29   85  	string_get_size(params->size, 1, STRING_UNITS_2, buf, sizeof(buf));
0257be79fc4a16 Michael Walle 2022-04-29   86  	seq_printf(s, "size\t\t%s\n", buf);
0257be79fc4a16 Michael Walle 2022-04-29   87  	seq_printf(s, "write size\t%u\n", params->writesize);
0257be79fc4a16 Michael Walle 2022-04-29   88  	seq_printf(s, "page size\t%u\n", params->page_size);
0257be79fc4a16 Michael Walle 2022-04-29   89  	seq_printf(s, "address width\t%u\n", nor->addr_width);
0257be79fc4a16 Michael Walle 2022-04-29   90  
0257be79fc4a16 Michael Walle 2022-04-29   91  	seq_puts(s, "flags\t\t");

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [mtd:spi-nor/next 16/18] drivers/mtd/spi-nor/debugfs.c:84 spi_nor_params_show() warn: '%ph' cannot be followed by 'n'
@ 2022-05-11 10:17 ` Dan Carpenter
  0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2022-05-11 10:17 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2486 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next
head:   cdbc44dbb2c73d8bafa1a8ae0d780608be5dbd40
commit: 0257be79fc4a16a3252ce80aa13b3640f728c425 [16/18] mtd: spi-nor: expose internal parameters via debugfs
config: x86_64-randconfig-m001-20220509 (https://download.01.org/0day-ci/archive/20220511/202205110320.WNi7ZQaB-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/mtd/spi-nor/debugfs.c:84 spi_nor_params_show() warn: '%ph' cannot be followed by 'n'

vim +84 drivers/mtd/spi-nor/debugfs.c

0257be79fc4a16 Michael Walle 2022-04-29   73  static int spi_nor_params_show(struct seq_file *s, void *data)
0257be79fc4a16 Michael Walle 2022-04-29   74  {
0257be79fc4a16 Michael Walle 2022-04-29   75  	struct spi_nor *nor = s->private;
0257be79fc4a16 Michael Walle 2022-04-29   76  	struct spi_nor_flash_parameter *params = nor->params;
0257be79fc4a16 Michael Walle 2022-04-29   77  	struct spi_nor_erase_map *erase_map = &params->erase_map;
0257be79fc4a16 Michael Walle 2022-04-29   78  	struct spi_nor_erase_region *region;
0257be79fc4a16 Michael Walle 2022-04-29   79  	const struct flash_info *info = nor->info;
0257be79fc4a16 Michael Walle 2022-04-29   80  	char buf[16], *str;
0257be79fc4a16 Michael Walle 2022-04-29   81  	int i;
0257be79fc4a16 Michael Walle 2022-04-29   82  
0257be79fc4a16 Michael Walle 2022-04-29   83  	seq_printf(s, "name\t\t%s\n", info->name);
0257be79fc4a16 Michael Walle 2022-04-29  @84  	seq_printf(s, "id\t\t%*phn\n", info->id_len, info->id);

Maybe N was intended instead of n?  (I have no idea).

0257be79fc4a16 Michael Walle 2022-04-29   85  	string_get_size(params->size, 1, STRING_UNITS_2, buf, sizeof(buf));
0257be79fc4a16 Michael Walle 2022-04-29   86  	seq_printf(s, "size\t\t%s\n", buf);
0257be79fc4a16 Michael Walle 2022-04-29   87  	seq_printf(s, "write size\t%u\n", params->writesize);
0257be79fc4a16 Michael Walle 2022-04-29   88  	seq_printf(s, "page size\t%u\n", params->page_size);
0257be79fc4a16 Michael Walle 2022-04-29   89  	seq_printf(s, "address width\t%u\n", nor->addr_width);
0257be79fc4a16 Michael Walle 2022-04-29   90  
0257be79fc4a16 Michael Walle 2022-04-29   91  	seq_puts(s, "flags\t\t");

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [mtd:spi-nor/next 16/18] drivers/mtd/spi-nor/debugfs.c:84 spi_nor_params_show() warn: '%ph' cannot be followed by 'n'
  2022-05-11 10:17 ` Dan Carpenter
@ 2022-05-11 11:35   ` Michael Walle
  -1 siblings, 0 replies; 5+ messages in thread
From: Michael Walle @ 2022-05-11 11:35 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: kbuild, lkp, kbuild-all, linux-kernel, Pratyush Yadav

Am 2022-05-11 12:17, schrieb Dan Carpenter:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
> spi-nor/next
> head:   cdbc44dbb2c73d8bafa1a8ae0d780608be5dbd40
> commit: 0257be79fc4a16a3252ce80aa13b3640f728c425 [16/18] mtd: spi-nor:
> expose internal parameters via debugfs
> config: x86_64-randconfig-m001-20220509
> (https://download.01.org/0day-ci/archive/20220511/202205110320.WNi7ZQaB-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> smatch warnings:
> drivers/mtd/spi-nor/debugfs.c:84 spi_nor_params_show() warn: '%ph'
> cannot be followed by 'n'
> 
> vim +84 drivers/mtd/spi-nor/debugfs.c
> 
> 0257be79fc4a16 Michael Walle 2022-04-29   73  static int
> spi_nor_params_show(struct seq_file *s, void *data)
> 0257be79fc4a16 Michael Walle 2022-04-29   74  {
> 0257be79fc4a16 Michael Walle 2022-04-29   75  	struct spi_nor *nor = 
> s->private;
> 0257be79fc4a16 Michael Walle 2022-04-29   76  	struct
> spi_nor_flash_parameter *params = nor->params;
> 0257be79fc4a16 Michael Walle 2022-04-29   77  	struct
> spi_nor_erase_map *erase_map = &params->erase_map;
> 0257be79fc4a16 Michael Walle 2022-04-29   78  	struct
> spi_nor_erase_region *region;
> 0257be79fc4a16 Michael Walle 2022-04-29   79  	const struct flash_info
> *info = nor->info;
> 0257be79fc4a16 Michael Walle 2022-04-29   80  	char buf[16], *str;
> 0257be79fc4a16 Michael Walle 2022-04-29   81  	int i;
> 0257be79fc4a16 Michael Walle 2022-04-29   82
> 0257be79fc4a16 Michael Walle 2022-04-29   83  	seq_printf(s,
> "name\t\t%s\n", info->name);
> 0257be79fc4a16 Michael Walle 2022-04-29  @84  	seq_printf(s,
> "id\t\t%*phn\n", info->id_len, info->id);
> 
> Maybe N was intended instead of n?  (I have no idea).

Thanks for reporting. Yeah I had %*phN previously but then
I wanted to switch to "xx xx xx" style and i missed checking
printk-formats.rst. %*phn worked as intended ;) I'll send
a fixup patch.

-michael

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [mtd:spi-nor/next 16/18] drivers/mtd/spi-nor/debugfs.c:84 spi_nor_params_show() warn: '%ph' cannot be followed by 'n'
@ 2022-05-11 11:35   ` Michael Walle
  0 siblings, 0 replies; 5+ messages in thread
From: Michael Walle @ 2022-05-11 11:35 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2146 bytes --]

Am 2022-05-11 12:17, schrieb Dan Carpenter:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
> spi-nor/next
> head:   cdbc44dbb2c73d8bafa1a8ae0d780608be5dbd40
> commit: 0257be79fc4a16a3252ce80aa13b3640f728c425 [16/18] mtd: spi-nor:
> expose internal parameters via debugfs
> config: x86_64-randconfig-m001-20220509
> (https://download.01.org/0day-ci/archive/20220511/202205110320.WNi7ZQaB-lkp(a)intel.com/config)
> compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> smatch warnings:
> drivers/mtd/spi-nor/debugfs.c:84 spi_nor_params_show() warn: '%ph'
> cannot be followed by 'n'
> 
> vim +84 drivers/mtd/spi-nor/debugfs.c
> 
> 0257be79fc4a16 Michael Walle 2022-04-29   73  static int
> spi_nor_params_show(struct seq_file *s, void *data)
> 0257be79fc4a16 Michael Walle 2022-04-29   74  {
> 0257be79fc4a16 Michael Walle 2022-04-29   75  	struct spi_nor *nor = 
> s->private;
> 0257be79fc4a16 Michael Walle 2022-04-29   76  	struct
> spi_nor_flash_parameter *params = nor->params;
> 0257be79fc4a16 Michael Walle 2022-04-29   77  	struct
> spi_nor_erase_map *erase_map = &params->erase_map;
> 0257be79fc4a16 Michael Walle 2022-04-29   78  	struct
> spi_nor_erase_region *region;
> 0257be79fc4a16 Michael Walle 2022-04-29   79  	const struct flash_info
> *info = nor->info;
> 0257be79fc4a16 Michael Walle 2022-04-29   80  	char buf[16], *str;
> 0257be79fc4a16 Michael Walle 2022-04-29   81  	int i;
> 0257be79fc4a16 Michael Walle 2022-04-29   82
> 0257be79fc4a16 Michael Walle 2022-04-29   83  	seq_printf(s,
> "name\t\t%s\n", info->name);
> 0257be79fc4a16 Michael Walle 2022-04-29  @84  	seq_printf(s,
> "id\t\t%*phn\n", info->id_len, info->id);
> 
> Maybe N was intended instead of n?  (I have no idea).

Thanks for reporting. Yeah I had %*phN previously but then
I wanted to switch to "xx xx xx" style and i missed checking
printk-formats.rst. %*phn worked as intended ;) I'll send
a fixup patch.

-michael

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-05-11 11:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10 19:10 [mtd:spi-nor/next 16/18] drivers/mtd/spi-nor/debugfs.c:84 spi_nor_params_show() warn: '%ph' cannot be followed by 'n' kernel test robot
2022-05-11 10:17 ` Dan Carpenter
2022-05-11 10:17 ` Dan Carpenter
2022-05-11 11:35 ` Michael Walle
2022-05-11 11:35   ` Michael Walle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.