All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH v2] wxwidgets: enable to use private fonts
@ 2022-05-11  7:45 kai.kang
  2022-05-11 15:21 ` [oe] " Khem Raj
  0 siblings, 1 reply; 5+ messages in thread
From: kai.kang @ 2022-05-11  7:45 UTC (permalink / raw)
  To: openembedded-devel

From: Kai Kang <kai.kang@windriver.com>

Enable option wxUSE_PRIVATE_FONTS of wxwidgets if build with gtk. It
allows application to use the font from the given file even if it is
not globally installed on the system.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
v2:
* use upper case 'ON' to align with others in oe

 meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb b/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb
index 6b57cb54c..b9b1dcf0d 100644
--- a/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb
+++ b/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb
@@ -39,6 +39,7 @@ EXTRA_OECMAKE += " \
     -DwxUSE_LIBTIFF=sys \
     -DwxUSE_REGEX=builtin \
     -DwxPLATFORM_LIB_DIR=${@d.getVar('baselib').replace('lib', '')} \
+    ${@bb.utils.contains('PACKAGECONFIG', 'gtk', '-DwxUSE_PRIVATE_FONTS=ON', '', d)} \
 "
 EXTRA_OECMAKE:append:libc-musl = " \
     -DHAVE_LOCALE_T=OFF \
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [oe] [meta-oe][PATCH v2] wxwidgets: enable to use private fonts
  2022-05-11  7:45 [meta-oe][PATCH v2] wxwidgets: enable to use private fonts kai.kang
@ 2022-05-11 15:21 ` Khem Raj
  2022-05-12  6:22   ` Kai
  0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2022-05-11 15:21 UTC (permalink / raw)
  To: kai; +Cc: openembeded-devel

On Wed, May 11, 2022 at 12:45 AM kai <kai.kang@windriver.com> wrote:
>
> From: Kai Kang <kai.kang@windriver.com>
>
> Enable option wxUSE_PRIVATE_FONTS of wxwidgets if build with gtk. It
> allows application to use the font from the given file even if it is
> not globally installed on the system.
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
> v2:
> * use upper case 'ON' to align with others in oe
>
>  meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb b/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb
> index 6b57cb54c..b9b1dcf0d 100644
> --- a/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb
> +++ b/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb
> @@ -39,6 +39,7 @@ EXTRA_OECMAKE += " \
>      -DwxUSE_LIBTIFF=sys \
>      -DwxUSE_REGEX=builtin \
>      -DwxPLATFORM_LIB_DIR=${@d.getVar('baselib').replace('lib', '')} \
> +    ${@bb.utils.contains('PACKAGECONFIG', 'gtk', '-DwxUSE_PRIVATE_FONTS=ON', '', d)} \

why not add it to the packageconfig setting itself ?

>  "
>  EXTRA_OECMAKE:append:libc-musl = " \
>      -DHAVE_LOCALE_T=OFF \
> --
> 2.17.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#97033): https://lists.openembedded.org/g/openembedded-devel/message/97033
> Mute This Topic: https://lists.openembedded.org/mt/91031050/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [oe] [meta-oe][PATCH v2] wxwidgets: enable to use private fonts
  2022-05-11 15:21 ` [oe] " Khem Raj
@ 2022-05-12  6:22   ` Kai
  2022-05-12 16:15     ` Khem Raj
  0 siblings, 1 reply; 5+ messages in thread
From: Kai @ 2022-05-12  6:22 UTC (permalink / raw)
  To: Khem Raj; +Cc: openembeded-devel

On 5/11/22 11:21 PM, Khem Raj wrote:
> On Wed, May 11, 2022 at 12:45 AM kai <kai.kang@windriver.com> wrote:
>> From: Kai Kang <kai.kang@windriver.com>
>>
>> Enable option wxUSE_PRIVATE_FONTS of wxwidgets if build with gtk. It
>> allows application to use the font from the given file even if it is
>> not globally installed on the system.
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>> v2:
>> * use upper case 'ON' to align with others in oe
>>
>>   meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb b/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb
>> index 6b57cb54c..b9b1dcf0d 100644
>> --- a/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb
>> +++ b/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb
>> @@ -39,6 +39,7 @@ EXTRA_OECMAKE += " \
>>       -DwxUSE_LIBTIFF=sys \
>>       -DwxUSE_REGEX=builtin \
>>       -DwxPLATFORM_LIB_DIR=${@d.getVar('baselib').replace('lib', '')} \
>> +    ${@bb.utils.contains('PACKAGECONFIG', 'gtk', '-DwxUSE_PRIVATE_FONTS=ON', '', d)} \
> why not add it to the packageconfig setting itself ?
It is an useful feature for wxwidgets with gui, so I want it  to be 
enabled by default. And it requires pango to make it work.

I can see gtk3 depends on pango but qtbase doesn't. So only check 'gtk' 
here.

Regards,
Kai

>
>>   "
>>   EXTRA_OECMAKE:append:libc-musl = " \
>>       -DHAVE_LOCALE_T=OFF \
>> --
>> 2.17.1
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#97033): https://lists.openembedded.org/g/openembedded-devel/message/97033
>> Mute This Topic: https://lists.openembedded.org/mt/91031050/1997914
>> Group Owner: openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>

-- 
Kai Kang
Wind River Linux



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [oe] [meta-oe][PATCH v2] wxwidgets: enable to use private fonts
  2022-05-12  6:22   ` Kai
@ 2022-05-12 16:15     ` Khem Raj
  2022-05-13  3:01       ` Kai
  0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2022-05-12 16:15 UTC (permalink / raw)
  To: Kai; +Cc: openembeded-devel

On Wed, May 11, 2022 at 11:23 PM Kai <kai.kang@windriver.com> wrote:
>
> On 5/11/22 11:21 PM, Khem Raj wrote:
> > On Wed, May 11, 2022 at 12:45 AM kai <kai.kang@windriver.com> wrote:
> >> From: Kai Kang <kai.kang@windriver.com>
> >>
> >> Enable option wxUSE_PRIVATE_FONTS of wxwidgets if build with gtk. It
> >> allows application to use the font from the given file even if it is
> >> not globally installed on the system.
> >>
> >> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> >> ---
> >> v2:
> >> * use upper case 'ON' to align with others in oe
> >>
> >>   meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb b/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb
> >> index 6b57cb54c..b9b1dcf0d 100644
> >> --- a/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb
> >> +++ b/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb
> >> @@ -39,6 +39,7 @@ EXTRA_OECMAKE += " \
> >>       -DwxUSE_LIBTIFF=sys \
> >>       -DwxUSE_REGEX=builtin \
> >>       -DwxPLATFORM_LIB_DIR=${@d.getVar('baselib').replace('lib', '')} \
> >> +    ${@bb.utils.contains('PACKAGECONFIG', 'gtk', '-DwxUSE_PRIVATE_FONTS=ON', '', d)} \
> > why not add it to the packageconfig setting itself ?
> It is an useful feature for wxwidgets with gui, so I want it  to be
> enabled by default. And it requires pango to make it work.
>
> I can see gtk3 depends on pango but qtbase doesn't. So only check 'gtk'

I meant to do something like below instead of this patch.

PACKAGECONFIG[gtk] = "-DwxBUILD_TOOLKIT=gtk3 -DwxUSE_GUI=ON
-DwxUSE_PRIVATE_FONTS=ON,,gtk+3,,,no_gui qt"

> here.
>
> Regards,
> Kai
>
> >
> >>   "
> >>   EXTRA_OECMAKE:append:libc-musl = " \
> >>       -DHAVE_LOCALE_T=OFF \
> >> --
> >> 2.17.1
> >>
> >>
> >> -=-=-=-=-=-=-=-=-=-=-=-
> >> Links: You receive all messages sent to this group.
> >> View/Reply Online (#97033): https://lists.openembedded.org/g/openembedded-devel/message/97033
> >> Mute This Topic: https://lists.openembedded.org/mt/91031050/1997914
> >> Group Owner: openembedded-devel+owner@lists.openembedded.org
> >> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> >> -=-=-=-=-=-=-=-=-=-=-=-
> >>
>
> --
> Kai Kang
> Wind River Linux
>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [oe] [meta-oe][PATCH v2] wxwidgets: enable to use private fonts
  2022-05-12 16:15     ` Khem Raj
@ 2022-05-13  3:01       ` Kai
  0 siblings, 0 replies; 5+ messages in thread
From: Kai @ 2022-05-13  3:01 UTC (permalink / raw)
  To: Khem Raj; +Cc: openembeded-devel

On 5/13/22 12:15 AM, Khem Raj wrote:
> On Wed, May 11, 2022 at 11:23 PM Kai <kai.kang@windriver.com> wrote:
>> On 5/11/22 11:21 PM, Khem Raj wrote:
>>> On Wed, May 11, 2022 at 12:45 AM kai <kai.kang@windriver.com> wrote:
>>>> From: Kai Kang <kai.kang@windriver.com>
>>>>
>>>> Enable option wxUSE_PRIVATE_FONTS of wxwidgets if build with gtk. It
>>>> allows application to use the font from the given file even if it is
>>>> not globally installed on the system.
>>>>
>>>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>>>> ---
>>>> v2:
>>>> * use upper case 'ON' to align with others in oe
>>>>
>>>>    meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb b/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb
>>>> index 6b57cb54c..b9b1dcf0d 100644
>>>> --- a/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb
>>>> +++ b/meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb
>>>> @@ -39,6 +39,7 @@ EXTRA_OECMAKE += " \
>>>>        -DwxUSE_LIBTIFF=sys \
>>>>        -DwxUSE_REGEX=builtin \
>>>>        -DwxPLATFORM_LIB_DIR=${@d.getVar('baselib').replace('lib', '')} \
>>>> +    ${@bb.utils.contains('PACKAGECONFIG', 'gtk', '-DwxUSE_PRIVATE_FONTS=ON', '', d)} \
>>> why not add it to the packageconfig setting itself ?
>> It is an useful feature for wxwidgets with gui, so I want it  to be
>> enabled by default. And it requires pango to make it work.
>>
>> I can see gtk3 depends on pango but qtbase doesn't. So only check 'gtk'
> I meant to do something like below instead of this patch.
>
> PACKAGECONFIG[gtk] = "-DwxBUILD_TOOLKIT=gtk3 -DwxUSE_GUI=ON
> -DwxUSE_PRIVATE_FONTS=ON,,gtk+3,,,no_gui qt"

OK. v3 will be sent.

Thanks,
Kai

>
>> here.
>>
>> Regards,
>> Kai
>>
>>>>    "
>>>>    EXTRA_OECMAKE:append:libc-musl = " \
>>>>        -DHAVE_LOCALE_T=OFF \
>>>> --
>>>> 2.17.1
>>>>
>>>>
>>>> -=-=-=-=-=-=-=-=-=-=-=-
>>>> Links: You receive all messages sent to this group.
>>>> View/Reply Online (#97033): https://lists.openembedded.org/g/openembedded-devel/message/97033
>>>> Mute This Topic: https://lists.openembedded.org/mt/91031050/1997914
>>>> Group Owner: openembedded-devel+owner@lists.openembedded.org
>>>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
>>>> -=-=-=-=-=-=-=-=-=-=-=-
>>>>
>> --
>> Kai Kang
>> Wind River Linux
>>

-- 
Kai Kang
Wind River Linux



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-05-13  3:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-11  7:45 [meta-oe][PATCH v2] wxwidgets: enable to use private fonts kai.kang
2022-05-11 15:21 ` [oe] " Khem Raj
2022-05-12  6:22   ` Kai
2022-05-12 16:15     ` Khem Raj
2022-05-13  3:01       ` Kai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.