From: Andre Przywara <andre.przywara@arm.com>
To: Samuel Holland <samuel@sholland.org>
Cc: u-boot@lists.denx.de, Jagan Teki <jagan@amarulasolutions.com>,
Eddie James <eajames@linux.ibm.com>, Heiko Schocher <hs@denx.de>,
Michal Simek <michal.simek@amd.com>,
Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
Philippe Reynes <philippe.reynes@softathome.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Simon Glass <sjg@chromium.org>,
T Karthik Reddy <t.karthik.reddy@xilinx.com>
Subject: Re: [PATCH] gpio: sunxi: Fix build with CONFIG_SPL_SERIAL=n
Date: Wed, 11 May 2022 09:57:51 +0100 [thread overview]
Message-ID: <20220511095751.26e80c70@donnerap.cambridge.arm.com> (raw)
In-Reply-To: <20220511000334.37989-1-samuel@sholland.org>
On Tue, 10 May 2022 19:03:34 -0500
Samuel Holland <samuel@sholland.org> wrote:
Hi,
> This driver uses simple_strtol(), so it needs SPL_STRTO. Before commit
> 88ca8e26958b6 ("disk: Add an option for partitions in SPL"), SPL_STRTO
> was always selected indirectly. Now it is not, so select it here.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
From what I can see, CONFIG_MMC is the trigger, calling
sunxi_name_to_gpio(), which is the actual user of simple_strtol() in the
SPL. For the three boards not using MMC I don't see simple_strol() being
mentioned in the objdump.
But I think this patch is a more robust solution (compared to tying it to
MMC usage), so:
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
>
> drivers/gpio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 89068c7800..b955543e97 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -347,6 +347,7 @@ config SANDBOX_GPIO_COUNT
> config SUNXI_GPIO
> bool "Allwinner GPIO driver"
> depends on ARCH_SUNXI
> + select SPL_STRTO if SPL
> help
> Support the GPIO device in Allwinner SoCs.
>
next prev parent reply other threads:[~2022-05-11 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 0:03 [PATCH] gpio: sunxi: Fix build with CONFIG_SPL_SERIAL=n Samuel Holland
2022-05-11 8:57 ` Andre Przywara [this message]
2022-06-27 0:11 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220511095751.26e80c70@donnerap.cambridge.arm.com \
--to=andre.przywara@arm.com \
--cc=eajames@linux.ibm.com \
--cc=hs@denx.de \
--cc=jagan@amarulasolutions.com \
--cc=michal.simek@amd.com \
--cc=oleksandr.suvorov@toradex.com \
--cc=philippe.reynes@softathome.com \
--cc=samuel@sholland.org \
--cc=sebastian.reichel@collabora.com \
--cc=sjg@chromium.org \
--cc=t.karthik.reddy@xilinx.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.