* [PATCH] watchdog: ts4800_wdt: Fix refcount leak in ts4800_wdt_probe
@ 2022-05-11 11:42 Miaoqian Lin
2022-05-11 13:19 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-05-11 11:42 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Damien Riegel, Rob Herring,
linux-watchdog, linux-kernel
Cc: linmq006
of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() in some error paths.
Fixes: bf9006399939 ("watchdog: ts4800: add driver for TS-4800 watchdog")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/watchdog/ts4800_wdt.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/watchdog/ts4800_wdt.c b/drivers/watchdog/ts4800_wdt.c
index c137ad2bd5c3..0ea554c7cda5 100644
--- a/drivers/watchdog/ts4800_wdt.c
+++ b/drivers/watchdog/ts4800_wdt.c
@@ -125,13 +125,16 @@ static int ts4800_wdt_probe(struct platform_device *pdev)
ret = of_property_read_u32_index(np, "syscon", 1, ®);
if (ret < 0) {
dev_err(dev, "no offset in syscon\n");
+ of_node_put(syscon_np);
return ret;
}
/* allocate memory for watchdog struct */
wdt = devm_kzalloc(dev, sizeof(*wdt), GFP_KERNEL);
- if (!wdt)
+ if (!wdt) {
+ of_node_put(syscon_np);
return -ENOMEM;
+ }
/* set regmap and offset to know where to write */
wdt->feed_offset = reg;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: ts4800_wdt: Fix refcount leak in ts4800_wdt_probe
2022-05-11 11:42 [PATCH] watchdog: ts4800_wdt: Fix refcount leak in ts4800_wdt_probe Miaoqian Lin
@ 2022-05-11 13:19 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2022-05-11 13:19 UTC (permalink / raw)
To: Miaoqian Lin, Wim Van Sebroeck, Damien Riegel, Rob Herring,
linux-watchdog, linux-kernel
On 5/11/22 04:42, Miaoqian Lin wrote:
> of_parse_phandle() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() in some error paths.
>
> Fixes: bf9006399939 ("watchdog: ts4800: add driver for TS-4800 watchdog")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/ts4800_wdt.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/ts4800_wdt.c b/drivers/watchdog/ts4800_wdt.c
> index c137ad2bd5c3..0ea554c7cda5 100644
> --- a/drivers/watchdog/ts4800_wdt.c
> +++ b/drivers/watchdog/ts4800_wdt.c
> @@ -125,13 +125,16 @@ static int ts4800_wdt_probe(struct platform_device *pdev)
> ret = of_property_read_u32_index(np, "syscon", 1, ®);
> if (ret < 0) {
> dev_err(dev, "no offset in syscon\n");
> + of_node_put(syscon_np);
> return ret;
> }
>
> /* allocate memory for watchdog struct */
> wdt = devm_kzalloc(dev, sizeof(*wdt), GFP_KERNEL);
> - if (!wdt)
> + if (!wdt) {
> + of_node_put(syscon_np);
> return -ENOMEM;
> + }
>
> /* set regmap and offset to know where to write */
> wdt->feed_offset = reg;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-11 13:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-11 11:42 [PATCH] watchdog: ts4800_wdt: Fix refcount leak in ts4800_wdt_probe Miaoqian Lin
2022-05-11 13:19 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.