[PATCH bpf-next] Enable CONFIG_FPROBE for self tests

[PATCH bpf-next] Enable CONFIG_FPROBE for self tests

[Daniel Müller]

Some of the BPF selftests are failing when running with a rather bare
bones configuration based on tools/testing/selftests/bpf/config.
Specifically, we see a bunch of failures due to errno 95:

  > test_attach_api:PASS:fentry_raw_skel_load 0 nsec
  > libbpf: prog 'test_kprobe_manual': failed to attach: Operation not supported
  > test_attach_api:FAIL:bpf_program__attach_kprobe_multi_opts unexpected error: -95
  > 79 /6     kprobe_multi_test/attach_api_syms:FAIL

The cause of these is that CONFIG_FPROBE is missing. With this change we
add this configuration value to the BPF selftests config.

Signed-off-by: Daniel Müller <deso@posteo.net>
---
 tools/testing/selftests/bpf/config | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config
index 763db6..08c6e5a 100644
--- a/tools/testing/selftests/bpf/config
+++ b/tools/testing/selftests/bpf/config
@@ -53,3 +53,4 @@ CONFIG_NF_DEFRAG_IPV4=y
 CONFIG_NF_DEFRAG_IPV6=y
 CONFIG_NF_CONNTRACK=y
 CONFIG_USERFAULTFD=y
+CONFIG_FPROBE=y
-- 
2.30.2

Re: [PATCH bpf-next] Enable CONFIG_FPROBE for self tests

[David Vernet]

On Wed, May 11, 2022 at 05:22:49PM +0000, Daniel Müller wrote:
> Some of the BPF selftests are failing when running with a rather bare
> bones configuration based on tools/testing/selftests/bpf/config.
> Specifically, we see a bunch of failures due to errno 95:
> 
>   > test_attach_api:PASS:fentry_raw_skel_load 0 nsec
>   > libbpf: prog 'test_kprobe_manual': failed to attach: Operation not supported
>   > test_attach_api:FAIL:bpf_program__attach_kprobe_multi_opts unexpected error: -95
>   > 79 /6     kprobe_multi_test/attach_api_syms:FAIL
> 
> The cause of these is that CONFIG_FPROBE is missing. With this change we
> add this configuration value to the BPF selftests config.
> 
> Signed-off-by: Daniel Müller <deso@posteo.net>
> ---
>  tools/testing/selftests/bpf/config | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config
> index 763db6..08c6e5a 100644
> --- a/tools/testing/selftests/bpf/config
> +++ b/tools/testing/selftests/bpf/config
> @@ -53,3 +53,4 @@ CONFIG_NF_DEFRAG_IPV4=y
>  CONFIG_NF_DEFRAG_IPV6=y
>  CONFIG_NF_CONNTRACK=y
>  CONFIG_USERFAULTFD=y
> +CONFIG_FPROBE=y
> -- 
> 2.30.2
> 

Looks good, thanks Daniel.

Acked-by: David Vernet <void@manifault.com>

Re: [PATCH bpf-next] Enable CONFIG_FPROBE for self tests

[Alexei Starovoitov]

On Wed, May 11, 2022 at 10:23 AM Daniel Müller <deso@posteo.net> wrote:
>
> Some of the BPF selftests are failing when running with a rather bare
> bones configuration based on tools/testing/selftests/bpf/config.
> Specifically, we see a bunch of failures due to errno 95:
>
>   > test_attach_api:PASS:fentry_raw_skel_load 0 nsec
>   > libbpf: prog 'test_kprobe_manual': failed to attach: Operation not supported
>   > test_attach_api:FAIL:bpf_program__attach_kprobe_multi_opts unexpected error: -95
>   > 79 /6     kprobe_multi_test/attach_api_syms:FAIL
>
> The cause of these is that CONFIG_FPROBE is missing. With this change we
> add this configuration value to the BPF selftests config.
>
> Signed-off-by: Daniel Müller <deso@posteo.net>

Please use 'selftests/bpf: ' prefix in the patch subj
in the future.
I've fixed it up while applying this time.

Re: [PATCH bpf-next] Enable CONFIG_FPROBE for self tests

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Wed, 11 May 2022 17:22:49 +0000 you wrote:
> Some of the BPF selftests are failing when running with a rather bare
> bones configuration based on tools/testing/selftests/bpf/config.
> Specifically, we see a bunch of failures due to errno 95:
> 
>   > test_attach_api:PASS:fentry_raw_skel_load 0 nsec
>   > libbpf: prog 'test_kprobe_manual': failed to attach: Operation not supported
>   > test_attach_api:FAIL:bpf_program__attach_kprobe_multi_opts unexpected error: -95
>   > 79 /6     kprobe_multi_test/attach_api_syms:FAIL
> 
> [...]

Here is the summary with links:
  - [bpf-next] Enable CONFIG_FPROBE for self tests
    https://git.kernel.org/bpf/bpf-next/c/998e1869de1b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html