All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] kunit: tool: update riscv QEMU config with new serial dependency
@ 2022-05-12  0:30 Brendan Higgins
  2022-05-12 13:24 ` David Gow
  0 siblings, 1 reply; 2+ messages in thread
From: Brendan Higgins @ 2022-05-12  0:30 UTC (permalink / raw)
  To: shuah, davidgow, dlatypov
  Cc: linux-kselftest, kunit-dev, linux-kernel, Brendan Higgins

The config for the serial console for riscv,
CONFIG_SERIAL_EARLYCON_RISCV_SBI, added a dependency,
CONFIG_RISCV_SBI_V01, at some point, so add that in to the base arch
config.

Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
 tools/testing/kunit/qemu_configs/riscv.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/kunit/qemu_configs/riscv.py b/tools/testing/kunit/qemu_configs/riscv.py
index 9e528087cd7c..a7a4ab8093b1 100644
--- a/tools/testing/kunit/qemu_configs/riscv.py
+++ b/tools/testing/kunit/qemu_configs/riscv.py
@@ -21,6 +21,7 @@ CONFIG_SOC_VIRT=y
 CONFIG_SERIAL_8250=y
 CONFIG_SERIAL_8250_CONSOLE=y
 CONFIG_SERIAL_OF_PLATFORM=y
+CONFIG_RISCV_SBI_V01=y
 CONFIG_SERIAL_EARLYCON_RISCV_SBI=y''',
 			   qemu_arch='riscv64',
 			   kernel_path='arch/riscv/boot/Image',

base-commit: feb9c5e19e913b53cb536a7aa7c9f20107bb51ec
-- 
2.36.0.550.gb090851708-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] kunit: tool: update riscv QEMU config with new serial dependency
  2022-05-12  0:30 [PATCH v1] kunit: tool: update riscv QEMU config with new serial dependency Brendan Higgins
@ 2022-05-12 13:24 ` David Gow
  0 siblings, 0 replies; 2+ messages in thread
From: David Gow @ 2022-05-12 13:24 UTC (permalink / raw)
  To: Brendan Higgins
  Cc: Shuah Khan, Daniel Latypov, open list:KERNEL SELFTEST FRAMEWORK,
	KUnit Development, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 1688 bytes --]

On Thu, May 12, 2022 at 8:30 AM 'Brendan Higgins' via KUnit
Development <kunit-dev@googlegroups.com> wrote:
>
> The config for the serial console for riscv,
> CONFIG_SERIAL_EARLYCON_RISCV_SBI, added a dependency,
> CONFIG_RISCV_SBI_V01, at some point, so add that in to the base arch
> config.
>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> ---

Thanks! I actually hit this issue looking at rust stuff the other day,
but didn't have a chance to look into it properly.

This looks good, and works for me.

Reviewed-by: David Gow <davidgow@google.com>

-- David


>  tools/testing/kunit/qemu_configs/riscv.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/kunit/qemu_configs/riscv.py b/tools/testing/kunit/qemu_configs/riscv.py
> index 9e528087cd7c..a7a4ab8093b1 100644
> --- a/tools/testing/kunit/qemu_configs/riscv.py
> +++ b/tools/testing/kunit/qemu_configs/riscv.py
> @@ -21,6 +21,7 @@ CONFIG_SOC_VIRT=y
>  CONFIG_SERIAL_8250=y
>  CONFIG_SERIAL_8250_CONSOLE=y
>  CONFIG_SERIAL_OF_PLATFORM=y
> +CONFIG_RISCV_SBI_V01=y
>  CONFIG_SERIAL_EARLYCON_RISCV_SBI=y''',
>                            qemu_arch='riscv64',
>                            kernel_path='arch/riscv/boot/Image',
>
> base-commit: feb9c5e19e913b53cb536a7aa7c9f20107bb51ec
> --
> 2.36.0.550.gb090851708-goog
>
> --
> You received this message because you are subscribed to the Google Groups "KUnit Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kunit-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kunit-dev/20220512003026.3413497-1-brendanhiggins%40google.com.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4003 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-12 13:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12  0:30 [PATCH v1] kunit: tool: update riscv QEMU config with new serial dependency Brendan Higgins
2022-05-12 13:24 ` David Gow

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.