From: kernel test robot <lkp@intel.com>
To: Krishna Kurapati <quic_kriskura@quicinc.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Vinod Koul <vkoul@kernel.org>
Cc: kbuild-all@lists.01.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com,
quic_vpulyala@quicinc.com,
Krishna Kurapati <quic_kriskura@quicinc.com>
Subject: Re: [v4 2/3] phy: qcom-snps: Add support for overriding phy tuning parameters
Date: Thu, 12 May 2022 05:04:19 +0800 [thread overview]
Message-ID: <202205120425.gScyEI7N-lkp@intel.com> (raw)
In-Reply-To: <1652282793-5580-3-git-send-email-quic_kriskura@quicinc.com>
Hi Krishna,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on krzk/for-next linus/master v5.18-rc6 next-20220511]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Krishna-Kurapati/Add-QCOM-SNPS-PHY-overriding-params-support/20220511-232858
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220512/202205120425.gScyEI7N-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/48c46f24873c92d3e16904af9e654962d0b923f1
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Krishna-Kurapati/Add-QCOM-SNPS-PHY-overriding-params-support/20220511-232858
git checkout 48c46f24873c92d3e16904af9e654962d0b923f1
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/phy/qualcomm/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c: In function 'qcom_snps_hsphy_read_override_param_seq':
>> drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c:541:42: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
541 | struct override_param_map *cfg = of_device_get_match_data(dev);
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/const +541 drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c
534
535 static void qcom_snps_hsphy_read_override_param_seq(struct device *dev)
536 {
537 struct device_node *node = dev->of_node;
538 s32 val;
539 int ret, i;
540 struct qcom_snps_hsphy *hsphy;
> 541 struct override_param_map *cfg = of_device_get_match_data(dev);
542
543 hsphy = dev_get_drvdata(dev);
544
545 for (i = 0; i < ARRAY_SIZE(phy_seq_props); i++) {
546 ret = of_property_read_s32(node, phy_seq_props[i], &val);
547 if (!ret) {
548 dev_dbg(&hsphy->phy->dev, "Read param: %s val: %d\n",
549 phy_seq_props[i], val);
550 qcom_snps_hsphy_override_param_update_val(cfg[i], val,
551 &hsphy->update_seq_cfg[i]);
552 }
553 }
554 }
555
--
0-DAY CI Kernel Test Service
https://01.org/lkp
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Krishna Kurapati <quic_kriskura@quicinc.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Vinod Koul <vkoul@kernel.org>
Cc: kbuild-all@lists.01.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com,
quic_vpulyala@quicinc.com,
Krishna Kurapati <quic_kriskura@quicinc.com>
Subject: Re: [v4 2/3] phy: qcom-snps: Add support for overriding phy tuning parameters
Date: Thu, 12 May 2022 05:04:19 +0800 [thread overview]
Message-ID: <202205120425.gScyEI7N-lkp@intel.com> (raw)
In-Reply-To: <1652282793-5580-3-git-send-email-quic_kriskura@quicinc.com>
Hi Krishna,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on krzk/for-next linus/master v5.18-rc6 next-20220511]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Krishna-Kurapati/Add-QCOM-SNPS-PHY-overriding-params-support/20220511-232858
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220512/202205120425.gScyEI7N-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/48c46f24873c92d3e16904af9e654962d0b923f1
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Krishna-Kurapati/Add-QCOM-SNPS-PHY-overriding-params-support/20220511-232858
git checkout 48c46f24873c92d3e16904af9e654962d0b923f1
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/phy/qualcomm/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c: In function 'qcom_snps_hsphy_read_override_param_seq':
>> drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c:541:42: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
541 | struct override_param_map *cfg = of_device_get_match_data(dev);
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/const +541 drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c
534
535 static void qcom_snps_hsphy_read_override_param_seq(struct device *dev)
536 {
537 struct device_node *node = dev->of_node;
538 s32 val;
539 int ret, i;
540 struct qcom_snps_hsphy *hsphy;
> 541 struct override_param_map *cfg = of_device_get_match_data(dev);
542
543 hsphy = dev_get_drvdata(dev);
544
545 for (i = 0; i < ARRAY_SIZE(phy_seq_props); i++) {
546 ret = of_property_read_s32(node, phy_seq_props[i], &val);
547 if (!ret) {
548 dev_dbg(&hsphy->phy->dev, "Read param: %s val: %d\n",
549 phy_seq_props[i], val);
550 qcom_snps_hsphy_override_param_update_val(cfg[i], val,
551 &hsphy->update_seq_cfg[i]);
552 }
553 }
554 }
555
--
0-DAY CI Kernel Test Service
https://01.org/lkp
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-05-11 21:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 15:26 [v4 0/3] Add QCOM SNPS PHY overriding params support Krishna Kurapati
2022-05-11 15:26 ` Krishna Kurapati
2022-05-11 15:26 ` [v4 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params bindings Krishna Kurapati
2022-05-11 15:26 ` [v4 1/3] dt-bindings: phy: qcom, usb-snps-femto-v2: " Krishna Kurapati
2022-05-11 18:19 ` [v4 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: " Krzysztof Kozlowski
2022-05-11 18:19 ` Krzysztof Kozlowski
2022-05-12 5:57 ` Krishna Kurapati PSSNV
2022-05-12 5:57 ` Krishna Kurapati PSSNV
2022-05-12 10:30 ` Krzysztof Kozlowski
2022-05-12 10:30 ` Krzysztof Kozlowski
2022-05-14 6:24 ` Krishna Kurapati PSSNV
2022-05-14 6:24 ` Krishna Kurapati PSSNV
2022-05-14 19:41 ` Krzysztof Kozlowski
2022-05-14 19:41 ` Krzysztof Kozlowski
2022-05-13 7:33 ` Krishna Kurapati PSSNV
2022-05-13 7:33 ` Krishna Kurapati PSSNV
2022-05-13 10:32 ` Krzysztof Kozlowski
2022-05-13 10:32 ` Krzysztof Kozlowski
2022-05-13 12:20 ` Krzysztof Kozlowski
2022-05-13 12:20 ` Krzysztof Kozlowski
2022-05-13 18:32 ` Krishna Kurapati PSSNV
2022-05-13 18:32 ` Krishna Kurapati PSSNV
2022-05-11 15:26 ` [v4 2/3] phy: qcom-snps: Add support for overriding phy tuning parameters Krishna Kurapati
2022-05-11 15:26 ` Krishna Kurapati
2022-05-11 21:04 ` kernel test robot [this message]
2022-05-11 21:04 ` kernel test robot
2022-05-12 1:29 ` kernel test robot
2022-05-12 1:29 ` kernel test robot
2022-05-11 15:26 ` [v4 3/3] arm64: dts: qcom: sc7280: Update SNPS Phy params for SC7280 IDP device Krishna Kurapati
2022-05-11 15:26 ` Krishna Kurapati
2022-05-11 18:16 ` [v4 0/3] Add QCOM SNPS PHY overriding params support Krzysztof Kozlowski
2022-05-11 18:16 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205120425.gScyEI7N-lkp@intel.com \
--to=lkp@intel.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_kriskura@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_vpulyala@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.