* [PATCH] leds: netxbig: Fix refcount leak in netxbig_leds_get_of_pdata
@ 2022-05-12 5:02 Miaoqian Lin
2022-05-12 6:53 ` Pavel Machek
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-05-12 5:02 UTC (permalink / raw)
To: Pavel Machek, Linus Walleij, linux-leds, linux-kernel; +Cc: linmq006
of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not needed anymore.
When of_find_device_by_node() fails, of_node_put() is missing.
Fixes: 9af512e81964 ("leds: netxbig: Convert to use GPIO descriptors")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/leds/leds-netxbig.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c
index 77213b79f84d..ceb046500469 100644
--- a/drivers/leds/leds-netxbig.c
+++ b/drivers/leds/leds-netxbig.c
@@ -441,6 +441,7 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
gpio_ext_pdev = of_find_device_by_node(gpio_ext_np);
if (!gpio_ext_pdev) {
dev_err(dev, "Failed to find platform device for gpio-ext\n");
+ of_node_put(gpio_ext_np);
return -ENODEV;
}
gpio_ext_dev = &gpio_ext_pdev->dev;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: netxbig: Fix refcount leak in netxbig_leds_get_of_pdata
2022-05-12 5:02 [PATCH] leds: netxbig: Fix refcount leak in netxbig_leds_get_of_pdata Miaoqian Lin
@ 2022-05-12 6:53 ` Pavel Machek
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2022-05-12 6:53 UTC (permalink / raw)
To: Miaoqian Lin; +Cc: Linus Walleij, linux-leds, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
Hi!
> of_parse_phandle() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not needed anymore.
> When of_find_device_by_node() fails, of_node_put() is missing.
Can you take a look at the code and simplify it? AFAICT the node_put
should go right after
gpio_ext_pdev = of_find_device_by_node(gpio_ext_np);
. Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-12 6:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12 5:02 [PATCH] leds: netxbig: Fix refcount leak in netxbig_leds_get_of_pdata Miaoqian Lin
2022-05-12 6:53 ` Pavel Machek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.