* [PATCH -next] fs: Fix jbd2_journal_try_to_free_buffers() kernel-doc comment
@ 2022-05-12 7:54 Yang Li
2022-05-12 17:37 ` Jan Kara
2022-06-16 14:53 ` Theodore Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Yang Li @ 2022-05-12 7:54 UTC (permalink / raw)
To: tytso; +Cc: jack, linux-ext4, linux-kernel, Yang Li, Abaci Robot
Add the description of @folio and remove @page in function kernel-doc
comment to remove warnings found by running scripts/kernel-doc, which
is caused by using 'make W=1'.
fs/jbd2/transaction.c:2149: warning: Function parameter or member
'folio' not described in 'jbd2_journal_try_to_free_buffers'
fs/jbd2/transaction.c:2149: warning: Excess function parameter 'page'
description in 'jbd2_journal_try_to_free_buffers'
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
fs/jbd2/transaction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index e49bb0938376..e9c308ae475f 100644
--- a/fs/jbd2/transaction.c
+++ b/fs/jbd2/transaction.c
@@ -2114,7 +2114,7 @@ __journal_try_to_free_buffer(journal_t *journal, struct buffer_head *bh)
/**
* jbd2_journal_try_to_free_buffers() - try to free page buffers.
* @journal: journal for operation
- * @page: to try and free
+ * @folio: Folio to detach data from.
*
* For all the buffers on this page,
* if they are fully written out ordered data, move them onto BUF_CLEAN
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fs: Fix jbd2_journal_try_to_free_buffers() kernel-doc comment
2022-05-12 7:54 [PATCH -next] fs: Fix jbd2_journal_try_to_free_buffers() kernel-doc comment Yang Li
@ 2022-05-12 17:37 ` Jan Kara
2022-06-16 14:53 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2022-05-12 17:37 UTC (permalink / raw)
To: Yang Li; +Cc: tytso, jack, linux-ext4, linux-kernel, Abaci Robot
On Thu 12-05-22 15:54:32, Yang Li wrote:
> Add the description of @folio and remove @page in function kernel-doc
> comment to remove warnings found by running scripts/kernel-doc, which
> is caused by using 'make W=1'.
>
> fs/jbd2/transaction.c:2149: warning: Function parameter or member
> 'folio' not described in 'jbd2_journal_try_to_free_buffers'
> fs/jbd2/transaction.c:2149: warning: Excess function parameter 'page'
> description in 'jbd2_journal_try_to_free_buffers'
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
OK, but isn't this on linux-next only? Because I don't see the 'folio'
parameter in current Linus' tree yet.
Honza
> ---
> fs/jbd2/transaction.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index e49bb0938376..e9c308ae475f 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -2114,7 +2114,7 @@ __journal_try_to_free_buffer(journal_t *journal, struct buffer_head *bh)
> /**
> * jbd2_journal_try_to_free_buffers() - try to free page buffers.
> * @journal: journal for operation
> - * @page: to try and free
> + * @folio: Folio to detach data from.
> *
> * For all the buffers on this page,
> * if they are fully written out ordered data, move them onto BUF_CLEAN
> --
> 2.20.1.7.g153144c
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fs: Fix jbd2_journal_try_to_free_buffers() kernel-doc comment
2022-05-12 7:54 [PATCH -next] fs: Fix jbd2_journal_try_to_free_buffers() kernel-doc comment Yang Li
2022-05-12 17:37 ` Jan Kara
@ 2022-06-16 14:53 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2022-06-16 14:53 UTC (permalink / raw)
To: Yang Li; +Cc: Theodore Ts'o, linux-ext4, Abaci Robot, linux-kernel, jack
On Thu, 12 May 2022 15:54:32 +0800, Yang Li wrote:
> Add the description of @folio and remove @page in function kernel-doc
> comment to remove warnings found by running scripts/kernel-doc, which
> is caused by using 'make W=1'.
>
> fs/jbd2/transaction.c:2149: warning: Function parameter or member
> 'folio' not described in 'jbd2_journal_try_to_free_buffers'
> fs/jbd2/transaction.c:2149: warning: Excess function parameter 'page'
> description in 'jbd2_journal_try_to_free_buffers'
>
> [...]
Applied, thanks!
[1/1] fs: Fix jbd2_journal_try_to_free_buffers() kernel-doc comment
commit: 4f5bf12732fd78e225fc62b7c5c84d9032f8048a
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-16 14:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12 7:54 [PATCH -next] fs: Fix jbd2_journal_try_to_free_buffers() kernel-doc comment Yang Li
2022-05-12 17:37 ` Jan Kara
2022-06-16 14:53 ` Theodore Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.