From: Jakub Kicinski <kuba@kernel.org>
To: "Íñigo Huguet" <ihuguet@redhat.com>
Cc: ecree.xilinx@gmail.com, habetsm.xilinx@gmail.com,
amaftei@solarflare.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
Tianhao Zhao <tizhao@redhat.com>
Subject: Re: [PATCH net 1/2] sfc: fix wrong tx channel offset with efx_separate_tx_channels
Date: Thu, 12 May 2022 10:01:06 -0700 [thread overview]
Message-ID: <20220512100106.15bb15d6@kernel.org> (raw)
In-Reply-To: <20220511125941.55812-2-ihuguet@redhat.com>
On Wed, 11 May 2022 14:59:40 +0200 Íñigo Huguet wrote:
> if (efx_separate_tx_channels) {
> - efx->n_tx_channels =
> - min(max(n_channels / 2, 1U),
> - efx->max_tx_channels);
> - efx->tx_channel_offset =
> - n_channels - efx->n_tx_channels;
> - efx->n_rx_channels =
> - max(n_channels -
> - efx->n_tx_channels, 1U);
> + efx->n_tx_channels = min(max(n_channels / 2, 1U), efx->max_tx_channels);
> + efx->tx_channel_offset = n_channels - efx->n_tx_channels;
> + efx->n_rx_channels = max(n_channels - efx->n_tx_channels, 1U);
No whitespace cleanups in fixes, please.
Besides, I still prefer to stay under 80 chars.
next prev parent reply other threads:[~2022-05-12 17:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 12:59 [PATCH net 0/2] sfc: fix some efx_separate_tx_channels errors Íñigo Huguet
2022-05-11 12:59 ` [PATCH net 1/2] sfc: fix wrong tx channel offset with efx_separate_tx_channels Íñigo Huguet
2022-05-12 17:01 ` Jakub Kicinski [this message]
2022-05-11 12:59 ` [PATCH net 2/2] sfc: do not initialize non existing queues " Íñigo Huguet
2022-05-13 11:07 ` Martin Habets
2022-05-13 12:37 ` Martin Habets
2022-05-24 15:36 ` Íñigo Huguet
2022-05-27 6:14 ` Martin Habets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512100106.15bb15d6@kernel.org \
--to=kuba@kernel.org \
--cc=amaftei@solarflare.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=ihuguet@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tizhao@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.