All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: "zhangfei.gao@foxmail.com" <zhangfei.gao@foxmail.com>
Cc: Zhangfei Gao <zhangfei.gao@linaro.org>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	kvm@vger.kernel.org, Will Deacon <will@kernel.org>,
	Cornelia Huck <cohuck@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Vivek Kumar Gautam <Vivek.Gautam@arm.com>,
	iommu@lists.linux-foundation.org,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] vfio: Remove VFIO_TYPE1_NESTING_IOMMU
Date: Thu, 12 May 2022 08:59:06 -0300	[thread overview]
Message-ID: <20220512115906.GX49344@nvidia.com> (raw)
In-Reply-To: <tencent_64CD1D42838611CFDB6E6A224DF469C10D08@qq.com>

On Thu, May 12, 2022 at 07:57:26PM +0800, zhangfei.gao@foxmail.com wrote:
> 
> 
> On 2022/5/12 下午7:32, Jason Gunthorpe via iommu wrote:
> > On Thu, May 12, 2022 at 03:07:09PM +0800, Zhangfei Gao wrote:
> > > > > I can't help feeling a little wary about removing this until IOMMUFD
> > > > > can actually offer a functional replacement - is it in the way of
> > > > > anything upcoming?
> > > >   From an upstream perspective if someone has a patched kernel to
> > > > complete the feature, then they can patch this part in as well, we
> > > > should not carry dead code like this in the kernel and in the uapi.
> > > > 
> > > > It is not directly in the way, but this needs to get done at some
> > > > point, I'd rather just get it out of the way.
> > > We are using this interface for nested mode.
> > How are you using it? It doesn't do anything. Do you have out of tree
> > patches as well?
> 
> Yes, there are some patches out of tree, since they are pending for almost
> one year.
> 
> By the way, I am trying to test nesting mode based on iommufd, still
> requires iommu_enable_nesting,
> which is removed in this patch as well.

This is temporary.

> So can we wait for alternative patch then remove them?

Do you see a problem with patching this along with all the other
patches you need?

Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe via iommu <iommu@lists.linux-foundation.org>
To: "zhangfei.gao@foxmail.com" <zhangfei.gao@foxmail.com>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
	kvm@vger.kernel.org, Robin Murphy <robin.murphy@arm.com>,
	Cornelia Huck <cohuck@redhat.com>,
	iommu@lists.linux-foundation.org,
	Vivek Kumar Gautam <Vivek.Gautam@arm.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Zhangfei Gao <zhangfei.gao@linaro.org>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] vfio: Remove VFIO_TYPE1_NESTING_IOMMU
Date: Thu, 12 May 2022 08:59:06 -0300	[thread overview]
Message-ID: <20220512115906.GX49344@nvidia.com> (raw)
In-Reply-To: <tencent_64CD1D42838611CFDB6E6A224DF469C10D08@qq.com>

On Thu, May 12, 2022 at 07:57:26PM +0800, zhangfei.gao@foxmail.com wrote:
> 
> 
> On 2022/5/12 下午7:32, Jason Gunthorpe via iommu wrote:
> > On Thu, May 12, 2022 at 03:07:09PM +0800, Zhangfei Gao wrote:
> > > > > I can't help feeling a little wary about removing this until IOMMUFD
> > > > > can actually offer a functional replacement - is it in the way of
> > > > > anything upcoming?
> > > >   From an upstream perspective if someone has a patched kernel to
> > > > complete the feature, then they can patch this part in as well, we
> > > > should not carry dead code like this in the kernel and in the uapi.
> > > > 
> > > > It is not directly in the way, but this needs to get done at some
> > > > point, I'd rather just get it out of the way.
> > > We are using this interface for nested mode.
> > How are you using it? It doesn't do anything. Do you have out of tree
> > patches as well?
> 
> Yes, there are some patches out of tree, since they are pending for almost
> one year.
> 
> By the way, I am trying to test nesting mode based on iommufd, still
> requires iommu_enable_nesting,
> which is removed in this patch as well.

This is temporary.

> So can we wait for alternative patch then remove them?

Do you see a problem with patching this along with all the other
patches you need?

Jason
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: "zhangfei.gao@foxmail.com" <zhangfei.gao@foxmail.com>
Cc: Zhangfei Gao <zhangfei.gao@linaro.org>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	kvm@vger.kernel.org, Will Deacon <will@kernel.org>,
	Cornelia Huck <cohuck@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Vivek Kumar Gautam <Vivek.Gautam@arm.com>,
	iommu@lists.linux-foundation.org,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] vfio: Remove VFIO_TYPE1_NESTING_IOMMU
Date: Thu, 12 May 2022 08:59:06 -0300	[thread overview]
Message-ID: <20220512115906.GX49344@nvidia.com> (raw)
In-Reply-To: <tencent_64CD1D42838611CFDB6E6A224DF469C10D08@qq.com>

On Thu, May 12, 2022 at 07:57:26PM +0800, zhangfei.gao@foxmail.com wrote:
> 
> 
> On 2022/5/12 下午7:32, Jason Gunthorpe via iommu wrote:
> > On Thu, May 12, 2022 at 03:07:09PM +0800, Zhangfei Gao wrote:
> > > > > I can't help feeling a little wary about removing this until IOMMUFD
> > > > > can actually offer a functional replacement - is it in the way of
> > > > > anything upcoming?
> > > >   From an upstream perspective if someone has a patched kernel to
> > > > complete the feature, then they can patch this part in as well, we
> > > > should not carry dead code like this in the kernel and in the uapi.
> > > > 
> > > > It is not directly in the way, but this needs to get done at some
> > > > point, I'd rather just get it out of the way.
> > > We are using this interface for nested mode.
> > How are you using it? It doesn't do anything. Do you have out of tree
> > patches as well?
> 
> Yes, there are some patches out of tree, since they are pending for almost
> one year.
> 
> By the way, I am trying to test nesting mode based on iommufd, still
> requires iommu_enable_nesting,
> which is removed in this patch as well.

This is temporary.

> So can we wait for alternative patch then remove them?

Do you see a problem with patching this along with all the other
patches you need?

Jason

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-12 11:59 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10 16:55 [PATCH] vfio: Remove VFIO_TYPE1_NESTING_IOMMU Jason Gunthorpe
2022-05-10 16:55 ` Jason Gunthorpe
2022-05-10 16:55 ` Jason Gunthorpe via iommu
2022-05-10 17:52 ` Robin Murphy
2022-05-10 17:52   ` Robin Murphy
2022-05-10 17:52   ` Robin Murphy
2022-05-10 18:13   ` Jason Gunthorpe via iommu
2022-05-10 18:13     ` Jason Gunthorpe
2022-05-10 18:13     ` Jason Gunthorpe
2022-05-12  7:07     ` Zhangfei Gao
2022-05-12  7:07       ` Zhangfei Gao
2022-05-12  7:07       ` Zhangfei Gao
2022-05-12 11:32       ` Jason Gunthorpe
2022-05-12 11:32         ` Jason Gunthorpe
2022-05-12 11:32         ` Jason Gunthorpe via iommu
2022-05-12 11:57         ` zhangfei.gao
2022-05-12 11:57           ` zhangfei.gao
2022-05-12 11:57           ` zhangfei.gao
2022-05-12 11:59           ` Jason Gunthorpe [this message]
2022-05-12 11:59             ` Jason Gunthorpe
2022-05-12 11:59             ` Jason Gunthorpe via iommu
2022-05-12 12:07             ` zhangfei.gao
2022-05-12 12:07               ` zhangfei.gao
2022-05-12 12:07               ` zhangfei.gao
2022-05-12 17:27     ` Eric Auger
2022-05-12 17:27       ` Eric Auger
2022-05-12 17:27       ` Eric Auger
2022-05-10 18:31 ` Nicolin Chen
2022-05-10 18:31   ` Nicolin Chen
2022-05-10 18:31   ` Nicolin Chen via iommu
2022-05-12  5:04 ` Tian, Kevin
2022-05-12  5:04   ` Tian, Kevin
2022-05-12  5:04   ` Tian, Kevin
2022-05-16  6:39 ` Christoph Hellwig
2022-05-16  6:39   ` Christoph Hellwig
2022-05-16  6:39   ` Christoph Hellwig
2022-05-17 20:26 ` Alex Williamson
2022-05-17 20:26   ` Alex Williamson
2022-05-17 20:26   ` Alex Williamson
2022-05-20  7:38   ` Joerg Roedel
2022-05-20  7:38     ` Joerg Roedel
2022-05-20  7:38     ` Joerg Roedel
2022-05-20 11:02 ` Robin Murphy
2022-05-20 11:02   ` Robin Murphy
2022-05-20 11:02   ` Robin Murphy
2022-05-20 12:00   ` Will Deacon
2022-05-20 12:00     ` Will Deacon
2022-05-20 12:00     ` Will Deacon
2022-05-20 12:28     ` Jason Gunthorpe
2022-05-20 12:28       ` Jason Gunthorpe
2022-05-20 12:28       ` Jason Gunthorpe via iommu
2022-05-20 12:18   ` Jason Gunthorpe
2022-05-20 12:18     ` Jason Gunthorpe
2022-05-20 12:18     ` Jason Gunthorpe via iommu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220512115906.GX49344@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=Vivek.Gautam@arm.com \
    --cc=alex.williamson@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jean-philippe@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    --cc=zhangfei.gao@foxmail.com \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.