* [PATCH -next] net: hinic: add missing destroy_workqueue in hinic_pf_to_mgmt_init
@ 2022-05-12 8:41 Zheng Bin
2022-05-12 23:59 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Bin @ 2022-05-12 8:41 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, netdev, linux-kernel; +Cc: zhengbin13, gaochao49
hinic_pf_to_mgmt_init misses destroy_workqueue in error path,
this patch fixes that.
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c
index ebc77771f5da..4aa1f433ed24 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c
@@ -643,6 +643,7 @@ int hinic_pf_to_mgmt_init(struct hinic_pf_to_mgmt *pf_to_mgmt,
err = alloc_msg_buf(pf_to_mgmt);
if (err) {
dev_err(&pdev->dev, "Failed to allocate msg buffers\n");
+ destroy_workqueue(pf_to_mgmt->workq);
hinic_health_reporters_destroy(hwdev->devlink_dev);
return err;
}
@@ -650,6 +651,7 @@ int hinic_pf_to_mgmt_init(struct hinic_pf_to_mgmt *pf_to_mgmt,
err = hinic_api_cmd_init(pf_to_mgmt->cmd_chain, hwif);
if (err) {
dev_err(&pdev->dev, "Failed to initialize cmd chains\n");
+ destroy_workqueue(pf_to_mgmt->workq);
hinic_health_reporters_destroy(hwdev->devlink_dev);
return err;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: hinic: add missing destroy_workqueue in hinic_pf_to_mgmt_init
2022-05-12 8:41 [PATCH -next] net: hinic: add missing destroy_workqueue in hinic_pf_to_mgmt_init Zheng Bin
@ 2022-05-12 23:59 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-05-12 23:59 UTC (permalink / raw)
To: Zheng Bin; +Cc: davem, edumazet, pabeni, netdev, linux-kernel, gaochao49
On Thu, 12 May 2022 16:41:48 +0800 Zheng Bin wrote:
> hinic_pf_to_mgmt_init misses destroy_workqueue in error path,
> this patch fixes that.
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
Please add a Fixes tag and repost. Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-12 23:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12 8:41 [PATCH -next] net: hinic: add missing destroy_workqueue in hinic_pf_to_mgmt_init Zheng Bin
2022-05-12 23:59 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.