All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zoltan Boszormenyi" <zboszor@pr.hu>
To: openembedded-core@lists.openembedded.org
Cc: "Jean-Marie LEMETAYER"
	<jean-marie.lemetayer@savoirfairelinux.com>,
	"Zoltán Böszörményi" <zboszor@gmail.com>
Subject: [PATCH v2 2/3] npm.bbclass: Don't create /usr/lib/node symlink
Date: Fri, 13 May 2022 17:30:30 +0200	[thread overview]
Message-ID: <20220513153031.1032716-2-zboszor@pr.hu> (raw)
In-Reply-To: <20220513153031.1032716-1-zboszor@pr.hu>

From: Zoltán Böszörményi <zboszor@gmail.com>

When a recipe DEPENDS on multiple other npm based recipes,
the symlink will create a conflict.

Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
---
 meta/classes/npm.bbclass | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/meta/classes/npm.bbclass b/meta/classes/npm.bbclass
index 86ee0f665a..dbfc2e728e 100644
--- a/meta/classes/npm.bbclass
+++ b/meta/classes/npm.bbclass
@@ -307,10 +307,6 @@ npm_do_install() {
     # Remove the shrinkwrap file which does not need to be packed
     rm -f ${D}/${nonarch_libdir}/node_modules/*/npm-shrinkwrap.json
     rm -f ${D}/${nonarch_libdir}/node_modules/@*/*/npm-shrinkwrap.json
-
-    # node(1) is using /usr/lib/node as default include directory and npm(1) is
-    # using /usr/lib/node_modules as install directory. Let's make both happy.
-    ln -fs node_modules ${D}/${nonarch_libdir}/node
 }
 
 FILES:${PN} += " \
-- 
2.36.1


  reply	other threads:[~2022-05-13 15:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <16EEAE47FC3C363C.27599@lists.openembedded.org>
2022-05-13 15:30 ` [PATCH v2 1/3] npm.bbclass: Fix file permissions before opening it for writing Zoltan Boszormenyi
2022-05-13 15:30   ` Zoltan Boszormenyi [this message]
2022-05-13 15:30   ` [meta-oe][PATCH v2 3/3] nodejs: Add /usr/lib/node -> node_modules symlink Zoltan Boszormenyi
2022-05-13 15:42     ` [OE-core] " Alexander Kanavin
2022-05-13 16:48       ` Zoltan Boszormenyi
2022-05-13 17:50         ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220513153031.1032716-2-zboszor@pr.hu \
    --to=zboszor@pr.hu \
    --cc=jean-marie.lemetayer@savoirfairelinux.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=zboszor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.