All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Kanavin <alex.kanavin@gmail.com>
To: "Böszörményi Zoltán" <zboszor@pr.hu>
Cc: OE-core <openembedded-core@lists.openembedded.org>,
	"Jean-Marie LEMETAYER"
	<jean-marie.lemetayer@savoirfairelinux.com>,
	"Zoltán Böszörményi" <zboszor@gmail.com>
Subject: Re: [OE-core] [meta-oe][PATCH v2 3/3] nodejs: Add /usr/lib/node -> node_modules symlink
Date: Fri, 13 May 2022 17:42:18 +0200	[thread overview]
Message-ID: <CANNYZj8iwdYLGZ++GXsg4hcwZF9kQORzWF3Bv9QRRiYOV-95vw@mail.gmail.com> (raw)
In-Reply-To: <20220513153031.1032716-3-zboszor@pr.hu>

This needs to be sent to the openembedded-devel list.

Alex

On Fri, 13 May 2022 at 17:31, Zoltan Boszormenyi via
lists.openembedded.org <zboszor=pr.hu@lists.openembedded.org> wrote:
>
> From: Zoltán Böszörményi <zboszor@gmail.com>
>
> While /usr/lib/node_modules and all npm-related modules are
> shipped in the npm subpackage, keep the symlink in the main
> package because 3rd party modules that don't need npm are
> also installed into /usr/lib/node_modules.
>
> Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
> ---
>  meta-oe/recipes-devtools/nodejs/nodejs_16.14.2.bb | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_16.14.2.bb b/meta-oe/recipes-devtools/nodejs/nodejs_16.14.2.bb
> index 62188f94a..be68afd4c 100644
> --- a/meta-oe/recipes-devtools/nodejs/nodejs_16.14.2.bb
> +++ b/meta-oe/recipes-devtools/nodejs/nodejs_16.14.2.bb
> @@ -159,6 +159,10 @@ do_compile () {
>
>  do_install () {
>      oe_runmake install DESTDIR=${D}
> +
> +    # node(1) is using /usr/lib/node as default include directory and npm(1) is
> +    # using /usr/lib/node_modules as install directory. Let's make both happy.
> +    ln -fs node_modules ${D}/${nonarch_libdir}/node
>  }
>
>  BINARIES = " \
> @@ -176,6 +180,7 @@ do_install:append:class-native() {
>  }
>
>  PACKAGES =+ "${PN}-npm"
> +FILES:${PN} += "${nonarch_libdir}/node"
>  FILES:${PN}-npm = "${nonarch_libdir}/node_modules ${bindir}/npm ${bindir}/npx"
>  RDEPENDS:${PN}-npm = "bash python3-core python3-shell python3-datetime \
>      python3-misc python3-multiprocessing"
> --
> 2.36.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#165573): https://lists.openembedded.org/g/openembedded-core/message/165573
> Mute This Topic: https://lists.openembedded.org/mt/91083341/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


  reply	other threads:[~2022-05-13 15:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <16EEAE47FC3C363C.27599@lists.openembedded.org>
2022-05-13 15:30 ` [PATCH v2 1/3] npm.bbclass: Fix file permissions before opening it for writing Zoltan Boszormenyi
2022-05-13 15:30   ` [PATCH v2 2/3] npm.bbclass: Don't create /usr/lib/node symlink Zoltan Boszormenyi
2022-05-13 15:30   ` [meta-oe][PATCH v2 3/3] nodejs: Add /usr/lib/node -> node_modules symlink Zoltan Boszormenyi
2022-05-13 15:42     ` Alexander Kanavin [this message]
2022-05-13 16:48       ` [OE-core] " Zoltan Boszormenyi
2022-05-13 17:50         ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANNYZj8iwdYLGZ++GXsg4hcwZF9kQORzWF3Bv9QRRiYOV-95vw@mail.gmail.com \
    --to=alex.kanavin@gmail.com \
    --cc=jean-marie.lemetayer@savoirfairelinux.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=zboszor@gmail.com \
    --cc=zboszor@pr.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.