All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCHv3 bpf-next] selftests/bpf: add missed ima_setup.sh in Makefile
@ 2022-05-16  4:00 Hangbin Liu
  2022-05-17  3:15 ` Yonghong Song
  2022-05-19  0:20 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Hangbin Liu @ 2022-05-16  4:00 UTC (permalink / raw)
  To: netdev
  Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, bpf,
	Jakub Kicinski, David S . Miller, Mathieu Xhonneux, Lorenz Bauer,
	William Tu, Toshiaki Makita, Jesper Dangaard Brouer, Hangbin Liu

When build bpf test and install it to another folder, e.g.

  make -j10 install -C tools/testing/selftests/ TARGETS="bpf" \
	SKIP_TARGETS="" INSTALL_PATH=/tmp/kselftests

The ima_setup.sh is missed in target folder, which makes test_ima failed.

Fix it by adding ima_setup.sh to TEST_PROGS_EXTENDED.

Fixes: 34b82d3ac105 ("bpf: Add a selftest for bpf_ima_inode_hash")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
v3: rebase code to latest bpf-next, and drop the second patch
v2: fix subject prefix from net to bpf-next
---
 tools/testing/selftests/bpf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index 6bbc03161544..74dda54e88c4 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -75,7 +75,7 @@ TEST_PROGS := test_kmod.sh \
 	test_xsk.sh
 
 TEST_PROGS_EXTENDED := with_addr.sh \
-	with_tunnels.sh \
+	with_tunnels.sh ima_setup.sh \
 	test_xdp_vlan.sh test_bpftool.py
 
 # Compile but not part of 'make run_tests'
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCHv3 bpf-next] selftests/bpf: add missed ima_setup.sh in Makefile
  2022-05-16  4:00 [PATCHv3 bpf-next] selftests/bpf: add missed ima_setup.sh in Makefile Hangbin Liu
@ 2022-05-17  3:15 ` Yonghong Song
  2022-05-19  0:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Yonghong Song @ 2022-05-17  3:15 UTC (permalink / raw)
  To: Hangbin Liu, netdev
  Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, bpf,
	Jakub Kicinski, David S . Miller, Mathieu Xhonneux, Lorenz Bauer,
	William Tu, Toshiaki Makita, Jesper Dangaard Brouer



On 5/15/22 9:00 PM, Hangbin Liu wrote:
> When build bpf test and install it to another folder, e.g.
> 
>    make -j10 install -C tools/testing/selftests/ TARGETS="bpf" \
> 	SKIP_TARGETS="" INSTALL_PATH=/tmp/kselftests
> 
> The ima_setup.sh is missed in target folder, which makes test_ima failed.
> 
> Fix it by adding ima_setup.sh to TEST_PROGS_EXTENDED.
> 
> Fixes: 34b82d3ac105 ("bpf: Add a selftest for bpf_ima_inode_hash")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

Acked-by: Yonghong Song <yhs@fb.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCHv3 bpf-next] selftests/bpf: add missed ima_setup.sh in Makefile
  2022-05-16  4:00 [PATCHv3 bpf-next] selftests/bpf: add missed ima_setup.sh in Makefile Hangbin Liu
  2022-05-17  3:15 ` Yonghong Song
@ 2022-05-19  0:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-05-19  0:20 UTC (permalink / raw)
  To: Hangbin Liu
  Cc: netdev, ast, daniel, andrii, bpf, kuba, davem, m.xhonneux, lmb,
	u9012063, toshiaki.makita1, brouer

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Mon, 16 May 2022 12:00:20 +0800 you wrote:
> When build bpf test and install it to another folder, e.g.
> 
>   make -j10 install -C tools/testing/selftests/ TARGETS="bpf" \
> 	SKIP_TARGETS="" INSTALL_PATH=/tmp/kselftests
> 
> The ima_setup.sh is missed in target folder, which makes test_ima failed.
> 
> [...]

Here is the summary with links:
  - [PATCHv3,bpf-next] selftests/bpf: add missed ima_setup.sh in Makefile
    https://git.kernel.org/bpf/bpf-next/c/70a1b25326dd

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-05-19  0:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16  4:00 [PATCHv3 bpf-next] selftests/bpf: add missed ima_setup.sh in Makefile Hangbin Liu
2022-05-17  3:15 ` Yonghong Song
2022-05-19  0:20 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.