From: Bhupesh Sharma <bhupesh.sharma@linaro.org> To: linux-arm-msm@vger.kernel.org Cc: bhupesh.sharma@linaro.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, robh@kernel.org, linux-phy@lists.infradead.org, vkoul@kernel.org, konrad.dybcio@somainline.org, Rob Herring <robh+dt@kernel.org> Subject: [PATCH v4 1/4] dt-bindings: phy: qcom,qmp: Shift '#clock-cells' property to phy (child) node Date: Mon, 16 May 2022 12:01:52 +0530 [thread overview] Message-ID: <20220516063155.1332683-2-bhupesh.sharma@linaro.org> (raw) In-Reply-To: <20220516063155.1332683-1-bhupesh.sharma@linaro.org> Since the clock comes out of the phy (child) node, so clocks are actually not provided by the parent device. The qmp-phy dt-bindings specify the same incorrectly at present. Fix the same. This change helps fix the following 'make dtbs_check' warning(s): sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000: '#clock-cells' is a required property Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Vinod Koul <vkoul@kernel.org> Cc: Rob Herring <robh+dt@kernel.org> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml index 8b850c5ab116..c39ead81ecd7 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml @@ -66,9 +66,6 @@ properties: - description: Address and length of PHY's common serdes block. - description: Address and length of PHY's DP_COM control block. - "#clock-cells": - enum: [ 1, 2 ] - "#address-cells": enum: [ 1, 2 ] @@ -112,11 +109,13 @@ patternProperties: description: Each device node of QMP phy is required to have as many child nodes as the number of lanes the PHY has. + properties: + "#clock-cells": + enum: [ 0, 1, 2 ] required: - compatible - reg - - "#clock-cells" - "#address-cells" - "#size-cells" - ranges @@ -468,7 +467,6 @@ examples: usb_2_qmpphy: phy-wrapper@88eb000 { compatible = "qcom,sdm845-qmp-usb3-uni-phy"; reg = <0x088eb000 0x18c>; - #clock-cells = <1>; #address-cells = <1>; #size-cells = <1>; ranges = <0x0 0x088eb000 0x2000>; -- 2.35.3
WARNING: multiple messages have this Message-ID (diff)
From: Bhupesh Sharma <bhupesh.sharma@linaro.org> To: linux-arm-msm@vger.kernel.org Cc: bhupesh.sharma@linaro.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, robh@kernel.org, linux-phy@lists.infradead.org, vkoul@kernel.org, konrad.dybcio@somainline.org, Rob Herring <robh+dt@kernel.org> Subject: [PATCH v4 1/4] dt-bindings: phy: qcom, qmp: Shift '#clock-cells' property to phy (child) node Date: Mon, 16 May 2022 12:01:52 +0530 [thread overview] Message-ID: <20220516063155.1332683-2-bhupesh.sharma@linaro.org> (raw) In-Reply-To: <20220516063155.1332683-1-bhupesh.sharma@linaro.org> Since the clock comes out of the phy (child) node, so clocks are actually not provided by the parent device. The qmp-phy dt-bindings specify the same incorrectly at present. Fix the same. This change helps fix the following 'make dtbs_check' warning(s): sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000: '#clock-cells' is a required property Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Vinod Koul <vkoul@kernel.org> Cc: Rob Herring <robh+dt@kernel.org> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml index 8b850c5ab116..c39ead81ecd7 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml @@ -66,9 +66,6 @@ properties: - description: Address and length of PHY's common serdes block. - description: Address and length of PHY's DP_COM control block. - "#clock-cells": - enum: [ 1, 2 ] - "#address-cells": enum: [ 1, 2 ] @@ -112,11 +109,13 @@ patternProperties: description: Each device node of QMP phy is required to have as many child nodes as the number of lanes the PHY has. + properties: + "#clock-cells": + enum: [ 0, 1, 2 ] required: - compatible - reg - - "#clock-cells" - "#address-cells" - "#size-cells" - ranges @@ -468,7 +467,6 @@ examples: usb_2_qmpphy: phy-wrapper@88eb000 { compatible = "qcom,sdm845-qmp-usb3-uni-phy"; reg = <0x088eb000 0x18c>; - #clock-cells = <1>; #address-cells = <1>; #size-cells = <1>; ranges = <0x0 0x088eb000 0x2000>; -- 2.35.3 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-05-16 6:32 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-16 6:31 [PATCH v4 0/4] Fix dtbs_check warning(s) for Qualcomm QMP PHY Bhupesh Sharma 2022-05-16 6:31 ` Bhupesh Sharma 2022-05-16 6:31 ` Bhupesh Sharma [this message] 2022-05-16 6:31 ` [PATCH v4 1/4] dt-bindings: phy: qcom, qmp: Shift '#clock-cells' property to phy (child) node Bhupesh Sharma 2022-05-16 6:31 ` [PATCH v4 2/4] dt-bindings: phy: qcom,qmp: Describe phy@ subnode properly Bhupesh Sharma 2022-05-16 6:31 ` [PATCH v4 2/4] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma 2022-05-16 6:31 ` [PATCH v4 3/4] dt-bindings: phy: qcom,qmp: Add 'power-domains' property Bhupesh Sharma 2022-05-16 6:31 ` [PATCH v4 3/4] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma 2022-05-16 6:31 ` [PATCH v4 4/4] arm64: dts: qcom: Remove unused 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties Bhupesh Sharma 2022-05-16 6:31 ` Bhupesh Sharma 2022-07-03 3:55 ` (subset) " Bjorn Andersson 2022-07-03 3:55 ` Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220516063155.1332683-2-bhupesh.sharma@linaro.org \ --to=bhupesh.sharma@linaro.org \ --cc=bhupesh.linux@gmail.com \ --cc=bjorn.andersson@linaro.org \ --cc=konrad.dybcio@somainline.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=robh+dt@kernel.org \ --cc=robh@kernel.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.