From: Max Krummenacher <max.oss.09@gmail.com> To: max.krummenacher@toradex.com Cc: Fabio Estevam <festevam@gmail.com>, Krzysztof Kozlowski <krzk+dt@kernel.org>, NXP Linux Team <linux-imx@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, Rob Herring <robh+dt@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 15/17] ARM: dts: imx6q-apalis: backlight pwm: Simplify inverted backlight Date: Mon, 16 May 2022 13:58:43 +0200 [thread overview] Message-ID: <20220516115846.58328-16-max.oss.09@gmail.com> (raw) In-Reply-To: <20220516115846.58328-1-max.oss.09@gmail.com> From: Max Krummenacher <max.krummenacher@toradex.com> Set #pwm-cells to the default 3 to gain access to the parameter which allows inverting the PWM signal. This is useful to specify a backlight which has its highest brightness at 0. With the change to use the PWM with inverted polarity the PWM signal is inverted to how it was before this patch. This changes the meaning of the values in the brightness-levels property. I.e. the duty-cycle changes from x/255 to (255-x)/255. Keeping the brightness-levels will then have a big brightness jump from 0 to 127 duty cycle, the other 6 steps will then be barely noticeable. Change the brightness-levels to provide the same brightness-levels as before. Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com> --- arch/arm/boot/dts/imx6qdl-apalis.dtsi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi index 57642aefe349..49669caac8b7 100644 --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi @@ -6,6 +6,7 @@ */ #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/pwm/pwm.h> / { model = "Toradex Apalis iMX6Q/D Module"; @@ -19,13 +20,13 @@ backlight: backlight { compatible = "pwm-backlight"; + brightness-levels = <0 4 8 16 32 64 128 255>; + default-brightness-level = <6>; + enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_gpio_bl_on>; - brightness-levels = <0 127 191 223 239 247 251 255>; - default-brightness-level = <1>; - enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>; power-supply = <®_module_3v3>; - pwms = <&pwm4 0 5000000>; + pwms = <&pwm4 0 5000000 PWM_POLARITY_INVERTED>; status = "disabled"; }; @@ -761,7 +762,6 @@ }; &pwm4 { - #pwm-cells = <2>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pwm4>; status = "disabled"; -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Max Krummenacher <max.oss.09@gmail.com> To: max.krummenacher@toradex.com Cc: Fabio Estevam <festevam@gmail.com>, Krzysztof Kozlowski <krzk+dt@kernel.org>, NXP Linux Team <linux-imx@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, Rob Herring <robh+dt@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 15/17] ARM: dts: imx6q-apalis: backlight pwm: Simplify inverted backlight Date: Mon, 16 May 2022 13:58:43 +0200 [thread overview] Message-ID: <20220516115846.58328-16-max.oss.09@gmail.com> (raw) In-Reply-To: <20220516115846.58328-1-max.oss.09@gmail.com> From: Max Krummenacher <max.krummenacher@toradex.com> Set #pwm-cells to the default 3 to gain access to the parameter which allows inverting the PWM signal. This is useful to specify a backlight which has its highest brightness at 0. With the change to use the PWM with inverted polarity the PWM signal is inverted to how it was before this patch. This changes the meaning of the values in the brightness-levels property. I.e. the duty-cycle changes from x/255 to (255-x)/255. Keeping the brightness-levels will then have a big brightness jump from 0 to 127 duty cycle, the other 6 steps will then be barely noticeable. Change the brightness-levels to provide the same brightness-levels as before. Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com> --- arch/arm/boot/dts/imx6qdl-apalis.dtsi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi index 57642aefe349..49669caac8b7 100644 --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi @@ -6,6 +6,7 @@ */ #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/pwm/pwm.h> / { model = "Toradex Apalis iMX6Q/D Module"; @@ -19,13 +20,13 @@ backlight: backlight { compatible = "pwm-backlight"; + brightness-levels = <0 4 8 16 32 64 128 255>; + default-brightness-level = <6>; + enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_gpio_bl_on>; - brightness-levels = <0 127 191 223 239 247 251 255>; - default-brightness-level = <1>; - enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>; power-supply = <®_module_3v3>; - pwms = <&pwm4 0 5000000>; + pwms = <&pwm4 0 5000000 PWM_POLARITY_INVERTED>; status = "disabled"; }; @@ -761,7 +762,6 @@ }; &pwm4 { - #pwm-cells = <2>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pwm4>; status = "disabled"; -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-16 12:01 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-16 11:58 [PATCH v1 00/17] ARM: dts: imx6q-apalis: Misc improvements and newly added carrier Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher 2022-05-16 11:58 ` [PATCH v1 01/17] dt-bindings: arm: fsl: Add carrier for toradex,apalis-imx6q Max Krummenacher 2022-05-18 0:57 ` Rob Herring 2022-05-16 11:58 ` [PATCH v1 02/17] Revert "ARM: dts: imx6qdl-apalis: Avoid underscore in node name" Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher 2022-05-16 12:49 ` Ahmad Fatoum 2022-05-16 12:49 ` Ahmad Fatoum 2022-05-16 14:53 ` Francesco Dolcini 2022-05-16 14:53 ` Francesco Dolcini 2022-05-16 15:07 ` Ahmad Fatoum 2022-05-16 15:07 ` Ahmad Fatoum 2022-05-18 19:01 ` Rob Herring 2022-05-18 19:01 ` Rob Herring 2022-05-16 11:58 ` [PATCH v1 03/17] ARM: dts: imx6q-apalis: Add gpio-line-names Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher 2022-05-16 11:58 ` [PATCH v1 04/17] ARM: dts: imx6q-apalis: Command pmic to standby for poweroff Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher 2022-05-16 11:58 ` [PATCH v1 05/17] ARM: dts: imx6q-apalis: Move parallel rgb interface to SoM dtsi Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher 2022-05-16 11:58 ` [PATCH v1 06/17] ARM: dts: imx6q-apalis: Move pinmux groups " Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher 2022-05-16 11:58 ` [PATCH v1 07/17] ARM: dts: imx6q-apalis: Move Atmel MXT touch ctrl " Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher 2022-05-16 11:58 ` [PATCH v1 08/17] ARM: dts: imx6q-apalis: Add LVDS panel support Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher 2022-05-16 11:58 ` [PATCH v1 09/17] ARM: dts: imx6q-apalis: Disable HDMI Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher 2022-05-16 11:58 ` [PATCH v1 10/17] ARM: dts: imx6q-apalis: Disable stmpe touchscreen Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher 2022-05-16 11:58 ` [PATCH v1 11/17] ARM: dts: imx6q-apalis: Add ov5640 mipi csi camera Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher 2022-05-16 12:08 ` Fabio Estevam 2022-05-16 12:08 ` Fabio Estevam 2022-05-18 14:21 ` Max Krummenacher 2022-05-18 14:21 ` Max Krummenacher 2022-05-18 14:25 ` Fabio Estevam 2022-05-18 14:25 ` Fabio Estevam 2022-05-18 14:54 ` Max Krummenacher 2022-05-18 14:54 ` Max Krummenacher 2022-05-17 18:28 ` Fabio Estevam 2022-05-17 18:28 ` Fabio Estevam 2022-05-18 14:28 ` Max Krummenacher 2022-05-18 14:28 ` Max Krummenacher 2022-05-16 11:58 ` [PATCH v1 12/17] ARM: dts: imx6q-apalis: Add adv7280 video input Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher 2022-05-16 12:10 ` Fabio Estevam 2022-05-16 12:10 ` Fabio Estevam 2022-05-18 14:07 ` Max Krummenacher 2022-05-18 14:07 ` Max Krummenacher 2022-05-18 14:10 ` Fabio Estevam 2022-05-18 14:10 ` Fabio Estevam 2022-05-16 11:58 ` [PATCH v1 13/17] ARM: dts: imx6q-apalis: Clean-up sd card support Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher 2022-05-16 11:58 ` [PATCH v1 14/17] ARM: dts: imx6q-apalis: Add support for Toradex Ixora V1.2 carrier boards Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher [this message] 2022-05-16 11:58 ` [PATCH v1 15/17] ARM: dts: imx6q-apalis: backlight pwm: Simplify inverted backlight Max Krummenacher 2022-05-16 11:58 ` [PATCH v1 16/17] ARM: dts: imx6q-apalis: backlight pwm: Adapt brightness steps Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher 2022-05-16 11:58 ` [PATCH v1 17/17] ARM: dts: imx6q-apalis: Cleanup Max Krummenacher 2022-05-16 11:58 ` Max Krummenacher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220516115846.58328-16-max.oss.09@gmail.com \ --to=max.oss.09@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=krzk+dt@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=max.krummenacher@toradex.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.