* [PATCH] media: stm32-dcmi: add support of 1X16 serial pixel formats variant
@ 2022-05-16 9:20 ` Hugues Fruchet
0 siblings, 0 replies; 8+ messages in thread
From: Hugues Fruchet @ 2022-05-16 9:20 UTC (permalink / raw)
To: Alexandre Torgue, Mauro Carvalho Chehab, Hans Verkuil, Sakari Ailus
Cc: linux-media, linux-arm-kernel, linux-kernel, linux-stm32,
Alain Volmat, Yannick Fertre, Philippe CORNU, Hugues Fruchet
From: Hugues Fruchet <hugues.fruchet@st.com>
Add support of 1X16 serial pixel formats in order to support
CSI-2 camera sensor exposing 1x16 pixel formats only.
Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
---
drivers/media/platform/st/stm32/stm32-dcmi.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/platform/st/stm32/stm32-dcmi.c
index 09a743cd7004..b2ba4d95bfa3 100644
--- a/drivers/media/platform/st/stm32/stm32-dcmi.c
+++ b/drivers/media/platform/st/stm32/stm32-dcmi.c
@@ -1592,25 +1592,31 @@ static int dcmi_set_default_fmt(struct stm32_dcmi *dcmi)
return 0;
}
-/*
- * FIXME: For the time being we only support subdevices
- * which expose RGB & YUV "parallel form" mbus code (_2X8).
- * Nevertheless, this allows to support serial source subdevices
- * and serial to parallel bridges which conform to this.
- */
static const struct dcmi_format dcmi_formats[] = {
{
.fourcc = V4L2_PIX_FMT_RGB565,
.mbus_code = MEDIA_BUS_FMT_RGB565_2X8_LE,
.bpp = 2,
+ }, {
+ .fourcc = V4L2_PIX_FMT_RGB565,
+ .mbus_code = MEDIA_BUS_FMT_RGB565_1X16,
+ .bpp = 2,
}, {
.fourcc = V4L2_PIX_FMT_YUYV,
.mbus_code = MEDIA_BUS_FMT_YUYV8_2X8,
.bpp = 2,
+ }, {
+ .fourcc = V4L2_PIX_FMT_YUYV,
+ .mbus_code = MEDIA_BUS_FMT_YUYV8_1X16,
+ .bpp = 2,
}, {
.fourcc = V4L2_PIX_FMT_UYVY,
.mbus_code = MEDIA_BUS_FMT_UYVY8_2X8,
.bpp = 2,
+ }, {
+ .fourcc = V4L2_PIX_FMT_UYVY,
+ .mbus_code = MEDIA_BUS_FMT_UYVY8_1X16,
+ .bpp = 2,
}, {
.fourcc = V4L2_PIX_FMT_JPEG,
.mbus_code = MEDIA_BUS_FMT_JPEG_1X8,
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] media: stm32-dcmi: add support of 1X16 serial pixel formats variant
@ 2022-05-16 9:20 ` Hugues Fruchet
0 siblings, 0 replies; 8+ messages in thread
From: Hugues Fruchet @ 2022-05-16 9:20 UTC (permalink / raw)
To: Alexandre Torgue, Mauro Carvalho Chehab, Hans Verkuil, Sakari Ailus
Cc: linux-media, linux-arm-kernel, linux-kernel, linux-stm32,
Alain Volmat, Yannick Fertre, Philippe CORNU, Hugues Fruchet
From: Hugues Fruchet <hugues.fruchet@st.com>
Add support of 1X16 serial pixel formats in order to support
CSI-2 camera sensor exposing 1x16 pixel formats only.
Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
---
drivers/media/platform/st/stm32/stm32-dcmi.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/platform/st/stm32/stm32-dcmi.c
index 09a743cd7004..b2ba4d95bfa3 100644
--- a/drivers/media/platform/st/stm32/stm32-dcmi.c
+++ b/drivers/media/platform/st/stm32/stm32-dcmi.c
@@ -1592,25 +1592,31 @@ static int dcmi_set_default_fmt(struct stm32_dcmi *dcmi)
return 0;
}
-/*
- * FIXME: For the time being we only support subdevices
- * which expose RGB & YUV "parallel form" mbus code (_2X8).
- * Nevertheless, this allows to support serial source subdevices
- * and serial to parallel bridges which conform to this.
- */
static const struct dcmi_format dcmi_formats[] = {
{
.fourcc = V4L2_PIX_FMT_RGB565,
.mbus_code = MEDIA_BUS_FMT_RGB565_2X8_LE,
.bpp = 2,
+ }, {
+ .fourcc = V4L2_PIX_FMT_RGB565,
+ .mbus_code = MEDIA_BUS_FMT_RGB565_1X16,
+ .bpp = 2,
}, {
.fourcc = V4L2_PIX_FMT_YUYV,
.mbus_code = MEDIA_BUS_FMT_YUYV8_2X8,
.bpp = 2,
+ }, {
+ .fourcc = V4L2_PIX_FMT_YUYV,
+ .mbus_code = MEDIA_BUS_FMT_YUYV8_1X16,
+ .bpp = 2,
}, {
.fourcc = V4L2_PIX_FMT_UYVY,
.mbus_code = MEDIA_BUS_FMT_UYVY8_2X8,
.bpp = 2,
+ }, {
+ .fourcc = V4L2_PIX_FMT_UYVY,
+ .mbus_code = MEDIA_BUS_FMT_UYVY8_1X16,
+ .bpp = 2,
}, {
.fourcc = V4L2_PIX_FMT_JPEG,
.mbus_code = MEDIA_BUS_FMT_JPEG_1X8,
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] media: stm32-dcmi: add support of 1X16 serial pixel formats variant
2022-05-16 9:20 ` Hugues Fruchet
@ 2022-05-16 15:02 ` Jacopo Mondi
-1 siblings, 0 replies; 8+ messages in thread
From: Jacopo Mondi @ 2022-05-16 15:02 UTC (permalink / raw)
To: Hugues Fruchet, Sakari Ailus
Cc: Alexandre Torgue, Mauro Carvalho Chehab, Hans Verkuil,
Sakari Ailus, linux-media, linux-arm-kernel, linux-kernel,
linux-stm32, Alain Volmat, Yannick Fertre, Philippe CORNU
Hi Hugues,
On Mon, May 16, 2022 at 11:20:48AM +0200, Hugues Fruchet wrote:
> From: Hugues Fruchet <hugues.fruchet@st.com>
>
> Add support of 1X16 serial pixel formats in order to support
> CSI-2 camera sensor exposing 1x16 pixel formats only.
>
> Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Sakari, if you're sending a new pull request for the ov5640 series,
could you include this one as otherwise dcmi would be broken when used
with that sensor.
Thanks
j
> ---
> drivers/media/platform/st/stm32/stm32-dcmi.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/platform/st/stm32/stm32-dcmi.c
> index 09a743cd7004..b2ba4d95bfa3 100644
> --- a/drivers/media/platform/st/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/st/stm32/stm32-dcmi.c
> @@ -1592,25 +1592,31 @@ static int dcmi_set_default_fmt(struct stm32_dcmi *dcmi)
> return 0;
> }
>
> -/*
> - * FIXME: For the time being we only support subdevices
> - * which expose RGB & YUV "parallel form" mbus code (_2X8).
> - * Nevertheless, this allows to support serial source subdevices
> - * and serial to parallel bridges which conform to this.
> - */
> static const struct dcmi_format dcmi_formats[] = {
> {
> .fourcc = V4L2_PIX_FMT_RGB565,
> .mbus_code = MEDIA_BUS_FMT_RGB565_2X8_LE,
> .bpp = 2,
> + }, {
> + .fourcc = V4L2_PIX_FMT_RGB565,
> + .mbus_code = MEDIA_BUS_FMT_RGB565_1X16,
> + .bpp = 2,
> }, {
> .fourcc = V4L2_PIX_FMT_YUYV,
> .mbus_code = MEDIA_BUS_FMT_YUYV8_2X8,
> .bpp = 2,
> + }, {
> + .fourcc = V4L2_PIX_FMT_YUYV,
> + .mbus_code = MEDIA_BUS_FMT_YUYV8_1X16,
> + .bpp = 2,
> }, {
> .fourcc = V4L2_PIX_FMT_UYVY,
> .mbus_code = MEDIA_BUS_FMT_UYVY8_2X8,
> .bpp = 2,
> + }, {
> + .fourcc = V4L2_PIX_FMT_UYVY,
> + .mbus_code = MEDIA_BUS_FMT_UYVY8_1X16,
> + .bpp = 2,
> }, {
> .fourcc = V4L2_PIX_FMT_JPEG,
> .mbus_code = MEDIA_BUS_FMT_JPEG_1X8,
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: stm32-dcmi: add support of 1X16 serial pixel formats variant
@ 2022-05-16 15:02 ` Jacopo Mondi
0 siblings, 0 replies; 8+ messages in thread
From: Jacopo Mondi @ 2022-05-16 15:02 UTC (permalink / raw)
To: Hugues Fruchet, Sakari Ailus
Cc: Alexandre Torgue, Mauro Carvalho Chehab, Hans Verkuil,
Sakari Ailus, linux-media, linux-arm-kernel, linux-kernel,
linux-stm32, Alain Volmat, Yannick Fertre, Philippe CORNU
Hi Hugues,
On Mon, May 16, 2022 at 11:20:48AM +0200, Hugues Fruchet wrote:
> From: Hugues Fruchet <hugues.fruchet@st.com>
>
> Add support of 1X16 serial pixel formats in order to support
> CSI-2 camera sensor exposing 1x16 pixel formats only.
>
> Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Sakari, if you're sending a new pull request for the ov5640 series,
could you include this one as otherwise dcmi would be broken when used
with that sensor.
Thanks
j
> ---
> drivers/media/platform/st/stm32/stm32-dcmi.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/platform/st/stm32/stm32-dcmi.c
> index 09a743cd7004..b2ba4d95bfa3 100644
> --- a/drivers/media/platform/st/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/st/stm32/stm32-dcmi.c
> @@ -1592,25 +1592,31 @@ static int dcmi_set_default_fmt(struct stm32_dcmi *dcmi)
> return 0;
> }
>
> -/*
> - * FIXME: For the time being we only support subdevices
> - * which expose RGB & YUV "parallel form" mbus code (_2X8).
> - * Nevertheless, this allows to support serial source subdevices
> - * and serial to parallel bridges which conform to this.
> - */
> static const struct dcmi_format dcmi_formats[] = {
> {
> .fourcc = V4L2_PIX_FMT_RGB565,
> .mbus_code = MEDIA_BUS_FMT_RGB565_2X8_LE,
> .bpp = 2,
> + }, {
> + .fourcc = V4L2_PIX_FMT_RGB565,
> + .mbus_code = MEDIA_BUS_FMT_RGB565_1X16,
> + .bpp = 2,
> }, {
> .fourcc = V4L2_PIX_FMT_YUYV,
> .mbus_code = MEDIA_BUS_FMT_YUYV8_2X8,
> .bpp = 2,
> + }, {
> + .fourcc = V4L2_PIX_FMT_YUYV,
> + .mbus_code = MEDIA_BUS_FMT_YUYV8_1X16,
> + .bpp = 2,
> }, {
> .fourcc = V4L2_PIX_FMT_UYVY,
> .mbus_code = MEDIA_BUS_FMT_UYVY8_2X8,
> .bpp = 2,
> + }, {
> + .fourcc = V4L2_PIX_FMT_UYVY,
> + .mbus_code = MEDIA_BUS_FMT_UYVY8_1X16,
> + .bpp = 2,
> }, {
> .fourcc = V4L2_PIX_FMT_JPEG,
> .mbus_code = MEDIA_BUS_FMT_JPEG_1X8,
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: stm32-dcmi: add support of 1X16 serial pixel formats variant
2022-05-16 15:02 ` Jacopo Mondi
@ 2022-05-18 17:08 ` Sakari Ailus
-1 siblings, 0 replies; 8+ messages in thread
From: Sakari Ailus @ 2022-05-18 17:08 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Hugues Fruchet, Alexandre Torgue, Mauro Carvalho Chehab,
Hans Verkuil, linux-media, linux-arm-kernel, linux-kernel,
linux-stm32, Alain Volmat, Yannick Fertre, Philippe CORNU
Hi Jacopo,
On Mon, May 16, 2022 at 05:02:37PM +0200, Jacopo Mondi wrote:
> Hi Hugues,
>
> On Mon, May 16, 2022 at 11:20:48AM +0200, Hugues Fruchet wrote:
> > From: Hugues Fruchet <hugues.fruchet@st.com>
> >
> > Add support of 1X16 serial pixel formats in order to support
> > CSI-2 camera sensor exposing 1x16 pixel formats only.
> >
> > Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
>
> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
>
> Sakari, if you're sending a new pull request for the ov5640 series,
> could you include this one as otherwise dcmi would be broken when used
> with that sensor.
Just took this into my tree, with your refreshed ov5640 set.
Thanks!
--
Sakari Ailus
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: stm32-dcmi: add support of 1X16 serial pixel formats variant
@ 2022-05-18 17:08 ` Sakari Ailus
0 siblings, 0 replies; 8+ messages in thread
From: Sakari Ailus @ 2022-05-18 17:08 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Hugues Fruchet, Alexandre Torgue, Mauro Carvalho Chehab,
Hans Verkuil, linux-media, linux-arm-kernel, linux-kernel,
linux-stm32, Alain Volmat, Yannick Fertre, Philippe CORNU
Hi Jacopo,
On Mon, May 16, 2022 at 05:02:37PM +0200, Jacopo Mondi wrote:
> Hi Hugues,
>
> On Mon, May 16, 2022 at 11:20:48AM +0200, Hugues Fruchet wrote:
> > From: Hugues Fruchet <hugues.fruchet@st.com>
> >
> > Add support of 1X16 serial pixel formats in order to support
> > CSI-2 camera sensor exposing 1x16 pixel formats only.
> >
> > Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
>
> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
>
> Sakari, if you're sending a new pull request for the ov5640 series,
> could you include this one as otherwise dcmi would be broken when used
> with that sensor.
Just took this into my tree, with your refreshed ov5640 set.
Thanks!
--
Sakari Ailus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: stm32-dcmi: add support of 1X16 serial pixel formats variant
2022-05-18 17:08 ` Sakari Ailus
@ 2022-05-19 7:28 ` Hugues FRUCHET
-1 siblings, 0 replies; 8+ messages in thread
From: Hugues FRUCHET @ 2022-05-19 7:28 UTC (permalink / raw)
To: Sakari Ailus, Jacopo Mondi
Cc: Alexandre Torgue, Mauro Carvalho Chehab, Hans Verkuil,
linux-media, linux-arm-kernel, linux-kernel, linux-stm32,
Alain Volmat, Yannick Fertre, Philippe CORNU
Hi Sakari, Jacopo
Thanks for all !
On 5/18/22 19:08, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Mon, May 16, 2022 at 05:02:37PM +0200, Jacopo Mondi wrote:
>> Hi Hugues,
>>
>> On Mon, May 16, 2022 at 11:20:48AM +0200, Hugues Fruchet wrote:
>>> From: Hugues Fruchet <hugues.fruchet@st.com>
>>>
>>> Add support of 1X16 serial pixel formats in order to support
>>> CSI-2 camera sensor exposing 1x16 pixel formats only.
>>>
>>> Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
>>
>> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
>>
>> Sakari, if you're sending a new pull request for the ov5640 series,
>> could you include this one as otherwise dcmi would be broken when used
>> with that sensor.
>
> Just took this into my tree, with your refreshed ov5640 set.
>
> Thanks!
>
BR,
Hugues.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: stm32-dcmi: add support of 1X16 serial pixel formats variant
@ 2022-05-19 7:28 ` Hugues FRUCHET
0 siblings, 0 replies; 8+ messages in thread
From: Hugues FRUCHET @ 2022-05-19 7:28 UTC (permalink / raw)
To: Sakari Ailus, Jacopo Mondi
Cc: Alexandre Torgue, Mauro Carvalho Chehab, Hans Verkuil,
linux-media, linux-arm-kernel, linux-kernel, linux-stm32,
Alain Volmat, Yannick Fertre, Philippe CORNU
Hi Sakari, Jacopo
Thanks for all !
On 5/18/22 19:08, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Mon, May 16, 2022 at 05:02:37PM +0200, Jacopo Mondi wrote:
>> Hi Hugues,
>>
>> On Mon, May 16, 2022 at 11:20:48AM +0200, Hugues Fruchet wrote:
>>> From: Hugues Fruchet <hugues.fruchet@st.com>
>>>
>>> Add support of 1X16 serial pixel formats in order to support
>>> CSI-2 camera sensor exposing 1x16 pixel formats only.
>>>
>>> Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
>>
>> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
>>
>> Sakari, if you're sending a new pull request for the ov5640 series,
>> could you include this one as otherwise dcmi would be broken when used
>> with that sensor.
>
> Just took this into my tree, with your refreshed ov5640 set.
>
> Thanks!
>
BR,
Hugues.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-05-19 7:29 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 9:20 [PATCH] media: stm32-dcmi: add support of 1X16 serial pixel formats variant Hugues Fruchet
2022-05-16 9:20 ` Hugues Fruchet
2022-05-16 15:02 ` Jacopo Mondi
2022-05-16 15:02 ` Jacopo Mondi
2022-05-18 17:08 ` Sakari Ailus
2022-05-18 17:08 ` Sakari Ailus
2022-05-19 7:28 ` Hugues FRUCHET
2022-05-19 7:28 ` Hugues FRUCHET
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.