* [PATCH 0/2] armada-3720-turris-mox and orion-mdio
@ 2022-05-16 22:47 ` Chris Packham
0 siblings, 0 replies; 12+ messages in thread
From: Chris Packham @ 2022-05-16 22:47 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
andrew, gregory.clement, sebastian.hesselbarth, kabel
Cc: netdev, devicetree, linux-kernel, linux-arm-kernel, Chris Packham
This is a follow up to the change that converted the orion-mdio dt-binding from
txt to DT schema format. At the time I thought the binding needed
'unevaluatedProperties: false' because the core mdio.yaml binding didn't handle
the DSA switches. In reality it was simply the invalid reg property causing the
downstream nodes to be unevaluated. Fixing the reg nodes means we can set
'unevaluatedProperties: true'
Marek,
I don't know if you had a change for the reg properties in flight. I didn't see
anything on lore/lkml so sorry if this crosses with something you've done.
Chris Packham (2):
arm64: dts: armada-3720-turris-mox: Correct reg property for mdio
devices
dt-bindings: net: marvell,orion-mdio: Set unevaluatedProperties to
false
.../devicetree/bindings/net/marvell,orion-mdio.yaml | 2 +-
.../boot/dts/marvell/armada-3720-turris-mox.dts | 12 ++++++------
2 files changed, 7 insertions(+), 7 deletions(-)
--
2.36.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH 1/2] arm64: dts: armada-3720-turris-mox: Correct reg property for mdio devices
2022-05-16 22:47 ` Chris Packham
@ 2022-05-16 22:48 ` Chris Packham
-1 siblings, 0 replies; 12+ messages in thread
From: Chris Packham @ 2022-05-16 22:48 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
andrew, gregory.clement, sebastian.hesselbarth, kabel
Cc: netdev, devicetree, linux-kernel, linux-arm-kernel, Chris Packham
MDIO devices have #address-cells = <1>, #size-cells = <0>. Now that we
have a schema enforcing this for marvell,orion-mdio we can see that the
turris-mox has a unnecessary 2nd cell for the switch nodes reg property
of it's switch devices. Remove the unnecessary 2nd cell from the
switches reg property.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
.../boot/dts/marvell/armada-3720-turris-mox.dts | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
index 1cee26479bfe..98c9a3265446 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
@@ -303,7 +303,7 @@ phy1: ethernet-phy@1 {
/* switch nodes are enabled by U-Boot if modules are present */
switch0@10 {
compatible = "marvell,mv88e6190";
- reg = <0x10 0>;
+ reg = <0x10>;
dsa,member = <0 0>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_PERIDOT(0)>;
@@ -428,7 +428,7 @@ port-sfp@a {
switch0@2 {
compatible = "marvell,mv88e6085";
- reg = <0x2 0>;
+ reg = <0x2>;
dsa,member = <0 0>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_TOPAZ>;
@@ -495,7 +495,7 @@ port@5 {
switch1@11 {
compatible = "marvell,mv88e6190";
- reg = <0x11 0>;
+ reg = <0x11>;
dsa,member = <0 1>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_PERIDOT(1)>;
@@ -620,7 +620,7 @@ port-sfp@a {
switch1@2 {
compatible = "marvell,mv88e6085";
- reg = <0x2 0>;
+ reg = <0x2>;
dsa,member = <0 1>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_TOPAZ>;
@@ -687,7 +687,7 @@ port@5 {
switch2@12 {
compatible = "marvell,mv88e6190";
- reg = <0x12 0>;
+ reg = <0x12>;
dsa,member = <0 2>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_PERIDOT(2)>;
@@ -803,7 +803,7 @@ port-sfp@a {
switch2@2 {
compatible = "marvell,mv88e6085";
- reg = <0x2 0>;
+ reg = <0x2>;
dsa,member = <0 2>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_TOPAZ>;
--
2.36.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 1/2] arm64: dts: armada-3720-turris-mox: Correct reg property for mdio devices
@ 2022-05-16 22:48 ` Chris Packham
0 siblings, 0 replies; 12+ messages in thread
From: Chris Packham @ 2022-05-16 22:48 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
andrew, gregory.clement, sebastian.hesselbarth, kabel
Cc: netdev, devicetree, linux-kernel, linux-arm-kernel, Chris Packham
MDIO devices have #address-cells = <1>, #size-cells = <0>. Now that we
have a schema enforcing this for marvell,orion-mdio we can see that the
turris-mox has a unnecessary 2nd cell for the switch nodes reg property
of it's switch devices. Remove the unnecessary 2nd cell from the
switches reg property.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
.../boot/dts/marvell/armada-3720-turris-mox.dts | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
index 1cee26479bfe..98c9a3265446 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
@@ -303,7 +303,7 @@ phy1: ethernet-phy@1 {
/* switch nodes are enabled by U-Boot if modules are present */
switch0@10 {
compatible = "marvell,mv88e6190";
- reg = <0x10 0>;
+ reg = <0x10>;
dsa,member = <0 0>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_PERIDOT(0)>;
@@ -428,7 +428,7 @@ port-sfp@a {
switch0@2 {
compatible = "marvell,mv88e6085";
- reg = <0x2 0>;
+ reg = <0x2>;
dsa,member = <0 0>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_TOPAZ>;
@@ -495,7 +495,7 @@ port@5 {
switch1@11 {
compatible = "marvell,mv88e6190";
- reg = <0x11 0>;
+ reg = <0x11>;
dsa,member = <0 1>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_PERIDOT(1)>;
@@ -620,7 +620,7 @@ port-sfp@a {
switch1@2 {
compatible = "marvell,mv88e6085";
- reg = <0x2 0>;
+ reg = <0x2>;
dsa,member = <0 1>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_TOPAZ>;
@@ -687,7 +687,7 @@ port@5 {
switch2@12 {
compatible = "marvell,mv88e6190";
- reg = <0x12 0>;
+ reg = <0x12>;
dsa,member = <0 2>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_PERIDOT(2)>;
@@ -803,7 +803,7 @@ port-sfp@a {
switch2@2 {
compatible = "marvell,mv88e6085";
- reg = <0x2 0>;
+ reg = <0x2>;
dsa,member = <0 2>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_TOPAZ>;
--
2.36.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 1/2] arm64: dts: armada-3720-turris-mox: Correct reg property for mdio devices
2022-05-16 22:48 ` Chris Packham
@ 2022-05-17 16:21 ` Marek Behún
-1 siblings, 0 replies; 12+ messages in thread
From: Marek Behún @ 2022-05-17 16:21 UTC (permalink / raw)
To: Chris Packham
Cc: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
andrew, gregory.clement, sebastian.hesselbarth, netdev,
devicetree, linux-kernel, linux-arm-kernel
On Tue, 17 May 2022 10:48:00 +1200
Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
> MDIO devices have #address-cells = <1>, #size-cells = <0>. Now that we
> have a schema enforcing this for marvell,orion-mdio we can see that the
> turris-mox has a unnecessary 2nd cell for the switch nodes reg property
> of it's switch devices. Remove the unnecessary 2nd cell from the
> switches reg property.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Marek Behún <kabel@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] arm64: dts: armada-3720-turris-mox: Correct reg property for mdio devices
@ 2022-05-17 16:21 ` Marek Behún
0 siblings, 0 replies; 12+ messages in thread
From: Marek Behún @ 2022-05-17 16:21 UTC (permalink / raw)
To: Chris Packham
Cc: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
andrew, gregory.clement, sebastian.hesselbarth, netdev,
devicetree, linux-kernel, linux-arm-kernel
On Tue, 17 May 2022 10:48:00 +1200
Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
> MDIO devices have #address-cells = <1>, #size-cells = <0>. Now that we
> have a schema enforcing this for marvell,orion-mdio we can see that the
> turris-mox has a unnecessary 2nd cell for the switch nodes reg property
> of it's switch devices. Remove the unnecessary 2nd cell from the
> switches reg property.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Marek Behún <kabel@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/2] dt-bindings: net: marvell,orion-mdio: Set unevaluatedProperties to false
2022-05-16 22:47 ` Chris Packham
@ 2022-05-16 22:48 ` Chris Packham
-1 siblings, 0 replies; 12+ messages in thread
From: Chris Packham @ 2022-05-16 22:48 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
andrew, gregory.clement, sebastian.hesselbarth, kabel
Cc: netdev, devicetree, linux-kernel, linux-arm-kernel, Chris Packham
When the binding was converted it appeared necessary to set
'unevaluatedProperties: true' because of the switch devices on the
turris-mox board. Actually the error was because of the reg property
being incorrect causing the rest of the properties to be unevaluated.
After the reg properties are fixed for turris-mox we can set
'unevaluatedProperties: false' as is generally expected.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
index fe3a3412f093..d2906b4a0f59 100644
--- a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
+++ b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
@@ -39,7 +39,7 @@ required:
- compatible
- reg
-unevaluatedProperties: true
+unevaluatedProperties: false
examples:
- |
--
2.36.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] dt-bindings: net: marvell, orion-mdio: Set unevaluatedProperties to false
@ 2022-05-16 22:48 ` Chris Packham
0 siblings, 0 replies; 12+ messages in thread
From: Chris Packham @ 2022-05-16 22:48 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
andrew, gregory.clement, sebastian.hesselbarth, kabel
Cc: netdev, devicetree, linux-kernel, linux-arm-kernel, Chris Packham
When the binding was converted it appeared necessary to set
'unevaluatedProperties: true' because of the switch devices on the
turris-mox board. Actually the error was because of the reg property
being incorrect causing the rest of the properties to be unevaluated.
After the reg properties are fixed for turris-mox we can set
'unevaluatedProperties: false' as is generally expected.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
index fe3a3412f093..d2906b4a0f59 100644
--- a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
+++ b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
@@ -39,7 +39,7 @@ required:
- compatible
- reg
-unevaluatedProperties: true
+unevaluatedProperties: false
examples:
- |
--
2.36.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] dt-bindings: net: marvell,orion-mdio: Set unevaluatedProperties to false
2022-05-16 22:48 ` [PATCH 2/2] dt-bindings: net: marvell, orion-mdio: " Chris Packham
@ 2022-05-17 15:11 ` Rob Herring
-1 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2022-05-17 15:11 UTC (permalink / raw)
To: Chris Packham
Cc: sebastian.hesselbarth, robh+dt, davem, pabeni, andrew, edumazet,
kuba, kabel, krzysztof.kozlowski+dt, devicetree,
linux-arm-kernel, netdev, linux-kernel, gregory.clement
On Tue, 17 May 2022 10:48:01 +1200, Chris Packham wrote:
> When the binding was converted it appeared necessary to set
> 'unevaluatedProperties: true' because of the switch devices on the
> turris-mox board. Actually the error was because of the reg property
> being incorrect causing the rest of the properties to be unevaluated.
>
> After the reg properties are fixed for turris-mox we can set
> 'unevaluatedProperties: false' as is generally expected.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] dt-bindings: net: marvell,orion-mdio: Set unevaluatedProperties to false
@ 2022-05-17 15:11 ` Rob Herring
0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2022-05-17 15:11 UTC (permalink / raw)
To: Chris Packham
Cc: sebastian.hesselbarth, robh+dt, davem, pabeni, andrew, edumazet,
kuba, kabel, krzysztof.kozlowski+dt, devicetree,
linux-arm-kernel, netdev, linux-kernel, gregory.clement
On Tue, 17 May 2022 10:48:01 +1200, Chris Packham wrote:
> When the binding was converted it appeared necessary to set
> 'unevaluatedProperties: true' because of the switch devices on the
> turris-mox board. Actually the error was because of the reg property
> being incorrect causing the rest of the properties to be unevaluated.
>
> After the reg properties are fixed for turris-mox we can set
> 'unevaluatedProperties: false' as is generally expected.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/2] armada-3720-turris-mox and orion-mdio
2022-05-16 22:47 ` Chris Packham
@ 2022-05-18 12:10 ` patchwork-bot+netdevbpf
-1 siblings, 0 replies; 12+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-05-18 12:10 UTC (permalink / raw)
To: Chris Packham
Cc: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
andrew, gregory.clement, sebastian.hesselbarth, kabel, netdev,
devicetree, linux-kernel, linux-arm-kernel
Hello:
This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Tue, 17 May 2022 10:47:59 +1200 you wrote:
> This is a follow up to the change that converted the orion-mdio dt-binding from
> txt to DT schema format. At the time I thought the binding needed
> 'unevaluatedProperties: false' because the core mdio.yaml binding didn't handle
> the DSA switches. In reality it was simply the invalid reg property causing the
> downstream nodes to be unevaluated. Fixing the reg nodes means we can set
> 'unevaluatedProperties: true'
>
> [...]
Here is the summary with links:
- [1/2] arm64: dts: armada-3720-turris-mox: Correct reg property for mdio devices
https://git.kernel.org/netdev/net-next/c/9fd914bb05c2
- [2/2] dt-bindings: net: marvell,orion-mdio: Set unevaluatedProperties to false
https://git.kernel.org/netdev/net-next/c/32d0efabeec0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/2] armada-3720-turris-mox and orion-mdio
@ 2022-05-18 12:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 12+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-05-18 12:10 UTC (permalink / raw)
To: Chris Packham
Cc: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
andrew, gregory.clement, sebastian.hesselbarth, kabel, netdev,
devicetree, linux-kernel, linux-arm-kernel
Hello:
This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Tue, 17 May 2022 10:47:59 +1200 you wrote:
> This is a follow up to the change that converted the orion-mdio dt-binding from
> txt to DT schema format. At the time I thought the binding needed
> 'unevaluatedProperties: false' because the core mdio.yaml binding didn't handle
> the DSA switches. In reality it was simply the invalid reg property causing the
> downstream nodes to be unevaluated. Fixing the reg nodes means we can set
> 'unevaluatedProperties: true'
>
> [...]
Here is the summary with links:
- [1/2] arm64: dts: armada-3720-turris-mox: Correct reg property for mdio devices
https://git.kernel.org/netdev/net-next/c/9fd914bb05c2
- [2/2] dt-bindings: net: marvell,orion-mdio: Set unevaluatedProperties to false
https://git.kernel.org/netdev/net-next/c/32d0efabeec0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread