* [PATCH] mediatek/mt76: cleanup the code a bit
@ 2022-05-17 6:29 ` Bernard Zhao
0 siblings, 0 replies; 6+ messages in thread
From: Bernard Zhao @ 2022-05-17 6:29 UTC (permalink / raw)
To: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
Sean Wang, Kalle Valo, David S. Miller, Jakub Kicinski,
Paolo Abeni, Matthias Brugger, Bernard Zhao, linux-wireless,
netdev, linux-arm-kernel, linux-mediatek, linux-kernel
Cc: zhaojunkui2008
Function mt76_register_debugfs just call mt76_register_debugfs_fops
with NULL op parameter.
This change is to cleanup the code a bit, elete the meaningless
mt76_register_debugfs, and all call mt76_register_debugfs_fops.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/net/wireless/mediatek/mt76/mt76.h | 4 ----
drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c | 3 ++-
drivers/net/wireless/mediatek/mt76/mt76x02_debugfs.c | 3 ++-
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h b/drivers/net/wireless/mediatek/mt76/mt76.h
index 882fb5d2517f..7967ac210c9b 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76.h
+++ b/drivers/net/wireless/mediatek/mt76/mt76.h
@@ -927,10 +927,6 @@ int mt76_register_phy(struct mt76_phy *phy, bool vht,
struct dentry *mt76_register_debugfs_fops(struct mt76_phy *phy,
const struct file_operations *ops);
-static inline struct dentry *mt76_register_debugfs(struct mt76_dev *dev)
-{
- return mt76_register_debugfs_fops(&dev->phy, NULL);
-}
int mt76_queues_read(struct seq_file *s, void *data);
void mt76_seq_puts_array(struct seq_file *file, const char *str,
diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c
index f52165dff422..6bfe28c82f4e 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c
@@ -96,8 +96,9 @@ DEFINE_SHOW_ATTRIBUTE(mt7603_ampdu_stat);
void mt7603_init_debugfs(struct mt7603_dev *dev)
{
struct dentry *dir;
+ struct mt76_dev *pdev = &dev->mt76;
- dir = mt76_register_debugfs(&dev->mt76);
+ dir = mt76_register_debugfs_fops(&pdev->phy, NULL);
if (!dir)
return;
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_debugfs.c b/drivers/net/wireless/mediatek/mt76/mt76x02_debugfs.c
index c4fe1c436aaa..346501d7d622 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x02_debugfs.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x02_debugfs.c
@@ -117,8 +117,9 @@ DEFINE_DEBUGFS_ATTRIBUTE(fops_edcca, mt76_edcca_get, mt76_edcca_set,
void mt76x02_init_debugfs(struct mt76x02_dev *dev)
{
struct dentry *dir;
+ struct mt76_dev *pdev = &dev->mt76;
- dir = mt76_register_debugfs(&dev->mt76);
+ dir = mt76_register_debugfs_fops(&pdev->phy, NULL);
if (!dir)
return;
--
2.33.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] mediatek/mt76: cleanup the code a bit
@ 2022-05-17 6:29 ` Bernard Zhao
0 siblings, 0 replies; 6+ messages in thread
From: Bernard Zhao @ 2022-05-17 6:29 UTC (permalink / raw)
To: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
Sean Wang, Kalle Valo, David S. Miller, Jakub Kicinski,
Paolo Abeni, Matthias Brugger, Bernard Zhao, linux-wireless,
netdev, linux-arm-kernel, linux-mediatek, linux-kernel
Cc: zhaojunkui2008
Function mt76_register_debugfs just call mt76_register_debugfs_fops
with NULL op parameter.
This change is to cleanup the code a bit, elete the meaningless
mt76_register_debugfs, and all call mt76_register_debugfs_fops.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/net/wireless/mediatek/mt76/mt76.h | 4 ----
drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c | 3 ++-
drivers/net/wireless/mediatek/mt76/mt76x02_debugfs.c | 3 ++-
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h b/drivers/net/wireless/mediatek/mt76/mt76.h
index 882fb5d2517f..7967ac210c9b 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76.h
+++ b/drivers/net/wireless/mediatek/mt76/mt76.h
@@ -927,10 +927,6 @@ int mt76_register_phy(struct mt76_phy *phy, bool vht,
struct dentry *mt76_register_debugfs_fops(struct mt76_phy *phy,
const struct file_operations *ops);
-static inline struct dentry *mt76_register_debugfs(struct mt76_dev *dev)
-{
- return mt76_register_debugfs_fops(&dev->phy, NULL);
-}
int mt76_queues_read(struct seq_file *s, void *data);
void mt76_seq_puts_array(struct seq_file *file, const char *str,
diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c
index f52165dff422..6bfe28c82f4e 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c
@@ -96,8 +96,9 @@ DEFINE_SHOW_ATTRIBUTE(mt7603_ampdu_stat);
void mt7603_init_debugfs(struct mt7603_dev *dev)
{
struct dentry *dir;
+ struct mt76_dev *pdev = &dev->mt76;
- dir = mt76_register_debugfs(&dev->mt76);
+ dir = mt76_register_debugfs_fops(&pdev->phy, NULL);
if (!dir)
return;
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_debugfs.c b/drivers/net/wireless/mediatek/mt76/mt76x02_debugfs.c
index c4fe1c436aaa..346501d7d622 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x02_debugfs.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x02_debugfs.c
@@ -117,8 +117,9 @@ DEFINE_DEBUGFS_ATTRIBUTE(fops_edcca, mt76_edcca_get, mt76_edcca_set,
void mt76x02_init_debugfs(struct mt76x02_dev *dev)
{
struct dentry *dir;
+ struct mt76_dev *pdev = &dev->mt76;
- dir = mt76_register_debugfs(&dev->mt76);
+ dir = mt76_register_debugfs_fops(&pdev->phy, NULL);
if (!dir)
return;
--
2.33.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] mediatek/mt76: cleanup the code a bit
@ 2022-05-17 6:29 ` Bernard Zhao
0 siblings, 0 replies; 6+ messages in thread
From: Bernard Zhao @ 2022-05-17 6:29 UTC (permalink / raw)
To: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
Sean Wang, Kalle Valo, David S. Miller, Jakub Kicinski,
Paolo Abeni, Matthias Brugger, Bernard Zhao, linux-wireless,
netdev, linux-arm-kernel, linux-mediatek, linux-kernel
Cc: zhaojunkui2008
Function mt76_register_debugfs just call mt76_register_debugfs_fops
with NULL op parameter.
This change is to cleanup the code a bit, elete the meaningless
mt76_register_debugfs, and all call mt76_register_debugfs_fops.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/net/wireless/mediatek/mt76/mt76.h | 4 ----
drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c | 3 ++-
drivers/net/wireless/mediatek/mt76/mt76x02_debugfs.c | 3 ++-
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h b/drivers/net/wireless/mediatek/mt76/mt76.h
index 882fb5d2517f..7967ac210c9b 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76.h
+++ b/drivers/net/wireless/mediatek/mt76/mt76.h
@@ -927,10 +927,6 @@ int mt76_register_phy(struct mt76_phy *phy, bool vht,
struct dentry *mt76_register_debugfs_fops(struct mt76_phy *phy,
const struct file_operations *ops);
-static inline struct dentry *mt76_register_debugfs(struct mt76_dev *dev)
-{
- return mt76_register_debugfs_fops(&dev->phy, NULL);
-}
int mt76_queues_read(struct seq_file *s, void *data);
void mt76_seq_puts_array(struct seq_file *file, const char *str,
diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c
index f52165dff422..6bfe28c82f4e 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c
@@ -96,8 +96,9 @@ DEFINE_SHOW_ATTRIBUTE(mt7603_ampdu_stat);
void mt7603_init_debugfs(struct mt7603_dev *dev)
{
struct dentry *dir;
+ struct mt76_dev *pdev = &dev->mt76;
- dir = mt76_register_debugfs(&dev->mt76);
+ dir = mt76_register_debugfs_fops(&pdev->phy, NULL);
if (!dir)
return;
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_debugfs.c b/drivers/net/wireless/mediatek/mt76/mt76x02_debugfs.c
index c4fe1c436aaa..346501d7d622 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x02_debugfs.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x02_debugfs.c
@@ -117,8 +117,9 @@ DEFINE_DEBUGFS_ATTRIBUTE(fops_edcca, mt76_edcca_get, mt76_edcca_set,
void mt76x02_init_debugfs(struct mt76x02_dev *dev)
{
struct dentry *dir;
+ struct mt76_dev *pdev = &dev->mt76;
- dir = mt76_register_debugfs(&dev->mt76);
+ dir = mt76_register_debugfs_fops(&pdev->phy, NULL);
if (!dir)
return;
--
2.33.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mediatek/mt76: cleanup the code a bit
2022-05-17 6:29 ` Bernard Zhao
(?)
@ 2022-05-18 5:10 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2022-05-18 5:10 UTC (permalink / raw)
To: Bernard Zhao
Cc: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
Sean Wang, David S. Miller, Jakub Kicinski, Paolo Abeni,
Matthias Brugger, linux-wireless, netdev, linux-arm-kernel,
linux-mediatek, linux-kernel, zhaojunkui2008
Bernard Zhao <bernard@vivo.com> writes:
> Function mt76_register_debugfs just call mt76_register_debugfs_fops
> with NULL op parameter.
> This change is to cleanup the code a bit, elete the meaningless
> mt76_register_debugfs, and all call mt76_register_debugfs_fops.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
Please make the title more informative and don't use mediatek in the
title, for example something like this:
mt76: remove simple mt76_register_debugfs() function
More info:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mediatek/mt76: cleanup the code a bit
@ 2022-05-18 5:10 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2022-05-18 5:10 UTC (permalink / raw)
To: Bernard Zhao
Cc: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
Sean Wang, David S. Miller, Jakub Kicinski, Paolo Abeni,
Matthias Brugger, linux-wireless, netdev, linux-arm-kernel,
linux-mediatek, linux-kernel, zhaojunkui2008
Bernard Zhao <bernard@vivo.com> writes:
> Function mt76_register_debugfs just call mt76_register_debugfs_fops
> with NULL op parameter.
> This change is to cleanup the code a bit, elete the meaningless
> mt76_register_debugfs, and all call mt76_register_debugfs_fops.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
Please make the title more informative and don't use mediatek in the
title, for example something like this:
mt76: remove simple mt76_register_debugfs() function
More info:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mediatek/mt76: cleanup the code a bit
@ 2022-05-18 5:10 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2022-05-18 5:10 UTC (permalink / raw)
To: Bernard Zhao
Cc: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
Sean Wang, David S. Miller, Jakub Kicinski, Paolo Abeni,
Matthias Brugger, linux-wireless, netdev, linux-arm-kernel,
linux-mediatek, linux-kernel, zhaojunkui2008
Bernard Zhao <bernard@vivo.com> writes:
> Function mt76_register_debugfs just call mt76_register_debugfs_fops
> with NULL op parameter.
> This change is to cleanup the code a bit, elete the meaningless
> mt76_register_debugfs, and all call mt76_register_debugfs_fops.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
Please make the title more informative and don't use mediatek in the
title, for example something like this:
mt76: remove simple mt76_register_debugfs() function
More info:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-18 5:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-17 6:29 [PATCH] mediatek/mt76: cleanup the code a bit Bernard Zhao
2022-05-17 6:29 ` Bernard Zhao
2022-05-17 6:29 ` Bernard Zhao
2022-05-18 5:10 ` Kalle Valo
2022-05-18 5:10 ` Kalle Valo
2022-05-18 5:10 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.