* [PATCH] fstests: add a btrfs read_repair group
@ 2022-05-17 6:35 Christoph Hellwig
2022-05-17 7:54 ` Zorro Lang
2022-05-17 13:24 ` Filipe Manana
0 siblings, 2 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-05-17 6:35 UTC (permalink / raw)
To: fstests; +Cc: linux-btrfs
Add a new group to run all tests the exercise the btrfs read_repair code.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
doc/group-names.txt | 1 +
tests/btrfs/140 | 2 +-
tests/btrfs/141 | 2 +-
tests/btrfs/142 | 2 +-
tests/btrfs/143 | 2 +-
tests/btrfs/150 | 2 +-
tests/btrfs/157 | 2 +-
tests/btrfs/215 | 2 +-
8 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/doc/group-names.txt b/doc/group-names.txt
index e8e3477e..ef411b5e 100644
--- a/doc/group-names.txt
+++ b/doc/group-names.txt
@@ -88,6 +88,7 @@ punch fallocate FALLOC_FL_PUNCH_HOLE
qgroup btrfs qgroup feature
quota filesystem usage quotas
raid btrfs RAID
+read_repair btrfs error correction on read failure
realtime XFS realtime volumes
recoveryloop crash recovery loops
redirect overlayfs redirect_dir feature
diff --git a/tests/btrfs/140 b/tests/btrfs/140
index 66efc126..c680fe0a 100755
--- a/tests/btrfs/140
+++ b/tests/btrfs/140
@@ -12,7 +12,7 @@
# commit 2e949b0a5592 ("Btrfs: fix invalid dereference in btrfs_retry_endio")
#
. ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
# Import common functions.
. ./common/filter
diff --git a/tests/btrfs/141 b/tests/btrfs/141
index ca164fdc..9fdcb2ab 100755
--- a/tests/btrfs/141
+++ b/tests/btrfs/141
@@ -13,7 +13,7 @@
# Commit 9d0d1c8b1c9d ("Btrfs: bring back repair during read")
#
. ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
# Import common functions.
. ./common/filter
diff --git a/tests/btrfs/142 b/tests/btrfs/142
index c88cace9..58d01add 100755
--- a/tests/btrfs/142
+++ b/tests/btrfs/142
@@ -13,7 +13,7 @@
# commit 97bf5a5589aa ("Btrfs: fix segmentation fault when doing dio read")
#
. ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
# Import common functions.
. ./common/filter
diff --git a/tests/btrfs/143 b/tests/btrfs/143
index 8f086ee8..71db861d 100755
--- a/tests/btrfs/143
+++ b/tests/btrfs/143
@@ -20,7 +20,7 @@
# commit 9d0d1c8b1c9d ("Btrfs: bring back repair during read")
#
. ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
# Import common functions.
. ./common/filter
diff --git a/tests/btrfs/150 b/tests/btrfs/150
index 986c8069..c5e9c709 100755
--- a/tests/btrfs/150
+++ b/tests/btrfs/150
@@ -11,7 +11,7 @@
# Btrfs: fix kernel oops while reading compressed data
#
. ./common/preamble
-_begin_fstest auto quick dangerous
+_begin_fstest auto quick dangerous read_repair
# Import common functions.
. ./common/filter
diff --git a/tests/btrfs/157 b/tests/btrfs/157
index ae56f3e1..343178b7 100755
--- a/tests/btrfs/157
+++ b/tests/btrfs/157
@@ -21,7 +21,7 @@
# Btrfs: make raid6 rebuild retry more
#
. ./common/preamble
-_begin_fstest auto quick raid
+_begin_fstest auto quick raid read_repair
# Import common functions.
. ./common/filter
diff --git a/tests/btrfs/215 b/tests/btrfs/215
index cbcd60e0..0dcbce2a 100755
--- a/tests/btrfs/215
+++ b/tests/btrfs/215
@@ -9,7 +9,7 @@
# 814723e0a55a ("btrfs: increment device corruption error in case of checksum error")
#
. ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
# Import common functions.
. ./common/filter
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] fstests: add a btrfs read_repair group
2022-05-17 6:35 [PATCH] fstests: add a btrfs read_repair group Christoph Hellwig
@ 2022-05-17 7:54 ` Zorro Lang
2022-05-17 13:24 ` Filipe Manana
1 sibling, 0 replies; 3+ messages in thread
From: Zorro Lang @ 2022-05-17 7:54 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: fstests, linux-btrfs
On Tue, May 17, 2022 at 08:35:02AM +0200, Christoph Hellwig wrote:
> Add a new group to run all tests the exercise the btrfs read_repair code.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
There's not objection from me to add this new group for btrfs. If btrfs forks
have more review points, feel free to point out.
Reviewed-by: Zorro Lang <zlang@redhat.com>
> doc/group-names.txt | 1 +
> tests/btrfs/140 | 2 +-
> tests/btrfs/141 | 2 +-
> tests/btrfs/142 | 2 +-
> tests/btrfs/143 | 2 +-
> tests/btrfs/150 | 2 +-
> tests/btrfs/157 | 2 +-
> tests/btrfs/215 | 2 +-
> 8 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/doc/group-names.txt b/doc/group-names.txt
> index e8e3477e..ef411b5e 100644
> --- a/doc/group-names.txt
> +++ b/doc/group-names.txt
> @@ -88,6 +88,7 @@ punch fallocate FALLOC_FL_PUNCH_HOLE
> qgroup btrfs qgroup feature
> quota filesystem usage quotas
> raid btrfs RAID
> +read_repair btrfs error correction on read failure
> realtime XFS realtime volumes
> recoveryloop crash recovery loops
> redirect overlayfs redirect_dir feature
> diff --git a/tests/btrfs/140 b/tests/btrfs/140
> index 66efc126..c680fe0a 100755
> --- a/tests/btrfs/140
> +++ b/tests/btrfs/140
> @@ -12,7 +12,7 @@
> # commit 2e949b0a5592 ("Btrfs: fix invalid dereference in btrfs_retry_endio")
> #
> . ./common/preamble
> -_begin_fstest auto quick
> +_begin_fstest auto quick read_repair
>
> # Import common functions.
> . ./common/filter
> diff --git a/tests/btrfs/141 b/tests/btrfs/141
> index ca164fdc..9fdcb2ab 100755
> --- a/tests/btrfs/141
> +++ b/tests/btrfs/141
> @@ -13,7 +13,7 @@
> # Commit 9d0d1c8b1c9d ("Btrfs: bring back repair during read")
> #
> . ./common/preamble
> -_begin_fstest auto quick
> +_begin_fstest auto quick read_repair
>
> # Import common functions.
> . ./common/filter
> diff --git a/tests/btrfs/142 b/tests/btrfs/142
> index c88cace9..58d01add 100755
> --- a/tests/btrfs/142
> +++ b/tests/btrfs/142
> @@ -13,7 +13,7 @@
> # commit 97bf5a5589aa ("Btrfs: fix segmentation fault when doing dio read")
> #
> . ./common/preamble
> -_begin_fstest auto quick
> +_begin_fstest auto quick read_repair
>
> # Import common functions.
> . ./common/filter
> diff --git a/tests/btrfs/143 b/tests/btrfs/143
> index 8f086ee8..71db861d 100755
> --- a/tests/btrfs/143
> +++ b/tests/btrfs/143
> @@ -20,7 +20,7 @@
> # commit 9d0d1c8b1c9d ("Btrfs: bring back repair during read")
> #
> . ./common/preamble
> -_begin_fstest auto quick
> +_begin_fstest auto quick read_repair
>
> # Import common functions.
> . ./common/filter
> diff --git a/tests/btrfs/150 b/tests/btrfs/150
> index 986c8069..c5e9c709 100755
> --- a/tests/btrfs/150
> +++ b/tests/btrfs/150
> @@ -11,7 +11,7 @@
> # Btrfs: fix kernel oops while reading compressed data
> #
> . ./common/preamble
> -_begin_fstest auto quick dangerous
> +_begin_fstest auto quick dangerous read_repair
>
> # Import common functions.
> . ./common/filter
> diff --git a/tests/btrfs/157 b/tests/btrfs/157
> index ae56f3e1..343178b7 100755
> --- a/tests/btrfs/157
> +++ b/tests/btrfs/157
> @@ -21,7 +21,7 @@
> # Btrfs: make raid6 rebuild retry more
> #
> . ./common/preamble
> -_begin_fstest auto quick raid
> +_begin_fstest auto quick raid read_repair
>
> # Import common functions.
> . ./common/filter
> diff --git a/tests/btrfs/215 b/tests/btrfs/215
> index cbcd60e0..0dcbce2a 100755
> --- a/tests/btrfs/215
> +++ b/tests/btrfs/215
> @@ -9,7 +9,7 @@
> # 814723e0a55a ("btrfs: increment device corruption error in case of checksum error")
> #
> . ./common/preamble
> -_begin_fstest auto quick
> +_begin_fstest auto quick read_repair
>
> # Import common functions.
> . ./common/filter
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fstests: add a btrfs read_repair group
2022-05-17 6:35 [PATCH] fstests: add a btrfs read_repair group Christoph Hellwig
2022-05-17 7:54 ` Zorro Lang
@ 2022-05-17 13:24 ` Filipe Manana
1 sibling, 0 replies; 3+ messages in thread
From: Filipe Manana @ 2022-05-17 13:24 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: fstests, linux-btrfs
On Tue, May 17, 2022 at 08:35:02AM +0200, Christoph Hellwig wrote:
> Add a new group to run all tests the exercise the btrfs read_repair code.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Looks good to me as well, thanks.
> ---
> doc/group-names.txt | 1 +
> tests/btrfs/140 | 2 +-
> tests/btrfs/141 | 2 +-
> tests/btrfs/142 | 2 +-
> tests/btrfs/143 | 2 +-
> tests/btrfs/150 | 2 +-
> tests/btrfs/157 | 2 +-
> tests/btrfs/215 | 2 +-
> 8 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/doc/group-names.txt b/doc/group-names.txt
> index e8e3477e..ef411b5e 100644
> --- a/doc/group-names.txt
> +++ b/doc/group-names.txt
> @@ -88,6 +88,7 @@ punch fallocate FALLOC_FL_PUNCH_HOLE
> qgroup btrfs qgroup feature
> quota filesystem usage quotas
> raid btrfs RAID
> +read_repair btrfs error correction on read failure
> realtime XFS realtime volumes
> recoveryloop crash recovery loops
> redirect overlayfs redirect_dir feature
> diff --git a/tests/btrfs/140 b/tests/btrfs/140
> index 66efc126..c680fe0a 100755
> --- a/tests/btrfs/140
> +++ b/tests/btrfs/140
> @@ -12,7 +12,7 @@
> # commit 2e949b0a5592 ("Btrfs: fix invalid dereference in btrfs_retry_endio")
> #
> . ./common/preamble
> -_begin_fstest auto quick
> +_begin_fstest auto quick read_repair
>
> # Import common functions.
> . ./common/filter
> diff --git a/tests/btrfs/141 b/tests/btrfs/141
> index ca164fdc..9fdcb2ab 100755
> --- a/tests/btrfs/141
> +++ b/tests/btrfs/141
> @@ -13,7 +13,7 @@
> # Commit 9d0d1c8b1c9d ("Btrfs: bring back repair during read")
> #
> . ./common/preamble
> -_begin_fstest auto quick
> +_begin_fstest auto quick read_repair
>
> # Import common functions.
> . ./common/filter
> diff --git a/tests/btrfs/142 b/tests/btrfs/142
> index c88cace9..58d01add 100755
> --- a/tests/btrfs/142
> +++ b/tests/btrfs/142
> @@ -13,7 +13,7 @@
> # commit 97bf5a5589aa ("Btrfs: fix segmentation fault when doing dio read")
> #
> . ./common/preamble
> -_begin_fstest auto quick
> +_begin_fstest auto quick read_repair
>
> # Import common functions.
> . ./common/filter
> diff --git a/tests/btrfs/143 b/tests/btrfs/143
> index 8f086ee8..71db861d 100755
> --- a/tests/btrfs/143
> +++ b/tests/btrfs/143
> @@ -20,7 +20,7 @@
> # commit 9d0d1c8b1c9d ("Btrfs: bring back repair during read")
> #
> . ./common/preamble
> -_begin_fstest auto quick
> +_begin_fstest auto quick read_repair
>
> # Import common functions.
> . ./common/filter
> diff --git a/tests/btrfs/150 b/tests/btrfs/150
> index 986c8069..c5e9c709 100755
> --- a/tests/btrfs/150
> +++ b/tests/btrfs/150
> @@ -11,7 +11,7 @@
> # Btrfs: fix kernel oops while reading compressed data
> #
> . ./common/preamble
> -_begin_fstest auto quick dangerous
> +_begin_fstest auto quick dangerous read_repair
>
> # Import common functions.
> . ./common/filter
> diff --git a/tests/btrfs/157 b/tests/btrfs/157
> index ae56f3e1..343178b7 100755
> --- a/tests/btrfs/157
> +++ b/tests/btrfs/157
> @@ -21,7 +21,7 @@
> # Btrfs: make raid6 rebuild retry more
> #
> . ./common/preamble
> -_begin_fstest auto quick raid
> +_begin_fstest auto quick raid read_repair
>
> # Import common functions.
> . ./common/filter
> diff --git a/tests/btrfs/215 b/tests/btrfs/215
> index cbcd60e0..0dcbce2a 100755
> --- a/tests/btrfs/215
> +++ b/tests/btrfs/215
> @@ -9,7 +9,7 @@
> # 814723e0a55a ("btrfs: increment device corruption error in case of checksum error")
> #
> . ./common/preamble
> -_begin_fstest auto quick
> +_begin_fstest auto quick read_repair
>
> # Import common functions.
> . ./common/filter
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-17 13:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-17 6:35 [PATCH] fstests: add a btrfs read_repair group Christoph Hellwig
2022-05-17 7:54 ` Zorro Lang
2022-05-17 13:24 ` Filipe Manana
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.