[PATCH] btrfs:zoned: Fix comment description for sb_write_pointer logic

[PATCH] btrfs:zoned: Fix comment description for sb_write_pointer logic

[Pankaj Raghav]

The comments describing the logic for evaluating the sb write pointer
does not represent what is done in the code. Fix it to represent the
actual logic used.

Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
---
 fs/btrfs/zoned.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index 057babaa3e05..c09b1b0208c4 100644
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -94,9 +94,9 @@ static int sb_write_pointer(struct block_device *bdev, struct blk_zone *zones,
 	 * Possible states of log buffer zones
 	 *
 	 *           Empty[0]  In use[0]  Full[0]
-	 * Empty[1]         *          x        0
-	 * In use[1]        0          x        0
-	 * Full[1]          1          1        C
+	 * Empty[1]         *          0        1
+	 * In use[1]        x          x        1
+	 * Full[1]          0          0        C
 	 *
 	 * Log position:
 	 *   *: Special case, no superblock is written
-- 
2.25.1

Re: [PATCH] btrfs:zoned: Fix comment description for sb_write_pointer logic

[David Sterba]

On Tue, May 17, 2022 at 10:22:55AM +0200, Pankaj Raghav wrote:
> The comments describing the logic for evaluating the sb write pointer
> does not represent what is done in the code. Fix it to represent the
> actual logic used.

It would be good to briefly describe what is the actual mistake in the
comment, so one can have an idea without looking to the code.

Re: [PATCH] btrfs:zoned: Fix comment description for sb_write_pointer logic

[Pankaj Raghav]

On 2022-05-17 14:13, David Sterba wrote:
> On Tue, May 17, 2022 at 10:22:55AM +0200, Pankaj Raghav wrote:
>> The comments describing the logic for evaluating the sb write pointer
>> does not represent what is done in the code. Fix it to represent the
>> actual logic used.
> 
> It would be good to briefly describe what is the actual mistake in the
> comment, so one can have an idea without looking to the code.
I should have done that. I will send a v2 with a more descriptive commit
log. Thanks

Re: [PATCH] btrfs:zoned: Fix comment description for sb_write_pointer logic

[Johannes Thumshirn]

With the commit log updated,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>