From: Tyrone Ting <warp5tw@gmail.com> To: avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, wsa@kernel.org, andriy.shevchenko@linux.intel.com, jarkko.nikula@linux.intel.com, semen.protsenko@linaro.org, rafal@milecki.pl, sven@svenpeter.dev, jsd@semihalf.com, jie.deng@intel.com, lukas.bulwahn@gmail.com, arnd@arndb.de, olof@lixom.net, warp5tw@gmail.com, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com Cc: openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 10/10] i2c: npcm: Capitalize the one-line comment Date: Tue, 17 May 2022 18:11:42 +0800 [thread overview] Message-ID: <20220517101142.28421-11-warp5tw@gmail.com> (raw) In-Reply-To: <20220517101142.28421-1-warp5tw@gmail.com> From: Tyrone Ting <kfting@nuvoton.com> Make the one-line comments capital in the driver to get the comment style consistent. Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver") Signed-off-by: Tyrone Ting <kfting@nuvoton.com> --- drivers/i2c/busses/i2c-npcm7xx.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c index a032b407f104..a60e392dda50 100644 --- a/drivers/i2c/busses/i2c-npcm7xx.c +++ b/drivers/i2c/busses/i2c-npcm7xx.c @@ -683,7 +683,7 @@ static void npcm_i2c_reset(struct npcm_i2c *bus) } #endif - /* clear status bits for spurious interrupts */ + /* Clear status bits for spurious interrupts */ npcm_i2c_clear_master_status(bus); bus->state = I2C_IDLE; @@ -1255,7 +1255,7 @@ static irqreturn_t npcm_i2c_int_slave_handler(struct npcm_i2c *bus) } /* SDAST */ /* - * if irq is not one of the above, make sure EOB is disabled and all + * If irq is not one of the above, make sure EOB is disabled and all * status bits are cleared. */ if (ret == IRQ_NONE) { @@ -1509,7 +1509,7 @@ static void npcm_i2c_irq_handle_nack(struct npcm_i2c *bus) npcm_i2c_clear_master_status(bus); readx_poll_timeout_atomic(ioread8, bus->reg + NPCM_I2CCST, val, !(val & NPCM_I2CCST_BUSY), 10, 200); - /* verify no status bits are still set after bus is released */ + /* Verify no status bits are still set after bus is released */ npcm_i2c_clear_master_status(bus); } bus->state = I2C_IDLE; @@ -1977,7 +1977,7 @@ static int npcm_i2c_init_module(struct npcm_i2c *bus, enum i2c_mode mode, npcm_i2c_reset(bus); - /* check HW is OK: SDA and SCL should be high at this point. */ + /* Check HW is OK: SDA and SCL should be high at this point. */ if ((npcm_i2c_get_SDA(&bus->adap) == 0) || (npcm_i2c_get_SCL(&bus->adap) == 0)) { dev_err(bus->dev, "I2C%d init fail: lines are low\n", bus->num); dev_err(bus->dev, "SDA=%d SCL=%d\n", npcm_i2c_get_SDA(&bus->adap), @@ -2037,7 +2037,7 @@ static irqreturn_t npcm_i2c_bus_irq(int irq, void *dev_id) return IRQ_HANDLED; } #endif - /* clear status bits for spurious interrupts */ + /* Clear status bits for spurious interrupts */ npcm_i2c_clear_master_status(bus); return IRQ_HANDLED; @@ -2219,7 +2219,7 @@ static int npcm_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, (bus->data->rxf_ctl_last_pec & ioread8(bus->reg + NPCM_I2CRXF_CTL))) npcm_i2c_reset(bus); - /* after any xfer, successful or not, stall and EOB must be disabled */ + /* After any xfer, successful or not, stall and EOB must be disabled */ npcm_i2c_stall_after_start(bus, false); npcm_i2c_eob_int(bus, false); -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Tyrone Ting <warp5tw@gmail.com> To: avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, wsa@kernel.org, andriy.shevchenko@linux.intel.com, jarkko.nikula@linux.intel.com, semen.protsenko@linaro.org, rafal@milecki.pl, sven@svenpeter.dev, jsd@semihalf.com, jie.deng@intel.com, lukas.bulwahn@gmail.com, arnd@arndb.de, olof@lixom.net, warp5tw@gmail.com, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com Cc: devicetree@vger.kernel.org, openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 10/10] i2c: npcm: Capitalize the one-line comment Date: Tue, 17 May 2022 18:11:42 +0800 [thread overview] Message-ID: <20220517101142.28421-11-warp5tw@gmail.com> (raw) In-Reply-To: <20220517101142.28421-1-warp5tw@gmail.com> From: Tyrone Ting <kfting@nuvoton.com> Make the one-line comments capital in the driver to get the comment style consistent. Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver") Signed-off-by: Tyrone Ting <kfting@nuvoton.com> --- drivers/i2c/busses/i2c-npcm7xx.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c index a032b407f104..a60e392dda50 100644 --- a/drivers/i2c/busses/i2c-npcm7xx.c +++ b/drivers/i2c/busses/i2c-npcm7xx.c @@ -683,7 +683,7 @@ static void npcm_i2c_reset(struct npcm_i2c *bus) } #endif - /* clear status bits for spurious interrupts */ + /* Clear status bits for spurious interrupts */ npcm_i2c_clear_master_status(bus); bus->state = I2C_IDLE; @@ -1255,7 +1255,7 @@ static irqreturn_t npcm_i2c_int_slave_handler(struct npcm_i2c *bus) } /* SDAST */ /* - * if irq is not one of the above, make sure EOB is disabled and all + * If irq is not one of the above, make sure EOB is disabled and all * status bits are cleared. */ if (ret == IRQ_NONE) { @@ -1509,7 +1509,7 @@ static void npcm_i2c_irq_handle_nack(struct npcm_i2c *bus) npcm_i2c_clear_master_status(bus); readx_poll_timeout_atomic(ioread8, bus->reg + NPCM_I2CCST, val, !(val & NPCM_I2CCST_BUSY), 10, 200); - /* verify no status bits are still set after bus is released */ + /* Verify no status bits are still set after bus is released */ npcm_i2c_clear_master_status(bus); } bus->state = I2C_IDLE; @@ -1977,7 +1977,7 @@ static int npcm_i2c_init_module(struct npcm_i2c *bus, enum i2c_mode mode, npcm_i2c_reset(bus); - /* check HW is OK: SDA and SCL should be high at this point. */ + /* Check HW is OK: SDA and SCL should be high at this point. */ if ((npcm_i2c_get_SDA(&bus->adap) == 0) || (npcm_i2c_get_SCL(&bus->adap) == 0)) { dev_err(bus->dev, "I2C%d init fail: lines are low\n", bus->num); dev_err(bus->dev, "SDA=%d SCL=%d\n", npcm_i2c_get_SDA(&bus->adap), @@ -2037,7 +2037,7 @@ static irqreturn_t npcm_i2c_bus_irq(int irq, void *dev_id) return IRQ_HANDLED; } #endif - /* clear status bits for spurious interrupts */ + /* Clear status bits for spurious interrupts */ npcm_i2c_clear_master_status(bus); return IRQ_HANDLED; @@ -2219,7 +2219,7 @@ static int npcm_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, (bus->data->rxf_ctl_last_pec & ioread8(bus->reg + NPCM_I2CRXF_CTL))) npcm_i2c_reset(bus); - /* after any xfer, successful or not, stall and EOB must be disabled */ + /* After any xfer, successful or not, stall and EOB must be disabled */ npcm_i2c_stall_after_start(bus, false); npcm_i2c_eob_int(bus, false); -- 2.17.1
next prev parent reply other threads:[~2022-05-17 10:15 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-17 10:11 [PATCH v5 00/10] i2c: npcm: Bug fixes timeout, spurious interrupts Tyrone Ting 2022-05-17 10:11 ` Tyrone Ting 2022-05-17 10:11 ` [PATCH v5 01/10] dt-bindings: i2c: npcm: support NPCM845 Tyrone Ting 2022-05-17 10:11 ` Tyrone Ting 2022-05-21 6:03 ` Wolfram Sang 2022-05-21 6:03 ` Wolfram Sang 2022-05-21 12:30 ` Tyrone Ting 2022-05-17 10:11 ` [PATCH v5 02/10] i2c: npcm: Change the way of getting GCR regmap Tyrone Ting 2022-05-17 10:11 ` Tyrone Ting 2022-05-21 5:51 ` Wolfram Sang 2022-05-21 5:51 ` Wolfram Sang 2022-05-21 12:36 ` Tyrone Ting 2022-05-17 10:11 ` [PATCH v5 03/10] i2c: npcm: Remove unused variable clk_regmap Tyrone Ting 2022-05-17 10:11 ` Tyrone Ting 2022-05-21 5:51 ` Wolfram Sang 2022-05-21 5:51 ` Wolfram Sang 2022-05-21 12:53 ` Tyrone Ting 2022-05-17 10:11 ` [PATCH v5 04/10] i2c: npcm: Fix timeout calculation Tyrone Ting 2022-05-17 10:11 ` Tyrone Ting 2022-05-21 5:52 ` Wolfram Sang 2022-05-21 5:52 ` Wolfram Sang 2022-05-21 12:55 ` Tyrone Ting 2022-05-17 10:11 ` [PATCH v5 05/10] i2c: npcm: Add tx complete counter Tyrone Ting 2022-05-17 10:11 ` Tyrone Ting 2022-05-21 5:52 ` Wolfram Sang 2022-05-21 5:52 ` Wolfram Sang 2022-05-21 12:57 ` Tyrone Ting 2022-05-17 10:11 ` [PATCH v5 06/10] i2c: npcm: Correct register access width Tyrone Ting 2022-05-17 10:11 ` Tyrone Ting 2022-05-21 5:53 ` Wolfram Sang 2022-05-21 5:53 ` Wolfram Sang 2022-05-21 12:58 ` Tyrone Ting 2022-05-17 10:11 ` [PATCH v5 07/10] i2c: npcm: Handle spurious interrupts Tyrone Ting 2022-05-17 10:11 ` Tyrone Ting 2022-05-21 5:53 ` Wolfram Sang 2022-05-21 5:53 ` Wolfram Sang 2022-05-21 13:00 ` Tyrone Ting 2022-05-17 10:11 ` [PATCH v5 08/10] i2c: npcm: Remove own slave addresses 2:10 Tyrone Ting 2022-05-17 10:11 ` Tyrone Ting 2022-05-21 5:58 ` Wolfram Sang 2022-05-21 5:58 ` Wolfram Sang 2022-05-22 6:56 ` Tali Perry 2022-05-22 20:09 ` Wolfram Sang 2022-05-22 20:09 ` Wolfram Sang 2022-05-17 10:11 ` [PATCH v5 09/10] i2c: npcm: Support NPCM845 Tyrone Ting 2022-05-17 10:11 ` Tyrone Ting 2022-05-21 6:00 ` Wolfram Sang 2022-05-21 6:00 ` Wolfram Sang 2022-05-21 13:10 ` Tyrone Ting 2022-05-22 21:21 ` Tomer Maimon 2022-05-17 10:11 ` Tyrone Ting [this message] 2022-05-17 10:11 ` [PATCH v5 10/10] i2c: npcm: Capitalize the one-line comment Tyrone Ting 2022-05-21 6:03 ` Wolfram Sang 2022-05-21 6:03 ` Wolfram Sang 2022-05-21 13:22 ` Tyrone Ting
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220517101142.28421-11-warp5tw@gmail.com \ --to=warp5tw@gmail.com \ --cc=Avi.Fishman@nuvoton.com \ --cc=JJLIU0@nuvoton.com \ --cc=KWLIU@nuvoton.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=arnd@arndb.de \ --cc=avifishman70@gmail.com \ --cc=benjaminfair@google.com \ --cc=devicetree@vger.kernel.org \ --cc=jarkko.nikula@linux.intel.com \ --cc=jie.deng@intel.com \ --cc=jsd@semihalf.com \ --cc=kfting@nuvoton.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lukas.bulwahn@gmail.com \ --cc=olof@lixom.net \ --cc=openbmc@lists.ozlabs.org \ --cc=rafal@milecki.pl \ --cc=robh+dt@kernel.org \ --cc=semen.protsenko@linaro.org \ --cc=sven@svenpeter.dev \ --cc=tali.perry1@gmail.com \ --cc=tali.perry@nuvoton.com \ --cc=tmaimon77@gmail.com \ --cc=tomer.maimon@nuvoton.com \ --cc=venture@google.com \ --cc=wsa@kernel.org \ --cc=yuenn@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.