From: Juerg Haefliger <juerg.haefliger@canonical.com> To: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Juerg Haefliger <juergh@canonical.com> Subject: [PATCH 1/3] ARM: Kconfig: Fix indentation and add comments Date: Tue, 17 May 2022 16:14:22 +0200 [thread overview] Message-ID: <20220517141424.331759-2-juergh@canonical.com> (raw) In-Reply-To: <20220517141424.331759-1-juergh@canonical.com> The convention for indentation seems to be a single tab. Help text is further indented by an additional two whitespaces. Fix the lines that violate these rules. While add it, add trailing comments to endif and endmenu statements for better readability. Signed-off-by: Juerg Haefliger <juergh@canonical.com> --- arch/arm/Kconfig | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 2e8091e2d8a8..912716c99c82 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -181,7 +181,7 @@ config ARM_DMA_IOMMU_ALIGNMENT specified order. The order is expressed as a power of two multiplied by the PAGE_SIZE. -endif +endif # ARM_DMA_USE_IOMMU config SYS_SUPPORTS_APM_EMULATION bool @@ -549,7 +549,7 @@ config ARCH_MULTI_CPU_AUTO def_bool !(ARCH_MULTI_V4 || ARCH_MULTI_V4T || ARCH_MULTI_V6_V7) select ARCH_MULTI_V5 -endmenu +endmenu # "Multiple platform selection" config ARCH_VIRT bool "Dummy Virtual Machine" @@ -771,7 +771,7 @@ config IWMMXT if !MMU source "arch/arm/Kconfig-nommu" -endif +endif # !MMU config PJ4B_ERRATA_4742 bool "PJ4B Errata 4742: IDLE Wake Up Commands can Cause the CPU Core to Cease Operation" @@ -973,14 +973,14 @@ config ARM_ERRATA_764369 in the diagnostic control register of the SCU. config ARM_ERRATA_775420 - bool "ARM errata: A data cache maintenance operation which aborts, might lead to deadlock" - depends on CPU_V7 - help - This option enables the workaround for the 775420 Cortex-A9 (r2p2, - r2p6,r2p8,r2p10,r3p0) erratum. In case a data cache maintenance - operation aborts with MMU exception, it might cause the processor - to deadlock. This workaround puts DSB before executing ISB if - an abort may occur on cache maintenance. + bool "ARM errata: A data cache maintenance operation which aborts, might lead to deadlock" + depends on CPU_V7 + help + This option enables the workaround for the 775420 Cortex-A9 (r2p2, + r2p6,r2p8,r2p10,r3p0) erratum. In case a data cache maintenance + operation aborts with MMU exception, it might cause the processor + to deadlock. This workaround puts DSB before executing ISB if + an abort may occur on cache maintenance. config ARM_ERRATA_798181 bool "ARM errata: TLBI/DSB failure on Cortex-A15" @@ -1073,7 +1073,7 @@ config ARM_ERRATA_857272 config option from the A12 erratum due to the way errata are checked for and handled. -endmenu +endmenu # "System Type" source "arch/arm/common/Kconfig" @@ -1115,7 +1115,7 @@ config ARM_ERRATA_814220 This ERRATA only affected the Cortex-A7 and present in r0p2, r0p3, r0p4, r0p5. -endmenu +endmenu # "Bus support" menu "Kernel Features" @@ -1631,7 +1631,7 @@ config STACKPROTECTOR_PER_TASK Enable this option to switch to a different method that uses a different canary value for each task. -endmenu +endmenu # "Kernel Features" menu "Boot options" @@ -1903,7 +1903,7 @@ config DMI firmware need to be enabled. This would require the DMI subsystem to be enabled much earlier than we do on ARM, which is non-trivial. -endmenu +endmenu # "Boot options" menu "CPU Power Management" @@ -1911,7 +1911,7 @@ source "drivers/cpufreq/Kconfig" source "drivers/cpuidle/Kconfig" -endmenu +endmenu # "CPU Power Management" menu "Floating point emulation" @@ -1985,7 +1985,7 @@ config KERNEL_MODE_NEON help Say Y to include support for NEON in kernel mode. -endmenu +endmenu # "Floating point emulation" menu "Power management options" @@ -2005,10 +2005,10 @@ config ARCH_HIBERNATION_POSSIBLE depends on MMU default y if ARCH_SUSPEND_POSSIBLE -endmenu +endmenu # "Power management options" if CRYPTO source "arch/arm/crypto/Kconfig" -endif +endif # CRYPTO source "arch/arm/Kconfig.assembler" -- 2.32.0
WARNING: multiple messages have this Message-ID (diff)
From: Juerg Haefliger <juerg.haefliger@canonical.com> To: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Juerg Haefliger <juergh@canonical.com> Subject: [PATCH 1/3] ARM: Kconfig: Fix indentation and add comments Date: Tue, 17 May 2022 16:14:22 +0200 [thread overview] Message-ID: <20220517141424.331759-2-juergh@canonical.com> (raw) In-Reply-To: <20220517141424.331759-1-juergh@canonical.com> The convention for indentation seems to be a single tab. Help text is further indented by an additional two whitespaces. Fix the lines that violate these rules. While add it, add trailing comments to endif and endmenu statements for better readability. Signed-off-by: Juerg Haefliger <juergh@canonical.com> --- arch/arm/Kconfig | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 2e8091e2d8a8..912716c99c82 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -181,7 +181,7 @@ config ARM_DMA_IOMMU_ALIGNMENT specified order. The order is expressed as a power of two multiplied by the PAGE_SIZE. -endif +endif # ARM_DMA_USE_IOMMU config SYS_SUPPORTS_APM_EMULATION bool @@ -549,7 +549,7 @@ config ARCH_MULTI_CPU_AUTO def_bool !(ARCH_MULTI_V4 || ARCH_MULTI_V4T || ARCH_MULTI_V6_V7) select ARCH_MULTI_V5 -endmenu +endmenu # "Multiple platform selection" config ARCH_VIRT bool "Dummy Virtual Machine" @@ -771,7 +771,7 @@ config IWMMXT if !MMU source "arch/arm/Kconfig-nommu" -endif +endif # !MMU config PJ4B_ERRATA_4742 bool "PJ4B Errata 4742: IDLE Wake Up Commands can Cause the CPU Core to Cease Operation" @@ -973,14 +973,14 @@ config ARM_ERRATA_764369 in the diagnostic control register of the SCU. config ARM_ERRATA_775420 - bool "ARM errata: A data cache maintenance operation which aborts, might lead to deadlock" - depends on CPU_V7 - help - This option enables the workaround for the 775420 Cortex-A9 (r2p2, - r2p6,r2p8,r2p10,r3p0) erratum. In case a data cache maintenance - operation aborts with MMU exception, it might cause the processor - to deadlock. This workaround puts DSB before executing ISB if - an abort may occur on cache maintenance. + bool "ARM errata: A data cache maintenance operation which aborts, might lead to deadlock" + depends on CPU_V7 + help + This option enables the workaround for the 775420 Cortex-A9 (r2p2, + r2p6,r2p8,r2p10,r3p0) erratum. In case a data cache maintenance + operation aborts with MMU exception, it might cause the processor + to deadlock. This workaround puts DSB before executing ISB if + an abort may occur on cache maintenance. config ARM_ERRATA_798181 bool "ARM errata: TLBI/DSB failure on Cortex-A15" @@ -1073,7 +1073,7 @@ config ARM_ERRATA_857272 config option from the A12 erratum due to the way errata are checked for and handled. -endmenu +endmenu # "System Type" source "arch/arm/common/Kconfig" @@ -1115,7 +1115,7 @@ config ARM_ERRATA_814220 This ERRATA only affected the Cortex-A7 and present in r0p2, r0p3, r0p4, r0p5. -endmenu +endmenu # "Bus support" menu "Kernel Features" @@ -1631,7 +1631,7 @@ config STACKPROTECTOR_PER_TASK Enable this option to switch to a different method that uses a different canary value for each task. -endmenu +endmenu # "Kernel Features" menu "Boot options" @@ -1903,7 +1903,7 @@ config DMI firmware need to be enabled. This would require the DMI subsystem to be enabled much earlier than we do on ARM, which is non-trivial. -endmenu +endmenu # "Boot options" menu "CPU Power Management" @@ -1911,7 +1911,7 @@ source "drivers/cpufreq/Kconfig" source "drivers/cpuidle/Kconfig" -endmenu +endmenu # "CPU Power Management" menu "Floating point emulation" @@ -1985,7 +1985,7 @@ config KERNEL_MODE_NEON help Say Y to include support for NEON in kernel mode. -endmenu +endmenu # "Floating point emulation" menu "Power management options" @@ -2005,10 +2005,10 @@ config ARCH_HIBERNATION_POSSIBLE depends on MMU default y if ARCH_SUSPEND_POSSIBLE -endmenu +endmenu # "Power management options" if CRYPTO source "arch/arm/crypto/Kconfig" -endif +endif # CRYPTO source "arch/arm/Kconfig.assembler" -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-17 14:14 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-17 14:14 [PATCH 0/3] ARM: Kconfig: Style cleanups Juerg Haefliger 2022-05-17 14:14 ` Juerg Haefliger 2022-05-17 14:14 ` Juerg Haefliger [this message] 2022-05-17 14:14 ` [PATCH 1/3] ARM: Kconfig: Fix indentation and add comments Juerg Haefliger 2022-05-17 14:33 ` Russell King (Oracle) 2022-05-17 14:33 ` Russell King (Oracle) 2022-05-18 6:43 ` [PATCH v2 1/3] ARM: Kconfig: Fix indentation Juerg Haefliger 2022-05-18 6:43 ` Juerg Haefliger 2022-05-17 14:14 ` [PATCH 2/3] ARM: Kconfig-nommu: Fix indentation and quotes Juerg Haefliger 2022-05-17 14:14 ` Juerg Haefliger 2022-05-17 14:14 ` [PATCH 3/3] ARM: Kconfig.debug: Fix indentation Juerg Haefliger 2022-05-17 14:14 ` Juerg Haefliger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220517141424.331759-2-juergh@canonical.com \ --to=juerg.haefliger@canonical.com \ --cc=juergh@canonical.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.