Re: [PATCH 5/6] dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'

From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	matthias.bgg@gmail.com, sboyd@kernel.org,
	chun-jie.chen@mediatek.com, rex-bc.chen@mediatek.com,
	wenst@chromium.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
Date: Tue, 17 May 2022 11:04:13 -0400	[thread overview]
Message-ID: <20220517150413.pnhbvzz2upcmjebi@notapiano> (raw)
In-Reply-To: <20220517101514.21639-6-angelogioacchino.delregno@collabora.com>

On Tue, May 17, 2022 at 12:15:13PM +0200, AngeloGioacchino Del Regno wrote:
> There's no need for 'items' when there's only one item.
> 
> Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  .../arm/mediatek/mediatek,mt8192-clock.yaml   | 45 +++++++++----------
>  1 file changed, 22 insertions(+), 23 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> index c8c67c033f8c..bb410b178f33 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> @@ -14,29 +14,28 @@ description:
>  
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -          - mediatek,mt8192-scp_adsp
> -          - mediatek,mt8192-imp_iic_wrap_c
> -          - mediatek,mt8192-imp_iic_wrap_e
> -          - mediatek,mt8192-imp_iic_wrap_s
> -          - mediatek,mt8192-imp_iic_wrap_ws
> -          - mediatek,mt8192-imp_iic_wrap_w
> -          - mediatek,mt8192-imp_iic_wrap_n
> -          - mediatek,mt8192-msdc_top
> -          - mediatek,mt8192-msdc
> -          - mediatek,mt8192-mfgcfg
> -          - mediatek,mt8192-imgsys
> -          - mediatek,mt8192-imgsys2
> -          - mediatek,mt8192-vdecsys_soc
> -          - mediatek,mt8192-vdecsys
> -          - mediatek,mt8192-vencsys
> -          - mediatek,mt8192-camsys
> -          - mediatek,mt8192-camsys_rawa
> -          - mediatek,mt8192-camsys_rawb
> -          - mediatek,mt8192-camsys_rawc
> -          - mediatek,mt8192-ipesys
> -          - mediatek,mt8192-mdpsys
> +    enum:
> +      - mediatek,mt8192-scp_adsp
> +      - mediatek,mt8192-imp_iic_wrap_c
> +      - mediatek,mt8192-imp_iic_wrap_e
> +      - mediatek,mt8192-imp_iic_wrap_s
> +      - mediatek,mt8192-imp_iic_wrap_ws
> +      - mediatek,mt8192-imp_iic_wrap_w
> +      - mediatek,mt8192-imp_iic_wrap_n
> +      - mediatek,mt8192-msdc_top
> +      - mediatek,mt8192-msdc
> +      - mediatek,mt8192-mfgcfg
> +      - mediatek,mt8192-imgsys
> +      - mediatek,mt8192-imgsys2
> +      - mediatek,mt8192-vdecsys_soc
> +      - mediatek,mt8192-vdecsys
> +      - mediatek,mt8192-vencsys
> +      - mediatek,mt8192-camsys
> +      - mediatek,mt8192-camsys_rawa
> +      - mediatek,mt8192-camsys_rawb
> +      - mediatek,mt8192-camsys_rawc
> +      - mediatek,mt8192-ipesys
> +      - mediatek,mt8192-mdpsys

This will conflict with the patch removing msdc:

[1] https://lore.kernel.org/all/20220429123133.28869-1-matthias.bgg@kernel.org/

Although if this series is merged before that one, it should be fine.

Thanks,
Nícolas