* [PATCH blktests] srp/011: Avoid $dev becoming invalid during test
@ 2022-05-18 6:44 Xiao Yang
2022-05-18 11:57 ` Bart Van Assche
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Xiao Yang @ 2022-05-18 6:44 UTC (permalink / raw)
To: osandov, yi.zhang, bvanassche; +Cc: linux-block, Xiao Yang
$dev will become invalid when log_out has been done
and fio doesn't run yet. In this case subsequent fio
throws the following error:
-------------------------------------
From diff -u 011.out 011.out.bad
Configured SRP target driver
-Passed
From 011.full:
fio: looks like your file system does not support direct=1/buffered=0
fio: destination does not support O_DIRECT
run_fio exit code: 1
-------------------------------------
This issue happens randomly.
Try to fix the issue by holding $dev before test.
Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
---
tests/srp/011 | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/srp/011 b/tests/srp/011
index 29b2c03..63ff332 100755
--- a/tests/srp/011
+++ b/tests/srp/011
@@ -12,6 +12,8 @@ test_disconnect_repeatedly() {
use_blk_mq y y || return $?
dev=$(get_bdev 0) || return $?
+ # Hold $dev
+ exec 3< "$dev"
simulate_network_failure_loop "$dev" "$TIMEOUT" &
run_fio --verify=md5 --rw=randwrite --bs=4K --loops=10000 \
--ioengine=libaio --iodepth=64 --iodepth_batch=32 \
@@ -22,6 +24,8 @@ test_disconnect_repeatedly() {
>>"$FULL"
fio_status=$?
wait
+ # Release $dev
+ exec 3<&-
log_in
return $fio_status
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH blktests] srp/011: Avoid $dev becoming invalid during test
2022-05-18 6:44 [PATCH blktests] srp/011: Avoid $dev becoming invalid during test Xiao Yang
@ 2022-05-18 11:57 ` Bart Van Assche
2022-05-20 9:24 ` Shinichiro Kawasaki
2022-05-26 7:34 ` Shinichiro Kawasaki
2 siblings, 0 replies; 4+ messages in thread
From: Bart Van Assche @ 2022-05-18 11:57 UTC (permalink / raw)
To: Xiao Yang, osandov, yi.zhang; +Cc: linux-block
On 5/18/22 08:44, Xiao Yang wrote:
> $dev will become invalid when log_out has been done
> and fio doesn't run yet. In this case subsequent fio
> throws the following error:
> -------------------------------------
> From diff -u 011.out 011.out.bad
> Configured SRP target driver
> -Passed
>
> From 011.full:
> fio: looks like your file system does not support direct=1/buffered=0
> fio: destination does not support O_DIRECT
> run_fio exit code: 1
> -------------------------------------
> This issue happens randomly.
>
> Try to fix the issue by holding $dev before test.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH blktests] srp/011: Avoid $dev becoming invalid during test
2022-05-18 6:44 [PATCH blktests] srp/011: Avoid $dev becoming invalid during test Xiao Yang
2022-05-18 11:57 ` Bart Van Assche
@ 2022-05-20 9:24 ` Shinichiro Kawasaki
2022-05-26 7:34 ` Shinichiro Kawasaki
2 siblings, 0 replies; 4+ messages in thread
From: Shinichiro Kawasaki @ 2022-05-20 9:24 UTC (permalink / raw)
To: Xiao Yang; +Cc: osandov, yi.zhang, bvanassche, linux-block
On May 18, 2022 / 14:44, Xiao Yang wrote:
> $dev will become invalid when log_out has been done
> and fio doesn't run yet. In this case subsequent fio
> throws the following error:
> -------------------------------------
> From diff -u 011.out 011.out.bad
> Configured SRP target driver
> -Passed
>
> From 011.full:
> fio: looks like your file system does not support direct=1/buffered=0
> fio: destination does not support O_DIRECT
> run_fio exit code: 1
> -------------------------------------
> This issue happens randomly.
>
> Try to fix the issue by holding $dev before test.
>
> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
Looks good to me.
Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
--
Best Regards,
Shin'ichiro Kawasaki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH blktests] srp/011: Avoid $dev becoming invalid during test
2022-05-18 6:44 [PATCH blktests] srp/011: Avoid $dev becoming invalid during test Xiao Yang
2022-05-18 11:57 ` Bart Van Assche
2022-05-20 9:24 ` Shinichiro Kawasaki
@ 2022-05-26 7:34 ` Shinichiro Kawasaki
2 siblings, 0 replies; 4+ messages in thread
From: Shinichiro Kawasaki @ 2022-05-26 7:34 UTC (permalink / raw)
To: Xiao Yang; +Cc: osandov, yi.zhang, bvanassche, linux-block
On May 18, 2022 / 14:44, Xiao Yang wrote:
> $dev will become invalid when log_out has been done
> and fio doesn't run yet. In this case subsequent fio
> throws the following error:
> -------------------------------------
> From diff -u 011.out 011.out.bad
> Configured SRP target driver
> -Passed
>
> From 011.full:
> fio: looks like your file system does not support direct=1/buffered=0
> fio: destination does not support O_DIRECT
> run_fio exit code: 1
> -------------------------------------
> This issue happens randomly.
>
> Try to fix the issue by holding $dev before test.
>
> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
Thanks, applied.
--
Shin'ichiro Kawasaki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-26 7:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-18 6:44 [PATCH blktests] srp/011: Avoid $dev becoming invalid during test Xiao Yang
2022-05-18 11:57 ` Bart Van Assche
2022-05-20 9:24 ` Shinichiro Kawasaki
2022-05-26 7:34 ` Shinichiro Kawasaki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.