All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francesco Dolcini <francesco.dolcini@toradex.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	l.stach@pengutronix.de, linux-pm@vger.kernel.org,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Amit Kucheria <amitk@kernel.org>,
	Jon Nettleton <jon@solid-run.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Tim Harvey <tharvey@gateworks.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] thermal: imx: Make trip point offset configurable
Date: Wed, 18 May 2022 11:49:16 +0200	[thread overview]
Message-ID: <20220518094916.GA27037@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <20220518085522.3fpzy37kkbkn4hpl@pengutronix.de>

Hello Marco,

On Wed, May 18, 2022 at 10:55:22AM +0200, Marco Felsch wrote:
> On 22-05-16, Francesco Dolcini wrote:
> > Currently the imx thermal driver has a hardcoded critical temperature
> > value offset of 5 Celsius degrees from the actual SoC maximum
> > temperature.
> > 
> > This affects applications and systems designed to be working on this close
> > to the limit, but yet valid, temperature range.
> > 
> > Given that there is no single value that will fit all the use cases make
> > the critical trip point offset from the max temperature configurable
> > using a newly added trip_offset module parameter, passive trip point is
> > set to 5 Celsius degrees less than the critical. By default the
> > system behaves exactly as before.
> 
> I thought the conclusion of the discussion was to use a dt-property?
> Since it is device and/or environment specific.

Daniel proposed to use a module parameter [0], but if you prefer a
dt-property I can change this. I would keep the same semantic (offset
from max temperature to compute the critical trip point).

[0] https://lore.kernel.org/all/7f5a919c-2fa1-a463-1f6b-6b531d5ee27d@linaro.org/

Francesco


WARNING: multiple messages have this Message-ID (diff)
From: Francesco Dolcini <francesco.dolcini@toradex.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	l.stach@pengutronix.de, linux-pm@vger.kernel.org,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Amit Kucheria <amitk@kernel.org>,
	Jon Nettleton <jon@solid-run.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Tim Harvey <tharvey@gateworks.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] thermal: imx: Make trip point offset configurable
Date: Wed, 18 May 2022 11:49:16 +0200	[thread overview]
Message-ID: <20220518094916.GA27037@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <20220518085522.3fpzy37kkbkn4hpl@pengutronix.de>

Hello Marco,

On Wed, May 18, 2022 at 10:55:22AM +0200, Marco Felsch wrote:
> On 22-05-16, Francesco Dolcini wrote:
> > Currently the imx thermal driver has a hardcoded critical temperature
> > value offset of 5 Celsius degrees from the actual SoC maximum
> > temperature.
> > 
> > This affects applications and systems designed to be working on this close
> > to the limit, but yet valid, temperature range.
> > 
> > Given that there is no single value that will fit all the use cases make
> > the critical trip point offset from the max temperature configurable
> > using a newly added trip_offset module parameter, passive trip point is
> > set to 5 Celsius degrees less than the critical. By default the
> > system behaves exactly as before.
> 
> I thought the conclusion of the discussion was to use a dt-property?
> Since it is device and/or environment specific.

Daniel proposed to use a module parameter [0], but if you prefer a
dt-property I can change this. I would keep the same semantic (offset
from max temperature to compute the critical trip point).

[0] https://lore.kernel.org/all/7f5a919c-2fa1-a463-1f6b-6b531d5ee27d@linaro.org/

Francesco


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-18  9:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16 19:00 [PATCH v1] thermal: imx: Make trip point offset configurable Francesco Dolcini
2022-05-16 19:00 ` Francesco Dolcini
2022-05-16 19:06 ` Ahmad Fatoum
2022-05-16 19:06   ` Ahmad Fatoum
2022-05-16 19:16   ` Francesco Dolcini
2022-05-16 19:16     ` Francesco Dolcini
2022-05-17  4:36     ` Ahmad Fatoum
2022-05-17  4:36       ` Ahmad Fatoum
2022-05-17 15:29 ` Francesco Dolcini
2022-05-17 15:29   ` Francesco Dolcini
2022-05-18  8:55 ` Marco Felsch
2022-05-18  8:55   ` Marco Felsch
2022-05-18  9:49   ` Francesco Dolcini [this message]
2022-05-18  9:49     ` Francesco Dolcini
2022-05-18 10:10     ` Daniel Lezcano
2022-05-18 10:10       ` Daniel Lezcano
2022-05-23 14:35       ` Francesco Dolcini
2022-05-23 14:35         ` Francesco Dolcini
2022-05-24  8:35         ` Marco Felsch
2022-05-24  8:35           ` Marco Felsch
2022-05-24 10:07           ` Francesco Dolcini
2022-05-24 10:07             ` Francesco Dolcini
2022-05-24 13:17             ` Daniel Lezcano
2022-05-24 13:17               ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220518094916.GA27037@francesco-nb.int.toradex.com \
    --to=francesco.dolcini@toradex.com \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=festevam@gmail.com \
    --cc=jon@solid-run.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=rafael@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=tharvey@gateworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.