From: Heiko Stuebner <heiko@sntech.de> To: palmer@dabbelt.com, paul.walmsley@sifive.com Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, wefu@redhat.com, guoren@kernel.org, mick@ics.forth.gr, samuel@sholland.org, cmuellner@linux.com, philipp.tomsich@vrull.eu, hch@lst.de, Heiko Stuebner <heiko@sntech.de>, kernel test robot <lkp@intel.com> Subject: [PATCH 1/4] riscv: drop cpufeature_apply_feature tracking variable Date: Wed, 18 May 2022 19:02:51 +0200 [thread overview] Message-ID: <20220518170254.3178923-2-heiko@sntech.de> (raw) In-Reply-To: <20220518170254.3178923-1-heiko@sntech.de> The variable was tracking which feature patches got applied but that information was never actually used - and thus resulted in a warning as well. Drop the variable. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- arch/riscv/kernel/cpufeature.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c index dea3ea19deee..b33564df81e1 100644 --- a/arch/riscv/kernel/cpufeature.c +++ b/arch/riscv/kernel/cpufeature.c @@ -294,7 +294,6 @@ void __init_or_module riscv_cpufeature_patch_func(struct alt_entry *begin, unsigned int stage) { u32 cpu_req_feature = cpufeature_probe(stage); - u32 cpu_apply_feature = 0; struct alt_entry *alt; u32 tmp; @@ -308,10 +307,8 @@ void __init_or_module riscv_cpufeature_patch_func(struct alt_entry *begin, } tmp = (1U << alt->errata_id); - if (cpu_req_feature & tmp) { + if (cpu_req_feature & tmp) patch_text_nosync(alt->old_ptr, alt->alt_ptr, alt->alt_len); - cpu_apply_feature |= tmp; - } } } #endif -- 2.35.1
WARNING: multiple messages have this Message-ID
From: Heiko Stuebner <heiko@sntech.de> To: palmer@dabbelt.com, paul.walmsley@sifive.com Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, wefu@redhat.com, guoren@kernel.org, mick@ics.forth.gr, samuel@sholland.org, cmuellner@linux.com, philipp.tomsich@vrull.eu, hch@lst.de, Heiko Stuebner <heiko@sntech.de>, kernel test robot <lkp@intel.com> Subject: [PATCH 1/4] riscv: drop cpufeature_apply_feature tracking variable Date: Wed, 18 May 2022 19:02:51 +0200 [thread overview] Message-ID: <20220518170254.3178923-2-heiko@sntech.de> (raw) In-Reply-To: <20220518170254.3178923-1-heiko@sntech.de> The variable was tracking which feature patches got applied but that information was never actually used - and thus resulted in a warning as well. Drop the variable. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- arch/riscv/kernel/cpufeature.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c index dea3ea19deee..b33564df81e1 100644 --- a/arch/riscv/kernel/cpufeature.c +++ b/arch/riscv/kernel/cpufeature.c @@ -294,7 +294,6 @@ void __init_or_module riscv_cpufeature_patch_func(struct alt_entry *begin, unsigned int stage) { u32 cpu_req_feature = cpufeature_probe(stage); - u32 cpu_apply_feature = 0; struct alt_entry *alt; u32 tmp; @@ -308,10 +307,8 @@ void __init_or_module riscv_cpufeature_patch_func(struct alt_entry *begin, } tmp = (1U << alt->errata_id); - if (cpu_req_feature & tmp) { + if (cpu_req_feature & tmp) patch_text_nosync(alt->old_ptr, alt->alt_ptr, alt->alt_len); - cpu_apply_feature |= tmp; - } } } #endif -- 2.35.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-05-18 17:03 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-18 17:02 [PATCH 0/4] riscv: some svpbmt fixes Heiko Stuebner 2022-05-18 17:02 ` Heiko Stuebner 2022-05-18 17:02 ` Heiko Stuebner [this message] 2022-05-18 17:02 ` [PATCH 1/4] riscv: drop cpufeature_apply_feature tracking variable Heiko Stuebner 2022-05-18 17:02 ` [PATCH 2/4] riscv: Improve description for RISCV_ISA_SVPBMT Kconfig symbol Heiko Stuebner 2022-05-18 17:02 ` Heiko Stuebner 2022-05-18 17:02 ` [PATCH 3/4] riscv: make patch-function pointer more generic in cpu_manufacturer_info struct Heiko Stuebner 2022-05-18 17:02 ` Heiko Stuebner 2022-05-18 17:02 ` [PATCH 4/4] riscv: fix dependency for t-head errata Heiko Stuebner 2022-05-18 17:02 ` Heiko Stuebner 2022-05-20 7:55 ` Guo Ren 2022-05-20 7:55 ` Guo Ren 2022-05-26 20:58 ` [PATCH 0/4] riscv: some svpbmt fixes Heiko Stübner 2022-05-26 20:58 ` Heiko Stübner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220518170254.3178923-2-heiko@sntech.de \ --to=heiko@sntech.de \ --cc=cmuellner@linux.com \ --cc=guoren@kernel.org \ --cc=hch@lst.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=lkp@intel.com \ --cc=mick@ics.forth.gr \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=philipp.tomsich@vrull.eu \ --cc=samuel@sholland.org \ --cc=wefu@redhat.com \ --subject='Re: [PATCH 1/4] riscv: drop cpufeature_apply_feature tracking variable' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.