All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@fb.com>
To: <linux-fsdevel@vger.kernel.org>, <linux-block@vger.kernel.org>
Cc: <axboe@kernel.dk>, Kernel Team <Kernel-team@fb.com>, <hch@lst.de>,
	<bvanassche@acm.org>, <damien.lemoal@opensource.wdc.com>,
	Keith Busch <kbusch@kernel.org>
Subject: [PATCHv2 2/3] block: export dma_alignment attribute
Date: Wed, 18 May 2022 10:11:30 -0700	[thread overview]
Message-ID: <20220518171131.3525293-3-kbusch@fb.com> (raw)
In-Reply-To: <20220518171131.3525293-1-kbusch@fb.com>

From: Keith Busch <kbusch@kernel.org>

User space may want to know how to align their buffers to avoid
bouncing. Export the queue attribute.

Signed-off-by: Keith Busch <kbusch@kernel.org>
---
 block/blk-sysfs.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
index 88bd41d4cb59..14607565d781 100644
--- a/block/blk-sysfs.c
+++ b/block/blk-sysfs.c
@@ -274,6 +274,11 @@ static ssize_t queue_virt_boundary_mask_show(struct request_queue *q, char *page
 	return queue_var_show(q->limits.virt_boundary_mask, page);
 }
 
+static ssize_t queue_dma_alignment_show(struct request_queue *q, char *page)
+{
+	return queue_var_show(queue_dma_alignment(q), page);
+}
+
 #define QUEUE_SYSFS_BIT_FNS(name, flag, neg)				\
 static ssize_t								\
 queue_##name##_show(struct request_queue *q, char *page)		\
@@ -606,6 +611,7 @@ QUEUE_RO_ENTRY(queue_dax, "dax");
 QUEUE_RW_ENTRY(queue_io_timeout, "io_timeout");
 QUEUE_RW_ENTRY(queue_wb_lat, "wbt_lat_usec");
 QUEUE_RO_ENTRY(queue_virt_boundary_mask, "virt_boundary_mask");
+QUEUE_RO_ENTRY(queue_dma_alignment, "dma_alignment");
 
 #ifdef CONFIG_BLK_DEV_THROTTLING_LOW
 QUEUE_RW_ENTRY(blk_throtl_sample_time, "throttle_sample_time");
@@ -667,6 +673,7 @@ static struct attribute *queue_attrs[] = {
 	&blk_throtl_sample_time_entry.attr,
 #endif
 	&queue_virt_boundary_mask_entry.attr,
+	&queue_dma_alignment_entry.attr,
 	NULL,
 };
 
-- 
2.30.2


  parent reply	other threads:[~2022-05-18 17:11 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18 17:11 [PATCHv2 0/3] direct io alignment relax Keith Busch
2022-05-18 17:11 ` [PATCHv2 1/3] block/bio: remove duplicate append pages code Keith Busch
2022-05-18 20:21   ` Chaitanya Kulkarni
2022-05-19  4:28   ` Bart Van Assche
2022-05-19  7:32   ` Christoph Hellwig
2022-05-19 14:19     ` Keith Busch
2022-05-18 17:11 ` Keith Busch [this message]
2022-05-18 20:22   ` [PATCHv2 2/3] block: export dma_alignment attribute Chaitanya Kulkarni
2022-05-19  4:30   ` Bart Van Assche
2022-05-19  7:33   ` Christoph Hellwig
2022-05-18 17:11 ` [PATCHv2 3/3] block: relax direct io memory alignment Keith Busch
2022-05-19  0:14   ` Eric Biggers
2022-05-19  1:00     ` Keith Busch
2022-05-19  1:53       ` Eric Biggers
2022-05-19  1:59         ` Keith Busch
2022-05-19  2:08           ` Eric Biggers
2022-05-19  2:25             ` Keith Busch
2022-05-19  3:27               ` Eric Biggers
2022-05-19  4:40                 ` Bart Van Assche
2022-05-19  4:56                 ` Keith Busch
2022-05-19  6:45                   ` Damien Le Moal
2022-05-19 17:19                     ` Eric Biggers
2022-05-20  3:41                       ` Damien Le Moal
2022-05-19  7:41                   ` Christoph Hellwig
2022-05-19 16:35                     ` Keith Busch
2022-05-20  6:07                       ` Christoph Hellwig
2022-05-19 17:01                   ` Keith Busch
2022-05-19 17:27                     ` Eric Biggers
2022-05-19 17:43                       ` Keith Busch
2022-05-19  7:39       ` Christoph Hellwig
2022-05-19 22:31         ` Keith Busch
2022-05-19  7:38   ` Christoph Hellwig
2022-05-19 14:08     ` Keith Busch
2022-05-20  6:10       ` Christoph Hellwig
2022-05-18 22:45 ` [PATCHv2 0/3] direct io alignment relax Jens Axboe
2022-05-19  7:42   ` Christoph Hellwig
2022-05-19 12:46     ` Jens Axboe
2022-05-18 23:26 ` Eric Biggers
2022-05-19  0:51   ` Keith Busch
2022-05-19  1:02     ` Chaitanya Kulkarni
2022-05-19  2:02       ` Eric Biggers
2022-05-19  7:43         ` hch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220518171131.3525293-3-kbusch@fb.com \
    --to=kbusch@fb.com \
    --cc=Kernel-team@fb.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.