From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Keith Busch <kbusch@kernel.org>, Eric Biggers <ebiggers@kernel.org>
Cc: Keith Busch <kbusch@fb.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
Kernel Team <Kernel-team@fb.com>, "hch@lst.de" <hch@lst.de>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"damien.lemoal@opensource.wdc.com"
<damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCHv2 0/3] direct io alignment relax
Date: Thu, 19 May 2022 01:02:42 +0000 [thread overview]
Message-ID: <f42c74b9-67fa-50fc-d97e-2a7f153f10e4@nvidia.com> (raw)
In-Reply-To: <YoWUnTxag7TsCBwa@kbusch-mbp.dhcp.thefacebook.com>
On 5/18/22 17:51, Keith Busch wrote:
> On Wed, May 18, 2022 at 11:26:20PM +0000, Eric Biggers wrote:
>> On Wed, May 18, 2022 at 10:11:28AM -0700, Keith Busch wrote:
>>> From: Keith Busch <kbusch@kernel.org>
>>>
>>> Including the fs list this time.
>>>
>>> I am still working on a better interface to report the dio alignment to
>>> an application. The most recent suggestion of using statx is proving to
>>> be less straight forward than I thought, but I don't want to hold this
>>> series up for that.
>>>
>>
>> Note that I already implemented the statx support and sent it out for review:
>> https://lore.kernel.org/linux-fsdevel/20220211061158.227688-1-ebiggers@kernel.org/T/#u
>> However, the patch series only received one comment. I can send it out again if
>> people have become interested in it again...
>
> Thanks, I didn't see that the first time around, but I'll be sure to look at
> your new version. It sounds like you encountered the same problem I did
> regarding block device handles: the devtmpfs inodes for the raw block device
> handles are not the bdev inodes. I do think it's useful the alignment
> attributes are accessible through the block device files, though.
Irrespective of above problem, as per my review comment [1] on the
initial version of Eric's series I really want to see the generic
interface that can accommodate exposing optimal values for different
operations REQ_OP_DISCARD/REQ_OP_WRITE_ZEROES/REQ_OP_VERIFY etc.
and not only for read/write.
-ck
https://lore.kernel.org/linux-fsdevel/20220211061158.227688-1-ebiggers@kernel.org/T/#r3ffe9183c372fb97a9753e286f9cf6400e8ec272
next prev parent reply other threads:[~2022-05-19 1:02 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 17:11 [PATCHv2 0/3] direct io alignment relax Keith Busch
2022-05-18 17:11 ` [PATCHv2 1/3] block/bio: remove duplicate append pages code Keith Busch
2022-05-18 20:21 ` Chaitanya Kulkarni
2022-05-19 4:28 ` Bart Van Assche
2022-05-19 7:32 ` Christoph Hellwig
2022-05-19 14:19 ` Keith Busch
2022-05-18 17:11 ` [PATCHv2 2/3] block: export dma_alignment attribute Keith Busch
2022-05-18 20:22 ` Chaitanya Kulkarni
2022-05-19 4:30 ` Bart Van Assche
2022-05-19 7:33 ` Christoph Hellwig
2022-05-18 17:11 ` [PATCHv2 3/3] block: relax direct io memory alignment Keith Busch
2022-05-19 0:14 ` Eric Biggers
2022-05-19 1:00 ` Keith Busch
2022-05-19 1:53 ` Eric Biggers
2022-05-19 1:59 ` Keith Busch
2022-05-19 2:08 ` Eric Biggers
2022-05-19 2:25 ` Keith Busch
2022-05-19 3:27 ` Eric Biggers
2022-05-19 4:40 ` Bart Van Assche
2022-05-19 4:56 ` Keith Busch
2022-05-19 6:45 ` Damien Le Moal
2022-05-19 17:19 ` Eric Biggers
2022-05-20 3:41 ` Damien Le Moal
2022-05-19 7:41 ` Christoph Hellwig
2022-05-19 16:35 ` Keith Busch
2022-05-20 6:07 ` Christoph Hellwig
2022-05-19 17:01 ` Keith Busch
2022-05-19 17:27 ` Eric Biggers
2022-05-19 17:43 ` Keith Busch
2022-05-19 7:39 ` Christoph Hellwig
2022-05-19 22:31 ` Keith Busch
2022-05-19 7:38 ` Christoph Hellwig
2022-05-19 14:08 ` Keith Busch
2022-05-20 6:10 ` Christoph Hellwig
2022-05-18 22:45 ` [PATCHv2 0/3] direct io alignment relax Jens Axboe
2022-05-19 7:42 ` Christoph Hellwig
2022-05-19 12:46 ` Jens Axboe
2022-05-18 23:26 ` Eric Biggers
2022-05-19 0:51 ` Keith Busch
2022-05-19 1:02 ` Chaitanya Kulkarni [this message]
2022-05-19 2:02 ` Eric Biggers
2022-05-19 7:43 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f42c74b9-67fa-50fc-d97e-2a7f153f10e4@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=Kernel-team@fb.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.