From: Sudeep Holla <sudeep.holla@arm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Tushar Khandelwal <Tushar.Khandelwal@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Peng Fan <peng.fan@nxp.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] mailbox: correct kerneldoc
Date: Thu, 19 May 2022 16:19:03 +0100 [thread overview]
Message-ID: <20220519151903.hvqyrw3yib2mb6yg@bogus> (raw)
In-Reply-To: <92a21768-204d-fc68-8942-99e2bc3df4cf@linaro.org>
On Thu, May 19, 2022 at 05:14:33PM +0200, Krzysztof Kozlowski wrote:
> On 19/05/2022 17:13, Sudeep Holla wrote:
> > On Sun, May 01, 2022 at 12:34:27PM +0200, Krzysztof Kozlowski wrote:
> >> Correct kerneldoc warnings like:
> >>
> >> drivers/mailbox/arm_mhu_db.c:47:
> >> warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> >> drivers/mailbox/qcom-ipcc.c:58:
> >> warning: Function parameter or member 'num_chans' not described in 'qcom_ipcc'
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >> drivers/mailbox/arm_mhu_db.c | 2 +-
> >
> > I thought I had copied it from arm_mhuc.c but apparently not. Anyways,
> >
> > Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> >
>
>
> Thanks! Could someone pick these two patches?
>
They generally go via Jassi's tree.
Hi Jassi,
There is another PCC driver fix that I had acked few weeks back. Please
pick this as well as that when you start finalising patches for your PR
for v5.19.
--
Regards,
Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Tushar Khandelwal <Tushar.Khandelwal@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Peng Fan <peng.fan@nxp.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] mailbox: correct kerneldoc
Date: Thu, 19 May 2022 16:19:03 +0100 [thread overview]
Message-ID: <20220519151903.hvqyrw3yib2mb6yg@bogus> (raw)
In-Reply-To: <92a21768-204d-fc68-8942-99e2bc3df4cf@linaro.org>
On Thu, May 19, 2022 at 05:14:33PM +0200, Krzysztof Kozlowski wrote:
> On 19/05/2022 17:13, Sudeep Holla wrote:
> > On Sun, May 01, 2022 at 12:34:27PM +0200, Krzysztof Kozlowski wrote:
> >> Correct kerneldoc warnings like:
> >>
> >> drivers/mailbox/arm_mhu_db.c:47:
> >> warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> >> drivers/mailbox/qcom-ipcc.c:58:
> >> warning: Function parameter or member 'num_chans' not described in 'qcom_ipcc'
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >> drivers/mailbox/arm_mhu_db.c | 2 +-
> >
> > I thought I had copied it from arm_mhuc.c but apparently not. Anyways,
> >
> > Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> >
>
>
> Thanks! Could someone pick these two patches?
>
They generally go via Jassi's tree.
Hi Jassi,
There is another PCC driver fix that I had acked few weeks back. Please
pick this as well as that when you start finalising patches for your PR
for v5.19.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-19 15:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 10:34 [PATCH 1/2] mailbox: correct kerneldoc Krzysztof Kozlowski
2022-05-01 10:34 ` Krzysztof Kozlowski
2022-05-01 10:34 ` [PATCH 2/2] mailbox: imx: fix duplicated initializer Krzysztof Kozlowski
2022-05-01 10:34 ` Krzysztof Kozlowski
2022-05-07 6:52 ` Peng Fan
2022-05-07 6:52 ` Peng Fan
2022-06-20 18:39 ` Krzysztof Kozlowski
2022-06-20 18:39 ` Krzysztof Kozlowski
2022-06-20 19:48 ` Jassi Brar
2022-06-20 19:48 ` Jassi Brar
2022-05-19 7:57 ` [PATCH 1/2] mailbox: correct kerneldoc Krzysztof Kozlowski
2022-05-19 7:57 ` Krzysztof Kozlowski
2022-05-19 11:07 ` Viresh Kumar
2022-05-19 11:07 ` Viresh Kumar
2022-05-19 15:13 ` Sudeep Holla
2022-05-19 15:13 ` Sudeep Holla
2022-05-19 15:14 ` Krzysztof Kozlowski
2022-05-19 15:14 ` Krzysztof Kozlowski
2022-05-19 15:19 ` Sudeep Holla [this message]
2022-05-19 15:19 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519151903.hvqyrw3yib2mb6yg@bogus \
--to=sudeep.holla@arm.com \
--cc=Tushar.Khandelwal@arm.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=festevam@gmail.com \
--cc=jassisinghbrar@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.