From: Gabriel Krisman Bertazi <krisman@collabora.com> To: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, ebiggers@kernel.org Cc: linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Gabriel Krisman Bertazi <krisman@collabora.com>, kernel@collabora.com Subject: [PATCH v8 0/8] Clean up the case-insensitive lookup path Date: Thu, 19 May 2022 17:23:51 -0400 [thread overview] Message-ID: <20220519212359.19442-1-krisman@collabora.com> (raw) Hi Eric, Ted, This is v7 of this series (thank you for the feedback!) . This picks up a few r-b tags and has one small fix asked by Eric to handle a corner case in ext4_match when IS_ENCRYPTED() and the key is added during lookup. * Original commit letter The case-insensitive implementations in f2fs and ext4 have quite a bit of duplicated code. This series simplifies the ext4 version, with the goal of extracting ext4_ci_compare into a helper library that can be used by both filesystems. It also reduces the clutter from many codeguards for CONFIG_UNICODE; as requested by Linus, they are part of the codeflow now. While there, I noticed we can leverage the utf8 functions to detect encoded names that are corrupted in the filesystem. Therefore, it also adds an ext4 error on that scenario, to mark the filesystem as corrupted. This series survived passes of xfstests -g quick. Gabriel Krisman Bertazi (8): ext4: Simplify the handling of cached insensitive names f2fs: Simplify the handling of cached insensitive names libfs: Introduce case-insensitive string comparison helper ext4: Reuse generic_ci_match for ci comparisons f2fs: Reuse generic_ci_match for ci comparisons ext4: Log error when lookup of encoded dentry fails ext4: Move CONFIG_UNICODE defguards into the code flow f2fs: Move CONFIG_UNICODE defguards into the code flow fs/ext4/ext4.h | 49 +++++++++-------- fs/ext4/namei.c | 130 ++++++++++++++++----------------------------- fs/ext4/super.c | 4 +- fs/f2fs/dir.c | 103 +++++++++++------------------------ fs/f2fs/f2fs.h | 15 +++++- fs/f2fs/namei.c | 11 ++-- fs/f2fs/recovery.c | 5 +- fs/f2fs/super.c | 8 +-- fs/libfs.c | 68 ++++++++++++++++++++++++ include/linux/fs.h | 4 ++ 10 files changed, 197 insertions(+), 200 deletions(-) -- 2.36.1
WARNING: multiple messages have this Message-ID (diff)
From: Gabriel Krisman Bertazi <krisman@collabora.com> To: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, ebiggers@kernel.org Cc: linux-ext4@vger.kernel.org, Gabriel Krisman Bertazi <krisman@collabora.com>, kernel@collabora.com, linux-f2fs-devel@lists.sourceforge.net Subject: [f2fs-dev] [PATCH v8 0/8] Clean up the case-insensitive lookup path Date: Thu, 19 May 2022 17:23:51 -0400 [thread overview] Message-ID: <20220519212359.19442-1-krisman@collabora.com> (raw) Hi Eric, Ted, This is v7 of this series (thank you for the feedback!) . This picks up a few r-b tags and has one small fix asked by Eric to handle a corner case in ext4_match when IS_ENCRYPTED() and the key is added during lookup. * Original commit letter The case-insensitive implementations in f2fs and ext4 have quite a bit of duplicated code. This series simplifies the ext4 version, with the goal of extracting ext4_ci_compare into a helper library that can be used by both filesystems. It also reduces the clutter from many codeguards for CONFIG_UNICODE; as requested by Linus, they are part of the codeflow now. While there, I noticed we can leverage the utf8 functions to detect encoded names that are corrupted in the filesystem. Therefore, it also adds an ext4 error on that scenario, to mark the filesystem as corrupted. This series survived passes of xfstests -g quick. Gabriel Krisman Bertazi (8): ext4: Simplify the handling of cached insensitive names f2fs: Simplify the handling of cached insensitive names libfs: Introduce case-insensitive string comparison helper ext4: Reuse generic_ci_match for ci comparisons f2fs: Reuse generic_ci_match for ci comparisons ext4: Log error when lookup of encoded dentry fails ext4: Move CONFIG_UNICODE defguards into the code flow f2fs: Move CONFIG_UNICODE defguards into the code flow fs/ext4/ext4.h | 49 +++++++++-------- fs/ext4/namei.c | 130 ++++++++++++++++----------------------------- fs/ext4/super.c | 4 +- fs/f2fs/dir.c | 103 +++++++++++------------------------ fs/f2fs/f2fs.h | 15 +++++- fs/f2fs/namei.c | 11 ++-- fs/f2fs/recovery.c | 5 +- fs/f2fs/super.c | 8 +-- fs/libfs.c | 68 ++++++++++++++++++++++++ include/linux/fs.h | 4 ++ 10 files changed, 197 insertions(+), 200 deletions(-) -- 2.36.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2022-05-19 21:24 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-19 21:23 Gabriel Krisman Bertazi [this message] 2022-05-19 21:23 ` [f2fs-dev] [PATCH v8 0/8] Clean up the case-insensitive lookup path Gabriel Krisman Bertazi 2022-05-19 21:23 ` [PATCH v8 1/8] ext4: Simplify the handling of cached insensitive names Gabriel Krisman Bertazi 2022-05-19 21:23 ` [f2fs-dev] " Gabriel Krisman Bertazi 2022-05-19 21:23 ` [PATCH v8 2/8] f2fs: " Gabriel Krisman Bertazi 2022-05-19 21:23 ` [f2fs-dev] " Gabriel Krisman Bertazi 2022-05-19 21:23 ` [PATCH v8 3/8] libfs: Introduce case-insensitive string comparison helper Gabriel Krisman Bertazi 2022-05-19 21:23 ` [f2fs-dev] " Gabriel Krisman Bertazi 2022-05-19 21:23 ` [PATCH v8 4/8] ext4: Reuse generic_ci_match for ci comparisons Gabriel Krisman Bertazi 2022-05-19 21:23 ` [f2fs-dev] " Gabriel Krisman Bertazi 2022-05-19 21:23 ` [PATCH v8 5/8] f2fs: " Gabriel Krisman Bertazi 2022-05-19 21:23 ` [f2fs-dev] " Gabriel Krisman Bertazi 2022-05-19 21:23 ` [PATCH v8 6/8] ext4: Log error when lookup of encoded dentry fails Gabriel Krisman Bertazi 2022-05-19 21:23 ` [f2fs-dev] " Gabriel Krisman Bertazi 2022-05-19 21:23 ` [PATCH v8 7/8] ext4: Move CONFIG_UNICODE defguards into the code flow Gabriel Krisman Bertazi 2022-05-19 21:23 ` [f2fs-dev] " Gabriel Krisman Bertazi 2022-05-19 21:23 ` [PATCH v8 8/8] f2fs: " Gabriel Krisman Bertazi 2022-05-19 21:23 ` [f2fs-dev] " Gabriel Krisman Bertazi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220519212359.19442-1-krisman@collabora.com \ --to=krisman@collabora.com \ --cc=adilger.kernel@dilger.ca \ --cc=ebiggers@kernel.org \ --cc=jaegeuk@kernel.org \ --cc=kernel@collabora.com \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=tytso@mit.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.