[PATCH] HSI: cmt_speech: Pass a pointer to virt_to_page()

[PATCH] HSI: cmt_speech: Pass a pointer to virt_to_page()

[Linus Walleij]

A pointer into virtual memory is represented by a (void *)
not an u32, so the compiler warns:

drivers/hsi/clients/cmt_speech.c:1092:35: warning: passing argument
  1 of 'virt_to_pfn' makes pointer from integer without a cast
  [-Wint-conversion]

Fix this with an explicit cast.

Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/hsi/clients/cmt_speech.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hsi/clients/cmt_speech.c b/drivers/hsi/clients/cmt_speech.c
index e014ef36d872..8069f795c864 100644
--- a/drivers/hsi/clients/cmt_speech.c
+++ b/drivers/hsi/clients/cmt_speech.c
@@ -1089,7 +1089,7 @@ static vm_fault_t cs_char_vma_fault(struct vm_fault *vmf)
 	struct cs_char *csdata = vmf->vma->vm_private_data;
 	struct page *page;
 
-	page = virt_to_page(csdata->mmap_base);
+	page = virt_to_page((void *)csdata->mmap_base);
 	get_page(page);
 	vmf->page = page;
 
-- 
2.35.1

Re: [PATCH] HSI: cmt_speech: Pass a pointer to virt_to_page()

[Linus Walleij]

On Thu, May 19, 2022 at 11:31 PM Linus Walleij <linus.walleij@linaro.org> wrote:

> A pointer into virtual memory is represented by a (void *)
> not an u32, so the compiler warns:
>
> drivers/hsi/clients/cmt_speech.c:1092:35: warning: passing argument
>   1 of 'virt_to_pfn' makes pointer from integer without a cast
>   [-Wint-conversion]
>
> Fix this with an explicit cast.
>
> Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
> Cc: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Sebastian can you apply this patch to the HSI tree please?

Yours,
Linus Walleij

Re: [PATCH] HSI: cmt_speech: Pass a pointer to virt_to_page()

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

Hi,

On Mon, Aug 29, 2022 at 03:16:03PM +0200, Linus Walleij wrote:
> On Thu, May 19, 2022 at 11:31 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> 
> > A pointer into virtual memory is represented by a (void *)
> > not an u32, so the compiler warns:
> >
> > drivers/hsi/clients/cmt_speech.c:1092:35: warning: passing argument
> >   1 of 'virt_to_pfn' makes pointer from integer without a cast
> >   [-Wint-conversion]
> >
> > Fix this with an explicit cast.
> >
> > Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> > Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
> > Cc: Pavel Machek <pavel@ucw.cz>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Sebastian can you apply this patch to the HSI tree please?

Thanks for the reminder. It's queued now and already in linux-next.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]