* [PATCH v2] firmware: qcom_scm-legacy: correct kerneldoc
@ 2022-05-19 7:34 Krzysztof Kozlowski
2022-05-19 22:12 ` Stephen Boyd
2022-06-27 20:02 ` (subset) " Bjorn Andersson
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-19 7:34 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, linux-arm-msm, linux-kernel
Cc: Stephen Boyd, Krzysztof Kozlowski
Correct kerneldoc warnings like:
drivers/firmware/qcom_scm-legacy.c:133:
warning: Function parameter or member 'dev' not described in 'scm_legacy_call'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v1:
1. Split series per subsystem.
2. Correct argument description (Stephen).
---
drivers/firmware/qcom_scm-legacy.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/firmware/qcom_scm-legacy.c b/drivers/firmware/qcom_scm-legacy.c
index 1829ba220576..9f918b9e6f8f 100644
--- a/drivers/firmware/qcom_scm-legacy.c
+++ b/drivers/firmware/qcom_scm-legacy.c
@@ -120,6 +120,9 @@ static void __scm_legacy_do(const struct arm_smccc_args *smc,
/**
* scm_legacy_call() - Sends a command to the SCM and waits for the command to
* finish processing.
+ * @dev: device
+ * @desc: descriptor structure containing arguments and return values
+ * @res: results from SMC call
*
* A note on cache maintenance:
* Note that any buffers that are expected to be accessed by the secure world
@@ -211,6 +214,7 @@ int scm_legacy_call(struct device *dev, const struct qcom_scm_desc *desc,
/**
* scm_legacy_call_atomic() - Send an atomic SCM command with up to 5 arguments
* and 3 return values
+ * @unused: device, legacy argument, not used, can be NULL
* @desc: SCM call descriptor containing arguments
* @res: SCM call return values
*
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] firmware: qcom_scm-legacy: correct kerneldoc
2022-05-19 7:34 [PATCH v2] firmware: qcom_scm-legacy: correct kerneldoc Krzysztof Kozlowski
@ 2022-05-19 22:12 ` Stephen Boyd
2022-06-20 18:34 ` Krzysztof Kozlowski
2022-06-27 20:02 ` (subset) " Bjorn Andersson
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2022-05-19 22:12 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Krzysztof Kozlowski, linux-arm-msm,
linux-kernel
Cc: Krzysztof Kozlowski
Quoting Krzysztof Kozlowski (2022-05-19 00:34:10)
> Correct kerneldoc warnings like:
>
> drivers/firmware/qcom_scm-legacy.c:133:
> warning: Function parameter or member 'dev' not described in 'scm_legacy_call'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] firmware: qcom_scm-legacy: correct kerneldoc
2022-05-19 22:12 ` Stephen Boyd
@ 2022-06-20 18:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-20 18:34 UTC (permalink / raw)
To: Stephen Boyd, Andy Gross, Bjorn Andersson, linux-arm-msm, linux-kernel
On 20/05/2022 00:12, Stephen Boyd wrote:
> Quoting Krzysztof Kozlowski (2022-05-19 00:34:10)
>> Correct kerneldoc warnings like:
>>
>> drivers/firmware/qcom_scm-legacy.c:133:
>> warning: Function parameter or member 'dev' not described in 'scm_legacy_call'
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>
> Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Thanks!
This was month ago... Is there anyone willing to pick it up?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: (subset) [PATCH v2] firmware: qcom_scm-legacy: correct kerneldoc
2022-05-19 7:34 [PATCH v2] firmware: qcom_scm-legacy: correct kerneldoc Krzysztof Kozlowski
2022-05-19 22:12 ` Stephen Boyd
@ 2022-06-27 20:02 ` Bjorn Andersson
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2022-06-27 20:02 UTC (permalink / raw)
To: linux-kernel, Krzysztof Kozlowski, Andy Gross, linux-arm-msm; +Cc: Stephen Boyd
On Thu, 19 May 2022 09:34:10 +0200, Krzysztof Kozlowski wrote:
> Correct kerneldoc warnings like:
>
> drivers/firmware/qcom_scm-legacy.c:133:
> warning: Function parameter or member 'dev' not described in 'scm_legacy_call'
>
>
Applied, thanks!
[1/1] firmware: qcom_scm-legacy: correct kerneldoc
commit: ebf21bbc2ff56ad42994f04ada64280bc819bb0b
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-27 20:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-19 7:34 [PATCH v2] firmware: qcom_scm-legacy: correct kerneldoc Krzysztof Kozlowski
2022-05-19 22:12 ` Stephen Boyd
2022-06-20 18:34 ` Krzysztof Kozlowski
2022-06-27 20:02 ` (subset) " Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.