* [PATCH v2] net: dsa: restrict SMSC_LAN9303_I2C kconfig
@ 2022-05-20 5:15 Randy Dunlap
2022-05-20 16:09 ` Vladimir Oltean
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Randy Dunlap @ 2022-05-20 5:15 UTC (permalink / raw)
To: netdev
Cc: patches, Randy Dunlap, Andrew Lunn, Vivien Didelot,
Florian Fainelli, Vladimir Oltean, Juergen Borleis,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Mans Rullgard
Since kconfig 'select' does not follow dependency chains, if symbol KSA
selects KSB, then KSA should also depend on the same symbols that KSB
depends on, in order to prevent Kconfig warnings and possible build
errors.
Change NET_DSA_SMSC_LAN9303_I2C and NET_DSA_SMSC_LAN9303_MDIO so that
they are limited to VLAN_8021Q if the latter is enabled. This prevents
the Kconfig warning:
WARNING: unmet direct dependencies detected for NET_DSA_SMSC_LAN9303
Depends on [m]: NETDEVICES [=y] && NET_DSA [=y] && (VLAN_8021Q [=m] || VLAN_8021Q [=m]=n)
Selected by [y]:
- NET_DSA_SMSC_LAN9303_I2C [=y] && NETDEVICES [=y] && NET_DSA [=y] && I2C [=y]
Fixes: 430065e26719 ("net: dsa: lan9303: add VLAN IDs to master device")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Vivien Didelot <vivien.didelot@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Vladimir Oltean <olteanv@gmail.com>
Cc: Juergen Borleis <jbe@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Mans Rullgard <mans@mansr.com>
---
v2: drop 'depends' for NET_DSA_SMSC_LAN9303 and add it for
NET_DSA_SMSC_LAN9303_MDIO; (Vladimir - thanks)
correct for Fixes: tag; (Vladimir - thanks)
drivers/net/dsa/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/net/dsa/Kconfig
+++ b/drivers/net/dsa/Kconfig
@@ -72,7 +72,6 @@ source "drivers/net/dsa/realtek/Kconfig"
config NET_DSA_SMSC_LAN9303
tristate
- depends on VLAN_8021Q || VLAN_8021Q=n
select NET_DSA_TAG_LAN9303
select REGMAP
help
@@ -82,6 +81,7 @@ config NET_DSA_SMSC_LAN9303
config NET_DSA_SMSC_LAN9303_I2C
tristate "SMSC/Microchip LAN9303 3-ports 10/100 ethernet switch in I2C managed mode"
depends on I2C
+ depends on VLAN_8021Q || VLAN_8021Q=n
select NET_DSA_SMSC_LAN9303
select REGMAP_I2C
help
@@ -91,6 +91,7 @@ config NET_DSA_SMSC_LAN9303_I2C
config NET_DSA_SMSC_LAN9303_MDIO
tristate "SMSC/Microchip LAN9303 3-ports 10/100 ethernet switch in MDIO managed mode"
select NET_DSA_SMSC_LAN9303
+ depends on VLAN_8021Q || VLAN_8021Q=n
help
Enable access functions if the SMSC/Microchip LAN9303 is configured
for MDIO managed mode.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] net: dsa: restrict SMSC_LAN9303_I2C kconfig
2022-05-20 5:15 [PATCH v2] net: dsa: restrict SMSC_LAN9303_I2C kconfig Randy Dunlap
@ 2022-05-20 16:09 ` Vladimir Oltean
2022-05-20 16:22 ` Florian Fainelli
2022-05-22 22:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Vladimir Oltean @ 2022-05-20 16:09 UTC (permalink / raw)
To: Randy Dunlap
Cc: netdev, patches, Andrew Lunn, Vivien Didelot, Florian Fainelli,
Juergen Borleis, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Mans Rullgard
On Thu, May 19, 2022 at 10:15:23PM -0700, Randy Dunlap wrote:
> Since kconfig 'select' does not follow dependency chains, if symbol KSA
> selects KSB, then KSA should also depend on the same symbols that KSB
> depends on, in order to prevent Kconfig warnings and possible build
> errors.
>
> Change NET_DSA_SMSC_LAN9303_I2C and NET_DSA_SMSC_LAN9303_MDIO so that
> they are limited to VLAN_8021Q if the latter is enabled. This prevents
> the Kconfig warning:
>
> WARNING: unmet direct dependencies detected for NET_DSA_SMSC_LAN9303
> Depends on [m]: NETDEVICES [=y] && NET_DSA [=y] && (VLAN_8021Q [=m] || VLAN_8021Q [=m]=n)
> Selected by [y]:
> - NET_DSA_SMSC_LAN9303_I2C [=y] && NETDEVICES [=y] && NET_DSA [=y] && I2C [=y]
>
> Fixes: 430065e26719 ("net: dsa: lan9303: add VLAN IDs to master device")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Vivien Didelot <vivien.didelot@gmail.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Vladimir Oltean <olteanv@gmail.com>
> Cc: Juergen Borleis <jbe@pengutronix.de>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Mans Rullgard <mans@mansr.com>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] net: dsa: restrict SMSC_LAN9303_I2C kconfig
2022-05-20 5:15 [PATCH v2] net: dsa: restrict SMSC_LAN9303_I2C kconfig Randy Dunlap
2022-05-20 16:09 ` Vladimir Oltean
@ 2022-05-20 16:22 ` Florian Fainelli
2022-05-22 22:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2022-05-20 16:22 UTC (permalink / raw)
To: Randy Dunlap, netdev
Cc: patches, Andrew Lunn, Vivien Didelot, Vladimir Oltean,
Juergen Borleis, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Mans Rullgard
On 5/19/2022 10:15 PM, Randy Dunlap wrote:
> Since kconfig 'select' does not follow dependency chains, if symbol KSA
> selects KSB, then KSA should also depend on the same symbols that KSB
> depends on, in order to prevent Kconfig warnings and possible build
> errors.
>
> Change NET_DSA_SMSC_LAN9303_I2C and NET_DSA_SMSC_LAN9303_MDIO so that
> they are limited to VLAN_8021Q if the latter is enabled. This prevents
> the Kconfig warning:
>
> WARNING: unmet direct dependencies detected for NET_DSA_SMSC_LAN9303
> Depends on [m]: NETDEVICES [=y] && NET_DSA [=y] && (VLAN_8021Q [=m] || VLAN_8021Q [=m]=n)
> Selected by [y]:
> - NET_DSA_SMSC_LAN9303_I2C [=y] && NETDEVICES [=y] && NET_DSA [=y] && I2C [=y]
>
> Fixes: 430065e26719 ("net: dsa: lan9303: add VLAN IDs to master device")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] net: dsa: restrict SMSC_LAN9303_I2C kconfig
2022-05-20 5:15 [PATCH v2] net: dsa: restrict SMSC_LAN9303_I2C kconfig Randy Dunlap
2022-05-20 16:09 ` Vladimir Oltean
2022-05-20 16:22 ` Florian Fainelli
@ 2022-05-22 22:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-05-22 22:10 UTC (permalink / raw)
To: Randy Dunlap
Cc: netdev, patches, andrew, vivien.didelot, f.fainelli, olteanv,
jbe, davem, edumazet, kuba, pabeni, mans
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 19 May 2022 22:15:23 -0700 you wrote:
> Since kconfig 'select' does not follow dependency chains, if symbol KSA
> selects KSB, then KSA should also depend on the same symbols that KSB
> depends on, in order to prevent Kconfig warnings and possible build
> errors.
>
> Change NET_DSA_SMSC_LAN9303_I2C and NET_DSA_SMSC_LAN9303_MDIO so that
> they are limited to VLAN_8021Q if the latter is enabled. This prevents
> the Kconfig warning:
>
> [...]
Here is the summary with links:
- [v2] net: dsa: restrict SMSC_LAN9303_I2C kconfig
https://git.kernel.org/netdev/net/c/0a3ad7d32368
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-22 22:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-20 5:15 [PATCH v2] net: dsa: restrict SMSC_LAN9303_I2C kconfig Randy Dunlap
2022-05-20 16:09 ` Vladimir Oltean
2022-05-20 16:22 ` Florian Fainelli
2022-05-22 22:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.