All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Jens Axboe <axboe@kernel.dk>, Theodore Ts'o <tytso@mit.edu>,
	Christoph Hellwig <hch@lst.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>
Cc: "Jason A . Donenfeld" <Jason@zx2c4.com>
Subject: [PATCH v4 3/3] random: wire up fops->splice_{read,write}_iter()
Date: Fri, 20 May 2022 11:44:59 +0200	[thread overview]
Message-ID: <20220520094459.116240-4-Jason@zx2c4.com> (raw)
In-Reply-To: <20220520094459.116240-1-Jason@zx2c4.com>

From: Jens Axboe <axboe@kernel.dk>

Now that random/urandom is using {read,write}_iter, we can wire it up to
using the generic splice handlers.

Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
[Jason: added the splice_write path. Note that sendfile() and such still
 does not work for read, though it does for write, because of the
 outdated file type restriction in splice_direct_to_actor(), which I'll
 address separately.]
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
 drivers/char/random.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/char/random.c b/drivers/char/random.c
index 831cafcd1034..15a9e5ea1b3f 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -1412,6 +1412,8 @@ const struct file_operations random_fops = {
 	.compat_ioctl = compat_ptr_ioctl,
 	.fasync = random_fasync,
 	.llseek = noop_llseek,
+	.splice_read = generic_file_splice_read,
+	.splice_write = iter_file_splice_write,
 };
 
 const struct file_operations urandom_fops = {
@@ -1421,6 +1423,8 @@ const struct file_operations urandom_fops = {
 	.compat_ioctl = compat_ptr_ioctl,
 	.fasync = random_fasync,
 	.llseek = noop_llseek,
+	.splice_read = generic_file_splice_read,
+	.splice_write = iter_file_splice_write,
 };
 
 
-- 
2.35.1


  parent reply	other threads:[~2022-05-20  9:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20  9:44 [PATCH v4 0/3] random: convert to using iters, for Al Viro Jason A. Donenfeld
2022-05-20  9:44 ` [PATCH v4 1/3] random: convert to using fops->read_iter() Jason A. Donenfeld
2022-05-20 13:37   ` Jason A. Donenfeld
2022-05-20 14:36     ` Jens Axboe
2022-05-20 14:39       ` Jason A. Donenfeld
2022-05-20 15:12         ` Al Viro
2022-05-20  9:44 ` [PATCH v4 2/3] random: convert to using fops->write_iter() Jason A. Donenfeld
2022-05-20  9:44 ` Jason A. Donenfeld [this message]
2022-05-20 12:16 ` [PATCH v4 0/3] random: convert to using iters, for Al Viro Jens Axboe
2022-05-20 15:25 ` Jason A. Donenfeld
2022-05-20 15:34   ` Jens Axboe
2022-05-20 15:39     ` Jason A. Donenfeld
2022-05-20 15:44       ` Jens Axboe
2022-05-20 15:55         ` Jason A. Donenfeld
2022-05-20 15:58           ` Jens Axboe
2022-05-20 16:03             ` Jason A. Donenfeld
2022-05-20 16:06               ` Jens Axboe
2022-05-20 15:46     ` Jason A. Donenfeld
2022-05-20 15:51       ` Jens Axboe
2022-05-20 15:58         ` Jason A. Donenfeld
2022-05-20 16:00           ` Jens Axboe
2022-05-20 15:47     ` Al Viro
2022-05-20 15:53       ` Jens Axboe
2022-05-20 16:15         ` Al Viro
2022-05-20 16:24           ` Jens Axboe
2022-05-20 16:39             ` Jason A. Donenfeld
2022-05-20 16:41               ` Jens Axboe
2022-05-24  4:52                 ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220520094459.116240-4-Jason@zx2c4.com \
    --to=jason@zx2c4.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.