All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Jens Axboe <axboe@kernel.dk>, Theodore Ts'o <tytso@mit.edu>,
	Christoph Hellwig <hch@lst.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v4 1/3] random: convert to using fops->read_iter()
Date: Fri, 20 May 2022 15:37:15 +0200	[thread overview]
Message-ID: <YoeZi94CpGW9LE/y@zx2c4.com> (raw)
In-Reply-To: <20220520094459.116240-2-Jason@zx2c4.com>

On Fri, May 20, 2022 at 11:44:57AM +0200, Jason A. Donenfeld wrote:
>  const struct file_operations urandom_fops = {
> -	.read = urandom_read,
> +	.read_iter = urandom_read_iter,

One thing I noticed is that drivers/char/mem.c has both the .read and
the .read_iter functions for /dev/zero and /dev/null and such. I wonder
if the .read ones can be removed?

Jason

  reply	other threads:[~2022-05-20 13:37 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20  9:44 [PATCH v4 0/3] random: convert to using iters, for Al Viro Jason A. Donenfeld
2022-05-20  9:44 ` [PATCH v4 1/3] random: convert to using fops->read_iter() Jason A. Donenfeld
2022-05-20 13:37   ` Jason A. Donenfeld [this message]
2022-05-20 14:36     ` Jens Axboe
2022-05-20 14:39       ` Jason A. Donenfeld
2022-05-20 15:12         ` Al Viro
2022-05-20  9:44 ` [PATCH v4 2/3] random: convert to using fops->write_iter() Jason A. Donenfeld
2022-05-20  9:44 ` [PATCH v4 3/3] random: wire up fops->splice_{read,write}_iter() Jason A. Donenfeld
2022-05-20 12:16 ` [PATCH v4 0/3] random: convert to using iters, for Al Viro Jens Axboe
2022-05-20 15:25 ` Jason A. Donenfeld
2022-05-20 15:34   ` Jens Axboe
2022-05-20 15:39     ` Jason A. Donenfeld
2022-05-20 15:44       ` Jens Axboe
2022-05-20 15:55         ` Jason A. Donenfeld
2022-05-20 15:58           ` Jens Axboe
2022-05-20 16:03             ` Jason A. Donenfeld
2022-05-20 16:06               ` Jens Axboe
2022-05-20 15:46     ` Jason A. Donenfeld
2022-05-20 15:51       ` Jens Axboe
2022-05-20 15:58         ` Jason A. Donenfeld
2022-05-20 16:00           ` Jens Axboe
2022-05-20 15:47     ` Al Viro
2022-05-20 15:53       ` Jens Axboe
2022-05-20 16:15         ` Al Viro
2022-05-20 16:24           ` Jens Axboe
2022-05-20 16:39             ` Jason A. Donenfeld
2022-05-20 16:41               ` Jens Axboe
2022-05-24  4:52                 ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoeZi94CpGW9LE/y@zx2c4.com \
    --to=jason@zx2c4.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.