From: Herve Codina <herve.codina@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string
Date: Fri, 20 May 2022 13:34:26 +0200 [thread overview]
Message-ID: <20220520133426.3b4728ae@bootlin.com> (raw)
In-Reply-To: <8f0d4127-7e66-cf50-21c9-99680f737e30@linaro.org>
On Fri, 13 May 2022 14:57:55 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 13/05/2022 12:58, Herve Codina wrote:
> > The USB device controller available in the Microchip LAN966x SOC
> > is the same IP as the one present in the SAMA5D3 SOC.
> >
> > Add the LAN966x compatible string and set the SAMA5D3 compatible
> > string as a fallback for the LAN966x.
> >
> > Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> > ---
> > Documentation/devicetree/bindings/usb/atmel-usb.txt | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.txt b/Documentation/devicetree/bindings/usb/atmel-usb.txt
> > index f512f0290728..a6fab7d63f37 100644
> > --- a/Documentation/devicetree/bindings/usb/atmel-usb.txt
> > +++ b/Documentation/devicetree/bindings/usb/atmel-usb.txt
> > @@ -87,6 +87,9 @@ Required properties:
> > "atmel,at91sam9g45-udc"
> > "atmel,sama5d3-udc"
> > "microchip,sam9x60-udc"
> > + "microchip,lan996x-udc"
>
> No wildcards please, especially that it closely fits previous wildcard
> (lan996x includes lan9960 which looks a lot like sam9x60...)
>
Well, first, I made a mistake. It should be lan966x instead of lan996x.
This family is composed of the LAN9662 and the LAN9668 SOCs.
Related to the wilcard, lan966x is used in several bindings for common
parts used by both SOCs:
- microchip,lan966x-gck
- microchip,lan966x-cpu-syscon
- microchip,lan966x-switch
- microchip,lan966x-miim
- microchip,lan966x-serdes
- microchip,lan966x-pinctrl
I think it makes sense to keep 'microchip,lan966x-udc' for the USB
device controller (same controller on LAN9662 and LAN9668) and so
keeping the same rules as for other common parts.
Regards,
Hervé
>
> Best regards,
> Krzysztof
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Herve Codina <herve.codina@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Stephen Boyd <sboyd@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-usb@vger.kernel.org, linux-clk@vger.kernel.org,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string
Date: Fri, 20 May 2022 13:34:26 +0200 [thread overview]
Message-ID: <20220520133426.3b4728ae@bootlin.com> (raw)
In-Reply-To: <8f0d4127-7e66-cf50-21c9-99680f737e30@linaro.org>
On Fri, 13 May 2022 14:57:55 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 13/05/2022 12:58, Herve Codina wrote:
> > The USB device controller available in the Microchip LAN966x SOC
> > is the same IP as the one present in the SAMA5D3 SOC.
> >
> > Add the LAN966x compatible string and set the SAMA5D3 compatible
> > string as a fallback for the LAN966x.
> >
> > Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> > ---
> > Documentation/devicetree/bindings/usb/atmel-usb.txt | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.txt b/Documentation/devicetree/bindings/usb/atmel-usb.txt
> > index f512f0290728..a6fab7d63f37 100644
> > --- a/Documentation/devicetree/bindings/usb/atmel-usb.txt
> > +++ b/Documentation/devicetree/bindings/usb/atmel-usb.txt
> > @@ -87,6 +87,9 @@ Required properties:
> > "atmel,at91sam9g45-udc"
> > "atmel,sama5d3-udc"
> > "microchip,sam9x60-udc"
> > + "microchip,lan996x-udc"
>
> No wildcards please, especially that it closely fits previous wildcard
> (lan996x includes lan9960 which looks a lot like sam9x60...)
>
Well, first, I made a mistake. It should be lan966x instead of lan996x.
This family is composed of the LAN9662 and the LAN9668 SOCs.
Related to the wilcard, lan966x is used in several bindings for common
parts used by both SOCs:
- microchip,lan966x-gck
- microchip,lan966x-cpu-syscon
- microchip,lan966x-switch
- microchip,lan966x-miim
- microchip,lan966x-serdes
- microchip,lan966x-pinctrl
I think it makes sense to keep 'microchip,lan966x-udc' for the USB
device controller (same controller on LAN9662 and LAN9668) and so
keeping the same rules as for other common parts.
Regards,
Hervé
>
> Best regards,
> Krzysztof
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-20 11:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 10:58 [PATCH 0/3] Microchip LAN966x USB device support Herve Codina
2022-05-13 10:58 ` Herve Codina
2022-05-13 10:58 ` [PATCH 1/3] clk: lan966x: Fix the lan966x clock gate register address Herve Codina
2022-05-13 10:58 ` Herve Codina
2022-05-13 10:58 ` [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string Herve Codina
2022-05-13 10:58 ` Herve Codina
2022-05-13 12:57 ` Krzysztof Kozlowski
2022-05-13 12:57 ` Krzysztof Kozlowski
2022-05-20 11:34 ` Herve Codina [this message]
2022-05-20 11:34 ` Herve Codina
2022-05-20 11:40 ` Krzysztof Kozlowski
2022-05-20 11:40 ` Krzysztof Kozlowski
2022-05-20 12:21 ` Herve Codina
2022-05-20 12:21 ` Herve Codina
2022-05-20 12:50 ` Krzysztof Kozlowski
2022-05-20 12:50 ` Krzysztof Kozlowski
2022-05-20 13:02 ` Herve Codina
2022-05-20 13:02 ` Herve Codina
2022-05-20 13:38 ` Krzysztof Kozlowski
2022-05-20 13:38 ` Krzysztof Kozlowski
2022-05-20 13:52 ` Alexandre Belloni
2022-05-20 13:52 ` Alexandre Belloni
2022-05-20 14:05 ` Krzysztof Kozlowski
2022-05-20 14:05 ` Krzysztof Kozlowski
2022-05-20 14:12 ` Herve Codina
2022-05-20 14:12 ` Herve Codina
2022-05-13 10:58 ` [PATCH 3/3] ARM: dts: lan966x: Add UDPHS support Herve Codina
2022-05-13 10:58 ` Herve Codina
2022-05-13 12:54 ` Krzysztof Kozlowski
2022-05-13 12:54 ` Krzysztof Kozlowski
2022-05-20 12:37 ` Herve Codina
2022-05-20 12:37 ` Herve Codina
2022-05-20 12:48 ` Krzysztof Kozlowski
2022-05-20 12:48 ` Krzysztof Kozlowski
2022-05-14 9:35 ` Sergei Shtylyov
2022-05-14 9:35 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220520133426.3b4728ae@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=horatiu.vultur@microchip.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.