* [PATCH] configs: imx8mp_venice: add FEC_QUIRK_ENET_MAC
@ 2022-04-29 17:08 Tim Harvey
2022-04-29 18:11 ` Tim Harvey
2022-05-20 13:42 ` sbabic
0 siblings, 2 replies; 3+ messages in thread
From: Tim Harvey @ 2022-04-29 17:08 UTC (permalink / raw)
To: Stefano Babic, Fabio Estevam, NXP i . MX U-Boot Team, u-boot; +Cc: Tim Harvey
The IMX8MP SoC FEC needs to have the FEC_QUIRK_ENET_MAC defined.
Fixes: commit 2395625209cc ("board: gateworks: venice: add imx8mp-venice-gw740x support")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
include/configs/imx8mp_venice.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/configs/imx8mp_venice.h b/include/configs/imx8mp_venice.h
index aa0396db8b83..4120e4cc6bad 100644
--- a/include/configs/imx8mp_venice.h
+++ b/include/configs/imx8mp_venice.h
@@ -106,4 +106,8 @@
#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \
sizeof(CONFIG_SYS_PROMPT) + 16)
+
+/* FEC */
+#define FEC_QUIRK_ENET_MAC
+
#endif
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] configs: imx8mp_venice: add FEC_QUIRK_ENET_MAC
2022-04-29 17:08 [PATCH] configs: imx8mp_venice: add FEC_QUIRK_ENET_MAC Tim Harvey
@ 2022-04-29 18:11 ` Tim Harvey
2022-05-20 13:42 ` sbabic
1 sibling, 0 replies; 3+ messages in thread
From: Tim Harvey @ 2022-04-29 18:11 UTC (permalink / raw)
To: Stefano Babic, Fabio Estevam, NXP i . MX U-Boot Team, u-boot
On Fri, Apr 29, 2022 at 10:08 AM Tim Harvey <tharvey@gateworks.com> wrote:
>
> The IMX8MP SoC FEC needs to have the FEC_QUIRK_ENET_MAC defined.
>
> Fixes: commit 2395625209cc ("board: gateworks: venice: add imx8mp-venice-gw740x support")
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
> include/configs/imx8mp_venice.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/configs/imx8mp_venice.h b/include/configs/imx8mp_venice.h
> index aa0396db8b83..4120e4cc6bad 100644
> --- a/include/configs/imx8mp_venice.h
> +++ b/include/configs/imx8mp_venice.h
> @@ -106,4 +106,8 @@
> #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
> #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \
> sizeof(CONFIG_SYS_PROMPT) + 16)
> +
> +/* FEC */
> +#define FEC_QUIRK_ENET_MAC
> +
> #endif
> --
> 2.17.1
>
Stefano,
Please drop this. FEC_QUIRK_ENET_MAC is defined in the imx-regs
includes for imx8.
Regardless, it seems there are several imx8m board include files that
are defining FEC_QUIRK_ENET_MAC in their include - I'll send a patch
to remove those as they are unnecessary.
Best Regards,
Tim
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] configs: imx8mp_venice: add FEC_QUIRK_ENET_MAC
2022-04-29 17:08 [PATCH] configs: imx8mp_venice: add FEC_QUIRK_ENET_MAC Tim Harvey
2022-04-29 18:11 ` Tim Harvey
@ 2022-05-20 13:42 ` sbabic
1 sibling, 0 replies; 3+ messages in thread
From: sbabic @ 2022-05-20 13:42 UTC (permalink / raw)
To: Tim Harvey, u-boot
> The IMX8MP SoC FEC needs to have the FEC_QUIRK_ENET_MAC defined.
> Fixes: commit 2395625209cc ("board: gateworks: venice: add imx8mp-venice-gw740x support")
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-20 13:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-29 17:08 [PATCH] configs: imx8mp_venice: add FEC_QUIRK_ENET_MAC Tim Harvey
2022-04-29 18:11 ` Tim Harvey
2022-05-20 13:42 ` sbabic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.