* [PATCH v2 0/2] dt-bindings: arm: MediaTek: Fix clock bindings @ 2022-05-18 9:36 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 27+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-18 9:36 UTC (permalink / raw) To: robh+dt Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, krzysztof.kozlowski As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for which I've used the already upstreamed ones as a base, it was found that these bindings have some issues. This series is addressing the issues that were found by Rob on my series, which are present on all of the already merged bindings. [1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953 Changes in v2: - Squashed patches as suggested AngeloGioacchino Del Regno (2): dt-bindings: arm: mtk-clock: Remove unnecessary 'items' and fix formatting dt-bindings: arm: mtk-clock: Set #clock-cells as required property .../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++----- .../mediatek/mediatek,mt8186-sys-clock.yaml | 1 + .../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++-------- .../mediatek/mediatek,mt8192-sys-clock.yaml | 1 + .../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++--------- .../mediatek/mediatek,mt8195-sys-clock.yaml | 1 + 6 files changed, 71 insertions(+), 66 deletions(-) -- 2.35.1 ^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 0/2] dt-bindings: arm: MediaTek: Fix clock bindings @ 2022-05-18 9:36 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 27+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-18 9:36 UTC (permalink / raw) To: robh+dt Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, krzysztof.kozlowski As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for which I've used the already upstreamed ones as a base, it was found that these bindings have some issues. This series is addressing the issues that were found by Rob on my series, which are present on all of the already merged bindings. [1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953 Changes in v2: - Squashed patches as suggested AngeloGioacchino Del Regno (2): dt-bindings: arm: mtk-clock: Remove unnecessary 'items' and fix formatting dt-bindings: arm: mtk-clock: Set #clock-cells as required property .../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++----- .../mediatek/mediatek,mt8186-sys-clock.yaml | 1 + .../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++-------- .../mediatek/mediatek,mt8192-sys-clock.yaml | 1 + .../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++--------- .../mediatek/mediatek,mt8195-sys-clock.yaml | 1 + 6 files changed, 71 insertions(+), 66 deletions(-) -- 2.35.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 0/2] dt-bindings: arm: MediaTek: Fix clock bindings @ 2022-05-18 9:36 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 27+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-18 9:36 UTC (permalink / raw) To: robh+dt Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, krzysztof.kozlowski As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for which I've used the already upstreamed ones as a base, it was found that these bindings have some issues. This series is addressing the issues that were found by Rob on my series, which are present on all of the already merged bindings. [1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953 Changes in v2: - Squashed patches as suggested AngeloGioacchino Del Regno (2): dt-bindings: arm: mtk-clock: Remove unnecessary 'items' and fix formatting dt-bindings: arm: mtk-clock: Set #clock-cells as required property .../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++----- .../mediatek/mediatek,mt8186-sys-clock.yaml | 1 + .../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++-------- .../mediatek/mediatek,mt8192-sys-clock.yaml | 1 + .../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++--------- .../mediatek/mediatek,mt8195-sys-clock.yaml | 1 + 6 files changed, 71 insertions(+), 66 deletions(-) -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 1/2] dt-bindings: arm: mtk-clock: Remove unnecessary 'items' and fix formatting 2022-05-18 9:36 ` AngeloGioacchino Del Regno (?) @ 2022-05-18 9:36 ` AngeloGioacchino Del Regno -1 siblings, 0 replies; 27+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-18 9:36 UTC (permalink / raw) To: robh+dt Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, krzysztof.kozlowski There's no need for 'items' when there's only one item; while at it, also fix formatting by adding a blank line before specifying 'reg'. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../arm/mediatek/mediatek,mt8186-clock.yaml | 28 ++++----- .../arm/mediatek/mediatek,mt8192-clock.yaml | 45 +++++++------- .../arm/mediatek/mediatek,mt8195-clock.yaml | 58 +++++++++---------- 3 files changed, 65 insertions(+), 66 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml index cf1002c3efa6..371eace6780b 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml @@ -21,20 +21,20 @@ description: | properties: compatible: - items: - - enum: - - mediatek,mt8186-imp_iic_wrap - - mediatek,mt8186-mfgsys - - mediatek,mt8186-wpesys - - mediatek,mt8186-imgsys1 - - mediatek,mt8186-imgsys2 - - mediatek,mt8186-vdecsys - - mediatek,mt8186-vencsys - - mediatek,mt8186-camsys - - mediatek,mt8186-camsys_rawa - - mediatek,mt8186-camsys_rawb - - mediatek,mt8186-mdpsys - - mediatek,mt8186-ipesys + enum: + - mediatek,mt8186-imp_iic_wrap + - mediatek,mt8186-mfgsys + - mediatek,mt8186-wpesys + - mediatek,mt8186-imgsys1 + - mediatek,mt8186-imgsys2 + - mediatek,mt8186-vdecsys + - mediatek,mt8186-vencsys + - mediatek,mt8186-camsys + - mediatek,mt8186-camsys_rawa + - mediatek,mt8186-camsys_rawb + - mediatek,mt8186-mdpsys + - mediatek,mt8186-ipesys + reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml index c8c67c033f8c..bb410b178f33 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml @@ -14,29 +14,28 @@ description: properties: compatible: - items: - - enum: - - mediatek,mt8192-scp_adsp - - mediatek,mt8192-imp_iic_wrap_c - - mediatek,mt8192-imp_iic_wrap_e - - mediatek,mt8192-imp_iic_wrap_s - - mediatek,mt8192-imp_iic_wrap_ws - - mediatek,mt8192-imp_iic_wrap_w - - mediatek,mt8192-imp_iic_wrap_n - - mediatek,mt8192-msdc_top - - mediatek,mt8192-msdc - - mediatek,mt8192-mfgcfg - - mediatek,mt8192-imgsys - - mediatek,mt8192-imgsys2 - - mediatek,mt8192-vdecsys_soc - - mediatek,mt8192-vdecsys - - mediatek,mt8192-vencsys - - mediatek,mt8192-camsys - - mediatek,mt8192-camsys_rawa - - mediatek,mt8192-camsys_rawb - - mediatek,mt8192-camsys_rawc - - mediatek,mt8192-ipesys - - mediatek,mt8192-mdpsys + enum: + - mediatek,mt8192-scp_adsp + - mediatek,mt8192-imp_iic_wrap_c + - mediatek,mt8192-imp_iic_wrap_e + - mediatek,mt8192-imp_iic_wrap_s + - mediatek,mt8192-imp_iic_wrap_ws + - mediatek,mt8192-imp_iic_wrap_w + - mediatek,mt8192-imp_iic_wrap_n + - mediatek,mt8192-msdc_top + - mediatek,mt8192-msdc + - mediatek,mt8192-mfgcfg + - mediatek,mt8192-imgsys + - mediatek,mt8192-imgsys2 + - mediatek,mt8192-vdecsys_soc + - mediatek,mt8192-vdecsys + - mediatek,mt8192-vencsys + - mediatek,mt8192-camsys + - mediatek,mt8192-camsys_rawa + - mediatek,mt8192-camsys_rawb + - mediatek,mt8192-camsys_rawc + - mediatek,mt8192-ipesys + - mediatek,mt8192-mdpsys reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml index 17fcbb45d121..0189aa0e34d4 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml @@ -22,35 +22,35 @@ description: properties: compatible: - items: - - enum: - - mediatek,mt8195-scp_adsp - - mediatek,mt8195-imp_iic_wrap_s - - mediatek,mt8195-imp_iic_wrap_w - - mediatek,mt8195-mfgcfg - - mediatek,mt8195-vppsys0 - - mediatek,mt8195-wpesys - - mediatek,mt8195-wpesys_vpp0 - - mediatek,mt8195-wpesys_vpp1 - - mediatek,mt8195-vppsys1 - - mediatek,mt8195-imgsys - - mediatek,mt8195-imgsys1_dip_top - - mediatek,mt8195-imgsys1_dip_nr - - mediatek,mt8195-imgsys1_wpe - - mediatek,mt8195-ipesys - - mediatek,mt8195-camsys - - mediatek,mt8195-camsys_rawa - - mediatek,mt8195-camsys_yuva - - mediatek,mt8195-camsys_rawb - - mediatek,mt8195-camsys_yuvb - - mediatek,mt8195-camsys_mraw - - mediatek,mt8195-ccusys - - mediatek,mt8195-vdecsys_soc - - mediatek,mt8195-vdecsys - - mediatek,mt8195-vdecsys_core1 - - mediatek,mt8195-vencsys - - mediatek,mt8195-vencsys_core1 - - mediatek,mt8195-apusys_pll + enum: + - mediatek,mt8195-scp_adsp + - mediatek,mt8195-imp_iic_wrap_s + - mediatek,mt8195-imp_iic_wrap_w + - mediatek,mt8195-mfgcfg + - mediatek,mt8195-vppsys0 + - mediatek,mt8195-wpesys + - mediatek,mt8195-wpesys_vpp0 + - mediatek,mt8195-wpesys_vpp1 + - mediatek,mt8195-vppsys1 + - mediatek,mt8195-imgsys + - mediatek,mt8195-imgsys1_dip_top + - mediatek,mt8195-imgsys1_dip_nr + - mediatek,mt8195-imgsys1_wpe + - mediatek,mt8195-ipesys + - mediatek,mt8195-camsys + - mediatek,mt8195-camsys_rawa + - mediatek,mt8195-camsys_yuva + - mediatek,mt8195-camsys_rawb + - mediatek,mt8195-camsys_yuvb + - mediatek,mt8195-camsys_mraw + - mediatek,mt8195-ccusys + - mediatek,mt8195-vdecsys_soc + - mediatek,mt8195-vdecsys + - mediatek,mt8195-vdecsys_core1 + - mediatek,mt8195-vencsys + - mediatek,mt8195-vencsys_core1 + - mediatek,mt8195-apusys_pll + reg: maxItems: 1 -- 2.35.1 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2 1/2] dt-bindings: arm: mtk-clock: Remove unnecessary 'items' and fix formatting @ 2022-05-18 9:36 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 27+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-18 9:36 UTC (permalink / raw) To: robh+dt Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, krzysztof.kozlowski There's no need for 'items' when there's only one item; while at it, also fix formatting by adding a blank line before specifying 'reg'. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../arm/mediatek/mediatek,mt8186-clock.yaml | 28 ++++----- .../arm/mediatek/mediatek,mt8192-clock.yaml | 45 +++++++------- .../arm/mediatek/mediatek,mt8195-clock.yaml | 58 +++++++++---------- 3 files changed, 65 insertions(+), 66 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml index cf1002c3efa6..371eace6780b 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml @@ -21,20 +21,20 @@ description: | properties: compatible: - items: - - enum: - - mediatek,mt8186-imp_iic_wrap - - mediatek,mt8186-mfgsys - - mediatek,mt8186-wpesys - - mediatek,mt8186-imgsys1 - - mediatek,mt8186-imgsys2 - - mediatek,mt8186-vdecsys - - mediatek,mt8186-vencsys - - mediatek,mt8186-camsys - - mediatek,mt8186-camsys_rawa - - mediatek,mt8186-camsys_rawb - - mediatek,mt8186-mdpsys - - mediatek,mt8186-ipesys + enum: + - mediatek,mt8186-imp_iic_wrap + - mediatek,mt8186-mfgsys + - mediatek,mt8186-wpesys + - mediatek,mt8186-imgsys1 + - mediatek,mt8186-imgsys2 + - mediatek,mt8186-vdecsys + - mediatek,mt8186-vencsys + - mediatek,mt8186-camsys + - mediatek,mt8186-camsys_rawa + - mediatek,mt8186-camsys_rawb + - mediatek,mt8186-mdpsys + - mediatek,mt8186-ipesys + reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml index c8c67c033f8c..bb410b178f33 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml @@ -14,29 +14,28 @@ description: properties: compatible: - items: - - enum: - - mediatek,mt8192-scp_adsp - - mediatek,mt8192-imp_iic_wrap_c - - mediatek,mt8192-imp_iic_wrap_e - - mediatek,mt8192-imp_iic_wrap_s - - mediatek,mt8192-imp_iic_wrap_ws - - mediatek,mt8192-imp_iic_wrap_w - - mediatek,mt8192-imp_iic_wrap_n - - mediatek,mt8192-msdc_top - - mediatek,mt8192-msdc - - mediatek,mt8192-mfgcfg - - mediatek,mt8192-imgsys - - mediatek,mt8192-imgsys2 - - mediatek,mt8192-vdecsys_soc - - mediatek,mt8192-vdecsys - - mediatek,mt8192-vencsys - - mediatek,mt8192-camsys - - mediatek,mt8192-camsys_rawa - - mediatek,mt8192-camsys_rawb - - mediatek,mt8192-camsys_rawc - - mediatek,mt8192-ipesys - - mediatek,mt8192-mdpsys + enum: + - mediatek,mt8192-scp_adsp + - mediatek,mt8192-imp_iic_wrap_c + - mediatek,mt8192-imp_iic_wrap_e + - mediatek,mt8192-imp_iic_wrap_s + - mediatek,mt8192-imp_iic_wrap_ws + - mediatek,mt8192-imp_iic_wrap_w + - mediatek,mt8192-imp_iic_wrap_n + - mediatek,mt8192-msdc_top + - mediatek,mt8192-msdc + - mediatek,mt8192-mfgcfg + - mediatek,mt8192-imgsys + - mediatek,mt8192-imgsys2 + - mediatek,mt8192-vdecsys_soc + - mediatek,mt8192-vdecsys + - mediatek,mt8192-vencsys + - mediatek,mt8192-camsys + - mediatek,mt8192-camsys_rawa + - mediatek,mt8192-camsys_rawb + - mediatek,mt8192-camsys_rawc + - mediatek,mt8192-ipesys + - mediatek,mt8192-mdpsys reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml index 17fcbb45d121..0189aa0e34d4 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml @@ -22,35 +22,35 @@ description: properties: compatible: - items: - - enum: - - mediatek,mt8195-scp_adsp - - mediatek,mt8195-imp_iic_wrap_s - - mediatek,mt8195-imp_iic_wrap_w - - mediatek,mt8195-mfgcfg - - mediatek,mt8195-vppsys0 - - mediatek,mt8195-wpesys - - mediatek,mt8195-wpesys_vpp0 - - mediatek,mt8195-wpesys_vpp1 - - mediatek,mt8195-vppsys1 - - mediatek,mt8195-imgsys - - mediatek,mt8195-imgsys1_dip_top - - mediatek,mt8195-imgsys1_dip_nr - - mediatek,mt8195-imgsys1_wpe - - mediatek,mt8195-ipesys - - mediatek,mt8195-camsys - - mediatek,mt8195-camsys_rawa - - mediatek,mt8195-camsys_yuva - - mediatek,mt8195-camsys_rawb - - mediatek,mt8195-camsys_yuvb - - mediatek,mt8195-camsys_mraw - - mediatek,mt8195-ccusys - - mediatek,mt8195-vdecsys_soc - - mediatek,mt8195-vdecsys - - mediatek,mt8195-vdecsys_core1 - - mediatek,mt8195-vencsys - - mediatek,mt8195-vencsys_core1 - - mediatek,mt8195-apusys_pll + enum: + - mediatek,mt8195-scp_adsp + - mediatek,mt8195-imp_iic_wrap_s + - mediatek,mt8195-imp_iic_wrap_w + - mediatek,mt8195-mfgcfg + - mediatek,mt8195-vppsys0 + - mediatek,mt8195-wpesys + - mediatek,mt8195-wpesys_vpp0 + - mediatek,mt8195-wpesys_vpp1 + - mediatek,mt8195-vppsys1 + - mediatek,mt8195-imgsys + - mediatek,mt8195-imgsys1_dip_top + - mediatek,mt8195-imgsys1_dip_nr + - mediatek,mt8195-imgsys1_wpe + - mediatek,mt8195-ipesys + - mediatek,mt8195-camsys + - mediatek,mt8195-camsys_rawa + - mediatek,mt8195-camsys_yuva + - mediatek,mt8195-camsys_rawb + - mediatek,mt8195-camsys_yuvb + - mediatek,mt8195-camsys_mraw + - mediatek,mt8195-ccusys + - mediatek,mt8195-vdecsys_soc + - mediatek,mt8195-vdecsys + - mediatek,mt8195-vdecsys_core1 + - mediatek,mt8195-vencsys + - mediatek,mt8195-vencsys_core1 + - mediatek,mt8195-apusys_pll + reg: maxItems: 1 -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2 1/2] dt-bindings: arm: mtk-clock: Remove unnecessary 'items' and fix formatting @ 2022-05-18 9:36 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 27+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-18 9:36 UTC (permalink / raw) To: robh+dt Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, krzysztof.kozlowski There's no need for 'items' when there's only one item; while at it, also fix formatting by adding a blank line before specifying 'reg'. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../arm/mediatek/mediatek,mt8186-clock.yaml | 28 ++++----- .../arm/mediatek/mediatek,mt8192-clock.yaml | 45 +++++++------- .../arm/mediatek/mediatek,mt8195-clock.yaml | 58 +++++++++---------- 3 files changed, 65 insertions(+), 66 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml index cf1002c3efa6..371eace6780b 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml @@ -21,20 +21,20 @@ description: | properties: compatible: - items: - - enum: - - mediatek,mt8186-imp_iic_wrap - - mediatek,mt8186-mfgsys - - mediatek,mt8186-wpesys - - mediatek,mt8186-imgsys1 - - mediatek,mt8186-imgsys2 - - mediatek,mt8186-vdecsys - - mediatek,mt8186-vencsys - - mediatek,mt8186-camsys - - mediatek,mt8186-camsys_rawa - - mediatek,mt8186-camsys_rawb - - mediatek,mt8186-mdpsys - - mediatek,mt8186-ipesys + enum: + - mediatek,mt8186-imp_iic_wrap + - mediatek,mt8186-mfgsys + - mediatek,mt8186-wpesys + - mediatek,mt8186-imgsys1 + - mediatek,mt8186-imgsys2 + - mediatek,mt8186-vdecsys + - mediatek,mt8186-vencsys + - mediatek,mt8186-camsys + - mediatek,mt8186-camsys_rawa + - mediatek,mt8186-camsys_rawb + - mediatek,mt8186-mdpsys + - mediatek,mt8186-ipesys + reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml index c8c67c033f8c..bb410b178f33 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml @@ -14,29 +14,28 @@ description: properties: compatible: - items: - - enum: - - mediatek,mt8192-scp_adsp - - mediatek,mt8192-imp_iic_wrap_c - - mediatek,mt8192-imp_iic_wrap_e - - mediatek,mt8192-imp_iic_wrap_s - - mediatek,mt8192-imp_iic_wrap_ws - - mediatek,mt8192-imp_iic_wrap_w - - mediatek,mt8192-imp_iic_wrap_n - - mediatek,mt8192-msdc_top - - mediatek,mt8192-msdc - - mediatek,mt8192-mfgcfg - - mediatek,mt8192-imgsys - - mediatek,mt8192-imgsys2 - - mediatek,mt8192-vdecsys_soc - - mediatek,mt8192-vdecsys - - mediatek,mt8192-vencsys - - mediatek,mt8192-camsys - - mediatek,mt8192-camsys_rawa - - mediatek,mt8192-camsys_rawb - - mediatek,mt8192-camsys_rawc - - mediatek,mt8192-ipesys - - mediatek,mt8192-mdpsys + enum: + - mediatek,mt8192-scp_adsp + - mediatek,mt8192-imp_iic_wrap_c + - mediatek,mt8192-imp_iic_wrap_e + - mediatek,mt8192-imp_iic_wrap_s + - mediatek,mt8192-imp_iic_wrap_ws + - mediatek,mt8192-imp_iic_wrap_w + - mediatek,mt8192-imp_iic_wrap_n + - mediatek,mt8192-msdc_top + - mediatek,mt8192-msdc + - mediatek,mt8192-mfgcfg + - mediatek,mt8192-imgsys + - mediatek,mt8192-imgsys2 + - mediatek,mt8192-vdecsys_soc + - mediatek,mt8192-vdecsys + - mediatek,mt8192-vencsys + - mediatek,mt8192-camsys + - mediatek,mt8192-camsys_rawa + - mediatek,mt8192-camsys_rawb + - mediatek,mt8192-camsys_rawc + - mediatek,mt8192-ipesys + - mediatek,mt8192-mdpsys reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml index 17fcbb45d121..0189aa0e34d4 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml @@ -22,35 +22,35 @@ description: properties: compatible: - items: - - enum: - - mediatek,mt8195-scp_adsp - - mediatek,mt8195-imp_iic_wrap_s - - mediatek,mt8195-imp_iic_wrap_w - - mediatek,mt8195-mfgcfg - - mediatek,mt8195-vppsys0 - - mediatek,mt8195-wpesys - - mediatek,mt8195-wpesys_vpp0 - - mediatek,mt8195-wpesys_vpp1 - - mediatek,mt8195-vppsys1 - - mediatek,mt8195-imgsys - - mediatek,mt8195-imgsys1_dip_top - - mediatek,mt8195-imgsys1_dip_nr - - mediatek,mt8195-imgsys1_wpe - - mediatek,mt8195-ipesys - - mediatek,mt8195-camsys - - mediatek,mt8195-camsys_rawa - - mediatek,mt8195-camsys_yuva - - mediatek,mt8195-camsys_rawb - - mediatek,mt8195-camsys_yuvb - - mediatek,mt8195-camsys_mraw - - mediatek,mt8195-ccusys - - mediatek,mt8195-vdecsys_soc - - mediatek,mt8195-vdecsys - - mediatek,mt8195-vdecsys_core1 - - mediatek,mt8195-vencsys - - mediatek,mt8195-vencsys_core1 - - mediatek,mt8195-apusys_pll + enum: + - mediatek,mt8195-scp_adsp + - mediatek,mt8195-imp_iic_wrap_s + - mediatek,mt8195-imp_iic_wrap_w + - mediatek,mt8195-mfgcfg + - mediatek,mt8195-vppsys0 + - mediatek,mt8195-wpesys + - mediatek,mt8195-wpesys_vpp0 + - mediatek,mt8195-wpesys_vpp1 + - mediatek,mt8195-vppsys1 + - mediatek,mt8195-imgsys + - mediatek,mt8195-imgsys1_dip_top + - mediatek,mt8195-imgsys1_dip_nr + - mediatek,mt8195-imgsys1_wpe + - mediatek,mt8195-ipesys + - mediatek,mt8195-camsys + - mediatek,mt8195-camsys_rawa + - mediatek,mt8195-camsys_yuva + - mediatek,mt8195-camsys_rawb + - mediatek,mt8195-camsys_yuvb + - mediatek,mt8195-camsys_mraw + - mediatek,mt8195-ccusys + - mediatek,mt8195-vdecsys_soc + - mediatek,mt8195-vdecsys + - mediatek,mt8195-vdecsys_core1 + - mediatek,mt8195-vencsys + - mediatek,mt8195-vencsys_core1 + - mediatek,mt8195-apusys_pll + reg: maxItems: 1 -- 2.35.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: arm: mtk-clock: Remove unnecessary 'items' and fix formatting 2022-05-18 9:36 ` AngeloGioacchino Del Regno (?) @ 2022-05-20 22:16 ` Rob Herring -1 siblings, 0 replies; 27+ messages in thread From: Rob Herring @ 2022-05-20 22:16 UTC (permalink / raw) To: AngeloGioacchino Del Regno Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, krzysztof.kozlowski On Wed, May 18, 2022 at 11:36:30AM +0200, AngeloGioacchino Del Regno wrote: > There's no need for 'items' when there's only one item; while at it, > also fix formatting by adding a blank line before specifying 'reg'. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../arm/mediatek/mediatek,mt8186-clock.yaml | 28 ++++----- > .../arm/mediatek/mediatek,mt8192-clock.yaml | 45 +++++++------- > .../arm/mediatek/mediatek,mt8195-clock.yaml | 58 +++++++++---------- > 3 files changed, 65 insertions(+), 66 deletions(-) Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: arm: mtk-clock: Remove unnecessary 'items' and fix formatting @ 2022-05-20 22:16 ` Rob Herring 0 siblings, 0 replies; 27+ messages in thread From: Rob Herring @ 2022-05-20 22:16 UTC (permalink / raw) To: AngeloGioacchino Del Regno Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, krzysztof.kozlowski On Wed, May 18, 2022 at 11:36:30AM +0200, AngeloGioacchino Del Regno wrote: > There's no need for 'items' when there's only one item; while at it, > also fix formatting by adding a blank line before specifying 'reg'. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../arm/mediatek/mediatek,mt8186-clock.yaml | 28 ++++----- > .../arm/mediatek/mediatek,mt8192-clock.yaml | 45 +++++++------- > .../arm/mediatek/mediatek,mt8195-clock.yaml | 58 +++++++++---------- > 3 files changed, 65 insertions(+), 66 deletions(-) Acked-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: arm: mtk-clock: Remove unnecessary 'items' and fix formatting @ 2022-05-20 22:16 ` Rob Herring 0 siblings, 0 replies; 27+ messages in thread From: Rob Herring @ 2022-05-20 22:16 UTC (permalink / raw) To: AngeloGioacchino Del Regno Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, krzysztof.kozlowski On Wed, May 18, 2022 at 11:36:30AM +0200, AngeloGioacchino Del Regno wrote: > There's no need for 'items' when there's only one item; while at it, > also fix formatting by adding a blank line before specifying 'reg'. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../arm/mediatek/mediatek,mt8186-clock.yaml | 28 ++++----- > .../arm/mediatek/mediatek,mt8192-clock.yaml | 45 +++++++------- > .../arm/mediatek/mediatek,mt8195-clock.yaml | 58 +++++++++---------- > 3 files changed, 65 insertions(+), 66 deletions(-) Acked-by: Rob Herring <robh@kernel.org> _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property 2022-05-18 9:36 ` AngeloGioacchino Del Regno (?) @ 2022-05-18 9:36 ` AngeloGioacchino Del Regno -1 siblings, 0 replies; 27+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-18 9:36 UTC (permalink / raw) To: robh+dt Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, krzysztof.kozlowski This is a clock-controller binding, so it needs #clock-cells, or it would be of no use: add that to the list of required properties. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 + .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 + .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 + .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 + .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 + 6 files changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml index 371eace6780b..70d7b393140e 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml @@ -44,6 +44,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml index 0886e2e335bb..48ebd2112789 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml @@ -42,6 +42,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml index bb410b178f33..b61d7635dfdd 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml @@ -46,6 +46,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml index 27f79175c678..580450e94c02 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml @@ -35,6 +35,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml index 0189aa0e34d4..aabd9f0df2de 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml @@ -60,6 +60,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml index 95b6bdf99936..e2ba37830d4e 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml @@ -43,6 +43,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false -- 2.35.1 ^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property @ 2022-05-18 9:36 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 27+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-18 9:36 UTC (permalink / raw) To: robh+dt Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, krzysztof.kozlowski This is a clock-controller binding, so it needs #clock-cells, or it would be of no use: add that to the list of required properties. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 + .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 + .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 + .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 + .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 + 6 files changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml index 371eace6780b..70d7b393140e 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml @@ -44,6 +44,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml index 0886e2e335bb..48ebd2112789 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml @@ -42,6 +42,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml index bb410b178f33..b61d7635dfdd 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml @@ -46,6 +46,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml index 27f79175c678..580450e94c02 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml @@ -35,6 +35,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml index 0189aa0e34d4..aabd9f0df2de 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml @@ -60,6 +60,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml index 95b6bdf99936..e2ba37830d4e 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml @@ -43,6 +43,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property @ 2022-05-18 9:36 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 27+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-18 9:36 UTC (permalink / raw) To: robh+dt Cc: krzysztof.kozlowski+dt, matthias.bgg, angelogioacchino.delregno, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, krzysztof.kozlowski This is a clock-controller binding, so it needs #clock-cells, or it would be of no use: add that to the list of required properties. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 + .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 + .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 + .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 + .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 + 6 files changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml index 371eace6780b..70d7b393140e 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml @@ -44,6 +44,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml index 0886e2e335bb..48ebd2112789 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml @@ -42,6 +42,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml index bb410b178f33..b61d7635dfdd 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml @@ -46,6 +46,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml index 27f79175c678..580450e94c02 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml @@ -35,6 +35,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml index 0189aa0e34d4..aabd9f0df2de 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml @@ -60,6 +60,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml index 95b6bdf99936..e2ba37830d4e 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml @@ -43,6 +43,7 @@ properties: required: - compatible - reg + - '#clock-cells' additionalProperties: false -- 2.35.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property 2022-05-18 9:36 ` AngeloGioacchino Del Regno (?) @ 2022-05-18 11:46 ` Krzysztof Kozlowski -1 siblings, 0 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2022-05-18 11:46 UTC (permalink / raw) To: AngeloGioacchino Del Regno, robh+dt Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel On 18/05/2022 11:36, AngeloGioacchino Del Regno wrote: > This is a clock-controller binding, so it needs #clock-cells, or > it would be of no use: add that to the list of required properties. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> These I considered as somehow fixes so I did not ask to remove the Fixes tag, so also not squashing. It's fine, though... Best regards, Krzysztof ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property @ 2022-05-18 11:46 ` Krzysztof Kozlowski 0 siblings, 0 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2022-05-18 11:46 UTC (permalink / raw) To: AngeloGioacchino Del Regno, robh+dt Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel On 18/05/2022 11:36, AngeloGioacchino Del Regno wrote: > This is a clock-controller binding, so it needs #clock-cells, or > it would be of no use: add that to the list of required properties. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> These I considered as somehow fixes so I did not ask to remove the Fixes tag, so also not squashing. It's fine, though... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property @ 2022-05-18 11:46 ` Krzysztof Kozlowski 0 siblings, 0 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2022-05-18 11:46 UTC (permalink / raw) To: AngeloGioacchino Del Regno, robh+dt Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel On 18/05/2022 11:36, AngeloGioacchino Del Regno wrote: > This is a clock-controller binding, so it needs #clock-cells, or > it would be of no use: add that to the list of required properties. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> These I considered as somehow fixes so I did not ask to remove the Fixes tag, so also not squashing. It's fine, though... Best regards, Krzysztof _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property 2022-05-18 11:46 ` Krzysztof Kozlowski (?) @ 2022-05-18 11:50 ` AngeloGioacchino Del Regno -1 siblings, 0 replies; 27+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-18 11:50 UTC (permalink / raw) To: Krzysztof Kozlowski, robh+dt Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel Il 18/05/22 13:46, Krzysztof Kozlowski ha scritto: > On 18/05/2022 11:36, AngeloGioacchino Del Regno wrote: >> This is a clock-controller binding, so it needs #clock-cells, or >> it would be of no use: add that to the list of required properties. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > These I considered as somehow fixes so I did not ask to remove the Fixes > tag, so also not squashing. It's fine, though... > I'm sorry Krzysztof, for some reason I was sure that your comments were applicable on the entire series... I'll pay more attention next time, and eventually I'll make one more question when/if needed. I take your last comment as "leave this series as it is", so I will not send a v3. Regards, Angelo ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property @ 2022-05-18 11:50 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 27+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-18 11:50 UTC (permalink / raw) To: Krzysztof Kozlowski, robh+dt Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel Il 18/05/22 13:46, Krzysztof Kozlowski ha scritto: > On 18/05/2022 11:36, AngeloGioacchino Del Regno wrote: >> This is a clock-controller binding, so it needs #clock-cells, or >> it would be of no use: add that to the list of required properties. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > These I considered as somehow fixes so I did not ask to remove the Fixes > tag, so also not squashing. It's fine, though... > I'm sorry Krzysztof, for some reason I was sure that your comments were applicable on the entire series... I'll pay more attention next time, and eventually I'll make one more question when/if needed. I take your last comment as "leave this series as it is", so I will not send a v3. Regards, Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property @ 2022-05-18 11:50 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 27+ messages in thread From: AngeloGioacchino Del Regno @ 2022-05-18 11:50 UTC (permalink / raw) To: Krzysztof Kozlowski, robh+dt Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel Il 18/05/22 13:46, Krzysztof Kozlowski ha scritto: > On 18/05/2022 11:36, AngeloGioacchino Del Regno wrote: >> This is a clock-controller binding, so it needs #clock-cells, or >> it would be of no use: add that to the list of required properties. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > These I considered as somehow fixes so I did not ask to remove the Fixes > tag, so also not squashing. It's fine, though... > I'm sorry Krzysztof, for some reason I was sure that your comments were applicable on the entire series... I'll pay more attention next time, and eventually I'll make one more question when/if needed. I take your last comment as "leave this series as it is", so I will not send a v3. Regards, Angelo _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property 2022-05-18 9:36 ` AngeloGioacchino Del Regno (?) @ 2022-05-20 22:19 ` Rob Herring -1 siblings, 0 replies; 27+ messages in thread From: Rob Herring @ 2022-05-20 22:19 UTC (permalink / raw) To: AngeloGioacchino Del Regno Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, krzysztof.kozlowski On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote: > This is a clock-controller binding, so it needs #clock-cells, or > it would be of no use: add that to the list of required properties. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + > .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 + > .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 + > .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 + > .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 + > .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 + > 6 files changed, 6 insertions(+) Acked-by: Rob Herring <robh@kernel.org> Wasn't there some discussion about moving these to bindings/clocks/? Maybe that was another one, it's all a blur... Rob ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property @ 2022-05-20 22:19 ` Rob Herring 0 siblings, 0 replies; 27+ messages in thread From: Rob Herring @ 2022-05-20 22:19 UTC (permalink / raw) To: AngeloGioacchino Del Regno Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, krzysztof.kozlowski On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote: > This is a clock-controller binding, so it needs #clock-cells, or > it would be of no use: add that to the list of required properties. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + > .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 + > .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 + > .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 + > .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 + > .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 + > 6 files changed, 6 insertions(+) Acked-by: Rob Herring <robh@kernel.org> Wasn't there some discussion about moving these to bindings/clocks/? Maybe that was another one, it's all a blur... Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property @ 2022-05-20 22:19 ` Rob Herring 0 siblings, 0 replies; 27+ messages in thread From: Rob Herring @ 2022-05-20 22:19 UTC (permalink / raw) To: AngeloGioacchino Del Regno Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel, krzysztof.kozlowski On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote: > This is a clock-controller binding, so it needs #clock-cells, or > it would be of no use: add that to the list of required properties. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + > .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 + > .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 + > .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 + > .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 + > .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 + > 6 files changed, 6 insertions(+) Acked-by: Rob Herring <robh@kernel.org> Wasn't there some discussion about moving these to bindings/clocks/? Maybe that was another one, it's all a blur... Rob _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property 2022-05-20 22:19 ` Rob Herring (?) @ 2022-05-21 14:05 ` Krzysztof Kozlowski -1 siblings, 0 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2022-05-21 14:05 UTC (permalink / raw) To: Rob Herring, AngeloGioacchino Del Regno Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel On 21/05/2022 00:19, Rob Herring wrote: > On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote: >> This is a clock-controller binding, so it needs #clock-cells, or >> it would be of no use: add that to the list of required properties. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + >> .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 + >> .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 + >> .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 + >> .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 + >> .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 + >> 6 files changed, 6 insertions(+) > > Acked-by: Rob Herring <robh@kernel.org> > > Wasn't there some discussion about moving these to bindings/clocks/? > Maybe that was another one, it's all a blur... Yes, there was such idea although I am not sure if this is worth by itself - messes up with the git history. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property @ 2022-05-21 14:05 ` Krzysztof Kozlowski 0 siblings, 0 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2022-05-21 14:05 UTC (permalink / raw) To: Rob Herring, AngeloGioacchino Del Regno Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel On 21/05/2022 00:19, Rob Herring wrote: > On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote: >> This is a clock-controller binding, so it needs #clock-cells, or >> it would be of no use: add that to the list of required properties. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + >> .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 + >> .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 + >> .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 + >> .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 + >> .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 + >> 6 files changed, 6 insertions(+) > > Acked-by: Rob Herring <robh@kernel.org> > > Wasn't there some discussion about moving these to bindings/clocks/? > Maybe that was another one, it's all a blur... Yes, there was such idea although I am not sure if this is worth by itself - messes up with the git history. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property @ 2022-05-21 14:05 ` Krzysztof Kozlowski 0 siblings, 0 replies; 27+ messages in thread From: Krzysztof Kozlowski @ 2022-05-21 14:05 UTC (permalink / raw) To: Rob Herring, AngeloGioacchino Del Regno Cc: krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel On 21/05/2022 00:19, Rob Herring wrote: > On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote: >> This is a clock-controller binding, so it needs #clock-cells, or >> it would be of no use: add that to the list of required properties. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + >> .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 + >> .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 + >> .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 + >> .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 + >> .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 + >> 6 files changed, 6 insertions(+) > > Acked-by: Rob Herring <robh@kernel.org> > > Wasn't there some discussion about moving these to bindings/clocks/? > Maybe that was another one, it's all a blur... Yes, there was such idea although I am not sure if this is worth by itself - messes up with the git history. Best regards, Krzysztof _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property 2022-05-21 14:05 ` Krzysztof Kozlowski (?) @ 2022-05-23 14:08 ` Rob Herring -1 siblings, 0 replies; 27+ messages in thread From: Rob Herring @ 2022-05-23 14:08 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: AngeloGioacchino Del Regno, krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel On Sat, May 21, 2022 at 04:05:01PM +0200, Krzysztof Kozlowski wrote: > On 21/05/2022 00:19, Rob Herring wrote: > > On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote: > >> This is a clock-controller binding, so it needs #clock-cells, or > >> it would be of no use: add that to the list of required properties. > >> > >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > >> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> --- > >> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + > >> .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 + > >> .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 + > >> .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 + > >> .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 + > >> .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 + > >> 6 files changed, 6 insertions(+) > > > > Acked-by: Rob Herring <robh@kernel.org> > > > > Wasn't there some discussion about moving these to bindings/clocks/? > > Maybe that was another one, it's all a blur... > > Yes, there was such idea although I am not sure if this is worth by > itself - messes up with the git history. There shouldn't be too much history since converting to schema. For just a move git is smart enough to see across moves. Rob ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property @ 2022-05-23 14:08 ` Rob Herring 0 siblings, 0 replies; 27+ messages in thread From: Rob Herring @ 2022-05-23 14:08 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: AngeloGioacchino Del Regno, krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel On Sat, May 21, 2022 at 04:05:01PM +0200, Krzysztof Kozlowski wrote: > On 21/05/2022 00:19, Rob Herring wrote: > > On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote: > >> This is a clock-controller binding, so it needs #clock-cells, or > >> it would be of no use: add that to the list of required properties. > >> > >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > >> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> --- > >> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + > >> .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 + > >> .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 + > >> .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 + > >> .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 + > >> .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 + > >> 6 files changed, 6 insertions(+) > > > > Acked-by: Rob Herring <robh@kernel.org> > > > > Wasn't there some discussion about moving these to bindings/clocks/? > > Maybe that was another one, it's all a blur... > > Yes, there was such idea although I am not sure if this is worth by > itself - messes up with the git history. There shouldn't be too much history since converting to schema. For just a move git is smart enough to see across moves. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property @ 2022-05-23 14:08 ` Rob Herring 0 siblings, 0 replies; 27+ messages in thread From: Rob Herring @ 2022-05-23 14:08 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: AngeloGioacchino Del Regno, krzysztof.kozlowski+dt, matthias.bgg, sboyd, chun-jie.chen, rex-bc.chen, wenst, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel On Sat, May 21, 2022 at 04:05:01PM +0200, Krzysztof Kozlowski wrote: > On 21/05/2022 00:19, Rob Herring wrote: > > On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote: > >> This is a clock-controller binding, so it needs #clock-cells, or > >> it would be of no use: add that to the list of required properties. > >> > >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > >> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> --- > >> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 + > >> .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 + > >> .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 + > >> .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 + > >> .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 + > >> .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 + > >> 6 files changed, 6 insertions(+) > > > > Acked-by: Rob Herring <robh@kernel.org> > > > > Wasn't there some discussion about moving these to bindings/clocks/? > > Maybe that was another one, it's all a blur... > > Yes, there was such idea although I am not sure if this is worth by > itself - messes up with the git history. There shouldn't be too much history since converting to schema. For just a move git is smart enough to see across moves. Rob _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 27+ messages in thread
end of thread, other threads:[~2022-05-23 14:09 UTC | newest] Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-05-18 9:36 [PATCH v2 0/2] dt-bindings: arm: MediaTek: Fix clock bindings AngeloGioacchino Del Regno 2022-05-18 9:36 ` AngeloGioacchino Del Regno 2022-05-18 9:36 ` AngeloGioacchino Del Regno 2022-05-18 9:36 ` [PATCH v2 1/2] dt-bindings: arm: mtk-clock: Remove unnecessary 'items' and fix formatting AngeloGioacchino Del Regno 2022-05-18 9:36 ` AngeloGioacchino Del Regno 2022-05-18 9:36 ` AngeloGioacchino Del Regno 2022-05-20 22:16 ` Rob Herring 2022-05-20 22:16 ` Rob Herring 2022-05-20 22:16 ` Rob Herring 2022-05-18 9:36 ` [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property AngeloGioacchino Del Regno 2022-05-18 9:36 ` AngeloGioacchino Del Regno 2022-05-18 9:36 ` AngeloGioacchino Del Regno 2022-05-18 11:46 ` Krzysztof Kozlowski 2022-05-18 11:46 ` Krzysztof Kozlowski 2022-05-18 11:46 ` Krzysztof Kozlowski 2022-05-18 11:50 ` AngeloGioacchino Del Regno 2022-05-18 11:50 ` AngeloGioacchino Del Regno 2022-05-18 11:50 ` AngeloGioacchino Del Regno 2022-05-20 22:19 ` Rob Herring 2022-05-20 22:19 ` Rob Herring 2022-05-20 22:19 ` Rob Herring 2022-05-21 14:05 ` Krzysztof Kozlowski 2022-05-21 14:05 ` Krzysztof Kozlowski 2022-05-21 14:05 ` Krzysztof Kozlowski 2022-05-23 14:08 ` Rob Herring 2022-05-23 14:08 ` Rob Herring 2022-05-23 14:08 ` Rob Herring
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.