All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs: fix typo in comment
@ 2022-05-21 11:11 Julia Lawall
  2022-05-21 19:25 ` Darrick J. Wong
  0 siblings, 1 reply; 8+ messages in thread
From: Julia Lawall @ 2022-05-21 11:11 UTC (permalink / raw)
  To: Darrick J. Wong; +Cc: kernel-janitors, linux-xfs, linux-kernel

Spelling mistake (triple letters) in comment.
Detected with the help of Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---
 fs/xfs/libxfs/xfs_symlink_remote.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_symlink_remote.c b/fs/xfs/libxfs/xfs_symlink_remote.c
index f0b38f4aba80..8b9bd178a487 100644
--- a/fs/xfs/libxfs/xfs_symlink_remote.c
+++ b/fs/xfs/libxfs/xfs_symlink_remote.c
@@ -213,7 +213,7 @@ xfs_symlink_shortform_verify(
 
 	/*
 	 * Zero length symlinks should never occur in memory as they are
-	 * never alllowed to exist on disk.
+	 * never allowed to exist on disk.
 	 */
 	if (!size)
 		return __this_address;


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] xfs: fix typo in comment
  2022-05-21 11:11 [PATCH] xfs: fix typo in comment Julia Lawall
@ 2022-05-21 19:25 ` Darrick J. Wong
  0 siblings, 0 replies; 8+ messages in thread
From: Darrick J. Wong @ 2022-05-21 19:25 UTC (permalink / raw)
  To: Julia Lawall; +Cc: kernel-janitors, linux-xfs, linux-kernel

On Sat, May 21, 2022 at 01:11:22PM +0200, Julia Lawall wrote:
> Spelling mistake (triple letters) in comment.
> Detected with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> 
> ---
>  fs/xfs/libxfs/xfs_symlink_remote.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_symlink_remote.c b/fs/xfs/libxfs/xfs_symlink_remote.c
> index f0b38f4aba80..8b9bd178a487 100644
> --- a/fs/xfs/libxfs/xfs_symlink_remote.c
> +++ b/fs/xfs/libxfs/xfs_symlink_remote.c
> @@ -213,7 +213,7 @@ xfs_symlink_shortform_verify(
>  
>  	/*
>  	 * Zero length symlinks should never occur in memory as they are
> -	 * never alllowed to exist on disk.
> +	 * never allowed to exist on disk.
>  	 */
>  	if (!size)
>  		return __this_address;
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] xfs: Fix typo in comment
  2024-03-17 23:34     ` Thorsten Blum
@ 2024-03-17 23:46       ` Randy Dunlap
  0 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2024-03-17 23:46 UTC (permalink / raw)
  To: Thorsten Blum
  Cc: Christoph Hellwig, Chandan Babu R, Darrick J. Wong, linux-xfs,
	linux-kernel



On 3/17/24 16:34, Thorsten Blum wrote:
> On 17. Mar 2024, at 22:53, Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> Also s/straight away/straightaway/
> 
> Apparently, both are grammatically correct.

OK :)

-- 
#Randy

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] xfs: Fix typo in comment
  2024-03-17 21:53   ` Randy Dunlap
@ 2024-03-17 23:34     ` Thorsten Blum
  2024-03-17 23:46       ` Randy Dunlap
  0 siblings, 1 reply; 8+ messages in thread
From: Thorsten Blum @ 2024-03-17 23:34 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Christoph Hellwig, Chandan Babu R, Darrick J. Wong, linux-xfs,
	linux-kernel

On 17. Mar 2024, at 22:53, Randy Dunlap <rdunlap@infradead.org> wrote:
> 
> Also s/straight away/straightaway/

Apparently, both are grammatically correct.

Thorsten

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] xfs: Fix typo in comment
  2024-03-17 21:12 ` Christoph Hellwig
@ 2024-03-17 21:53   ` Randy Dunlap
  2024-03-17 23:34     ` Thorsten Blum
  0 siblings, 1 reply; 8+ messages in thread
From: Randy Dunlap @ 2024-03-17 21:53 UTC (permalink / raw)
  To: Christoph Hellwig, Thorsten Blum
  Cc: Chandan Babu R, Darrick J. Wong, linux-xfs, linux-kernel


s/somethign/something/

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
 fs/xfs/xfs_log_priv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
index e30c06ec20e3..25b6d6cdd545 100644
--- a/fs/xfs/xfs_log_priv.h
+++ b/fs/xfs/xfs_log_priv.h
@@ -683,7 +683,7 @@ xlog_valid_lsn(
  * flags to control the kmalloc() behaviour within kvmalloc(). Hence kmalloc()
  * will do direct reclaim and compaction in the slow path, both of which are
  * horrendously expensive. We just want kmalloc to fail fast and fall back to
- * vmalloc if it can't get somethign straight away from the free lists or
+ * vmalloc if it can't get something straight away from the free lists or
  * buddy allocator. Hence we have to open code kvmalloc outselves here.
  *
  * This assumes that the caller uses memalloc_nofs_save task context here, so



Also s/straight away/straightaway/
or even use "immediately".

thanks.
-- 
#Randy

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] xfs: Fix typo in comment
  2024-03-17 15:47 [PATCH] xfs: Fix " Thorsten Blum
  2024-03-17 15:49 ` Darrick J. Wong
@ 2024-03-17 21:12 ` Christoph Hellwig
  2024-03-17 21:53   ` Randy Dunlap
  1 sibling, 1 reply; 8+ messages in thread
From: Christoph Hellwig @ 2024-03-17 21:12 UTC (permalink / raw)
  To: Thorsten Blum; +Cc: Chandan Babu R, Darrick J. Wong, linux-xfs, linux-kernel

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] xfs: Fix typo in comment
  2024-03-17 15:47 [PATCH] xfs: Fix " Thorsten Blum
@ 2024-03-17 15:49 ` Darrick J. Wong
  2024-03-17 21:12 ` Christoph Hellwig
  1 sibling, 0 replies; 8+ messages in thread
From: Darrick J. Wong @ 2024-03-17 15:49 UTC (permalink / raw)
  To: Thorsten Blum; +Cc: Chandan Babu R, linux-xfs, linux-kernel

On Sun, Mar 17, 2024 at 04:47:32PM +0100, Thorsten Blum wrote:
> s/somethign/something/
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_log_priv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index e30c06ec20e3..25b6d6cdd545 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -683,7 +683,7 @@ xlog_valid_lsn(
>   * flags to control the kmalloc() behaviour within kvmalloc(). Hence kmalloc()
>   * will do direct reclaim and compaction in the slow path, both of which are
>   * horrendously expensive. We just want kmalloc to fail fast and fall back to
> - * vmalloc if it can't get somethign straight away from the free lists or
> + * vmalloc if it can't get something straight away from the free lists or
>   * buddy allocator. Hence we have to open code kvmalloc outselves here.
>   *
>   * This assumes that the caller uses memalloc_nofs_save task context here, so
> -- 
> 2.44.0
> 
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] xfs: Fix typo in comment
@ 2024-03-17 15:47 Thorsten Blum
  2024-03-17 15:49 ` Darrick J. Wong
  2024-03-17 21:12 ` Christoph Hellwig
  0 siblings, 2 replies; 8+ messages in thread
From: Thorsten Blum @ 2024-03-17 15:47 UTC (permalink / raw)
  To: Chandan Babu R; +Cc: Darrick J. Wong, linux-xfs, linux-kernel, Thorsten Blum

s/somethign/something/

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
 fs/xfs/xfs_log_priv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
index e30c06ec20e3..25b6d6cdd545 100644
--- a/fs/xfs/xfs_log_priv.h
+++ b/fs/xfs/xfs_log_priv.h
@@ -683,7 +683,7 @@ xlog_valid_lsn(
  * flags to control the kmalloc() behaviour within kvmalloc(). Hence kmalloc()
  * will do direct reclaim and compaction in the slow path, both of which are
  * horrendously expensive. We just want kmalloc to fail fast and fall back to
- * vmalloc if it can't get somethign straight away from the free lists or
+ * vmalloc if it can't get something straight away from the free lists or
  * buddy allocator. Hence we have to open code kvmalloc outselves here.
  *
  * This assumes that the caller uses memalloc_nofs_save task context here, so
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2024-03-17 23:46 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-21 11:11 [PATCH] xfs: fix typo in comment Julia Lawall
2022-05-21 19:25 ` Darrick J. Wong
2024-03-17 15:47 [PATCH] xfs: Fix " Thorsten Blum
2024-03-17 15:49 ` Darrick J. Wong
2024-03-17 21:12 ` Christoph Hellwig
2024-03-17 21:53   ` Randy Dunlap
2024-03-17 23:34     ` Thorsten Blum
2024-03-17 23:46       ` Randy Dunlap

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.