All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Mike Leach <mike.leach@linaro.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] dt-bindings: arm: Convert CoreSight CPU debug to DT schema
Date: Sat, 21 May 2022 21:27:50 +0800	[thread overview]
Message-ID: <20220521132750.GA711227@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20220520214416.302127-3-robh@kernel.org>

On Fri, May 20, 2022 at 04:44:16PM -0500, Rob Herring wrote:
> Convert the CoreSight CPU debug binding to DT schema format.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Compared line by line between old DT binding and new yaml file,
I found only one difference is in the new yaml file it doesn't
contain below info for constraints CPU power states:

  "using "cpuidle.off=1" or "nohlt" in the kernel command line or
   sysfs node ..."

IIUC, yaml file will be used not only for Linux kernel, thus it makes
sense to remove the Linux specific info.  Looks good to me:

Reviewed-by: Leo Yan <leo.yan@linaro.org>

WARNING: multiple messages have this Message-ID (diff)
From: Leo Yan <leo.yan@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Mike Leach <mike.leach@linaro.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] dt-bindings: arm: Convert CoreSight CPU debug to DT schema
Date: Sat, 21 May 2022 21:27:50 +0800	[thread overview]
Message-ID: <20220521132750.GA711227@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20220520214416.302127-3-robh@kernel.org>

On Fri, May 20, 2022 at 04:44:16PM -0500, Rob Herring wrote:
> Convert the CoreSight CPU debug binding to DT schema format.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Compared line by line between old DT binding and new yaml file,
I found only one difference is in the new yaml file it doesn't
contain below info for constraints CPU power states:

  "using "cpuidle.off=1" or "nohlt" in the kernel command line or
   sysfs node ..."

IIUC, yaml file will be used not only for Linux kernel, thus it makes
sense to remove the Linux specific info.  Looks good to me:

Reviewed-by: Leo Yan <leo.yan@linaro.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-21 13:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20 21:44 [PATCH 0/2] dt-bindings: Arm CoreSight binding schema conversions Rob Herring
2022-05-20 21:44 ` Rob Herring
2022-05-20 21:44 ` [PATCH 1/2] dt-bindings: arm: Convert CoreSight bindings to DT schema Rob Herring
2022-05-20 21:44   ` Rob Herring
2022-05-21 14:54   ` Krzysztof Kozlowski
2022-05-21 14:54     ` Krzysztof Kozlowski
2022-05-23 12:53     ` Rob Herring
2022-05-23 12:53       ` Rob Herring
2022-05-23 11:03   ` Suzuki K Poulose
2022-05-23 11:03     ` Suzuki K Poulose
2022-05-23 13:57     ` Rob Herring
2022-05-23 13:57       ` Rob Herring
2022-05-20 21:44 ` [PATCH 2/2] dt-bindings: arm: Convert CoreSight CPU debug " Rob Herring
2022-05-20 21:44   ` Rob Herring
2022-05-21 13:27   ` Leo Yan [this message]
2022-05-21 13:27     ` Leo Yan
2022-05-21 14:47   ` Krzysztof Kozlowski
2022-05-21 14:47     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220521132750.GA711227@leoy-ThinkPad-X240s \
    --to=leo.yan@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=robh@kernel.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.