* [PATCH v2 1/4] rtw88: Make rtw8822b_hw_spec be static
2022-05-21 17:31 [PATCH v2 0/4] rtw88: Make some symbols be static Larry Finger
@ 2022-05-21 17:31 ` Larry Finger
2022-05-21 17:31 ` [PATCH v2 2/4] rtw88: Make rtw8822c_hw_spec " Larry Finger
2022-05-21 17:31 ` [PATCH v2 3/4] rtw88: Make rtw8723d_hw_spec " Larry Finger
2 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2022-05-21 17:31 UTC (permalink / raw)
To: Kalle Valo; +Cc: Johannes Berg, linux-wireless, Larry Finger, Ping-Ke Shih
Sparse lists the following for rtw88:
CHECK drivers/net/wireless/realtek/rtw88/rtw8822b.c
drivers/net/wireless/realtek/rtw88/rtw8822b.c:2500:22: warning: symbol 'rtw8822b_hw_spec' was not declared. Should it be static?
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
v2 - change subject as recommended by Kalle
---
drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822b.c b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
index dccd722b8e62..60c4e75df035 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822b.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
@@ -2497,7 +2497,7 @@ static struct rtw_hw_reg_offset rtw8822b_edcca_th[] = {
[EDCCA_TH_H2L_IDX] = {{.addr = 0x8a4, .mask = MASKBYTE1}, .offset = 0},
};
-struct rtw_chip_info rtw8822b_hw_spec = {
+static struct rtw_chip_info rtw8822b_hw_spec = {
.ops = &rtw8822b_ops,
.id = RTW_CHIP_TYPE_8822B,
.fw_name = "rtw88/rtw8822b_fw.bin",
--
2.36.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/4] rtw88: Make rtw8822c_hw_spec be static
2022-05-21 17:31 [PATCH v2 0/4] rtw88: Make some symbols be static Larry Finger
2022-05-21 17:31 ` [PATCH v2 1/4] rtw88: Make rtw8822b_hw_spec " Larry Finger
@ 2022-05-21 17:31 ` Larry Finger
2022-05-21 17:31 ` [PATCH v2 3/4] rtw88: Make rtw8723d_hw_spec " Larry Finger
2 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2022-05-21 17:31 UTC (permalink / raw)
To: Kalle Valo; +Cc: Johannes Berg, linux-wireless, Larry Finger, Ping-Ke Shih
Sparse reports the following:
CHECK drivers/net/wireless/realtek/rtw88/rtw8822c.c
drivers/net/wireless/realtek/rtw88/rtw8822c.c:5313:22: warning: symbol 'rtw8822c_hw_spec' was not declared. Should it be static?
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
v2 - change subject as recommended by Kalle
---
drivers/net/wireless/realtek/rtw88/rtw8822c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
index c043b5c520b9..5ae72d7f5c50 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
@@ -5310,7 +5310,7 @@ static const struct rtw_reg_domain coex_info_hw_regs_8822c[] = {
{0xc50, MASKBYTE0, RTW_REG_DOMAIN_MAC8},
};
-struct rtw_chip_info rtw8822c_hw_spec = {
+static struct rtw_chip_info rtw8822c_hw_spec = {
.ops = &rtw8822c_ops,
.id = RTW_CHIP_TYPE_8822C,
.fw_name = "rtw88/rtw8822c_fw.bin",
--
2.36.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 3/4] rtw88: Make rtw8723d_hw_spec be static
2022-05-21 17:31 [PATCH v2 0/4] rtw88: Make some symbols be static Larry Finger
2022-05-21 17:31 ` [PATCH v2 1/4] rtw88: Make rtw8822b_hw_spec " Larry Finger
2022-05-21 17:31 ` [PATCH v2 2/4] rtw88: Make rtw8822c_hw_spec " Larry Finger
@ 2022-05-21 17:31 ` Larry Finger
2 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2022-05-21 17:31 UTC (permalink / raw)
To: Kalle Valo; +Cc: Johannes Berg, linux-wireless, Larry Finger, Ping-Ke Shih
Sparse lists the following:
CHECK drivers/net/wireless/realtek/rtw88/rtw8723d.c
drivers/net/wireless/realtek/rtw88/rtw8723d.c:2704:22: warning: symbol 'rtw8723d_hw_spec' was not declared. Should it be static?
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
v2 - change subject as recommended by Kalle
---
drivers/net/wireless/realtek/rtw88/rtw8723d.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723d.c b/drivers/net/wireless/realtek/rtw88/rtw8723d.c
index 93cce44df531..05e826e6ed0d 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8723d.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8723d.c
@@ -2701,7 +2701,7 @@ static const struct rtw_reg_domain coex_info_hw_regs_8723d[] = {
{0x953, BIT(1), RTW_REG_DOMAIN_MAC8},
};
-struct rtw_chip_info rtw8723d_hw_spec = {
+static struct rtw_chip_info rtw8723d_hw_spec = {
.ops = &rtw8723d_ops,
.id = RTW_CHIP_TYPE_8723D,
.fw_name = "rtw88/rtw8723d_fw.bin",
--
2.36.1
^ permalink raw reply related [flat|nested] 4+ messages in thread