All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marijn Suijten <marijn.suijten@somainline.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH v6 01/11] arm64: dts: qcom: sdm630: disable dsi0/dsi0_phy by default
Date: Sat, 21 May 2022 20:19:23 +0200	[thread overview]
Message-ID: <20220521181923.uqje7rclvblj6ofk@SoMainline.org> (raw)
In-Reply-To: <45462192-7c88-cdd9-19ae-e078915bf6c8@linaro.org>

On 2022-05-21 18:49:36, Krzysztof Kozlowski wrote:
> On 21/05/2022 18:06, Marijn Suijten wrote:
> > On 2022-05-21 18:20:39, Dmitry Baryshkov wrote:
> >> Follow the typical practice and keep DSI0/DSI0 PHY disabled by default.
> >> They should be enabled in the board DT files. No existing boards use
> >> them at this moment.
> >>
> >> Suggested-by: Marijn Suijten <marijn.suijten@somainline.org>
> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > 
> > I also added my:
> > 
> > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> > 
> > To v5, to confirm the Suggested-by.
> 
> Reviewed-by tag is not used to confirm other tags like reported or
> suggested. It means you performed the review and you state what is
> described in "Reviewer's statement of oversight".

That is obviously implied, otherwise I wouldn't have sent a Reviewed-by
in the first place.

However, I don't think Suggested-by quite carries the load of a
Reviewed-by (at all...), so I don't understand why my Reviewed-by's have
strangely been picked up for every patch except those where my name is
already listed as Suggested-by or Reported-by, those are completely
separate things.

- Marijn

  reply	other threads:[~2022-05-21 18:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-21 15:20 [PATCH v6 00/11] arm64: dts: qcom: initial Inforce IFC6560 board support Dmitry Baryshkov
2022-05-21 15:20 ` [PATCH v6 01/11] arm64: dts: qcom: sdm630: disable dsi0/dsi0_phy by default Dmitry Baryshkov
2022-05-21 16:06   ` Marijn Suijten
2022-05-21 16:49     ` Krzysztof Kozlowski
2022-05-21 18:19       ` Marijn Suijten [this message]
2022-05-21 20:13     ` Dmitry Baryshkov
2022-05-21 22:15       ` Marijn Suijten
2022-05-21 15:20 ` [PATCH v6 02/11] arm64: dts: qcom: sdm660: disable dsi1/dsi1_phy " Dmitry Baryshkov
2022-05-21 15:20 ` [PATCH v6 03/11] arm64: dts: qcom: sdm630: disable GPU " Dmitry Baryshkov
2022-05-21 15:20 ` [PATCH v6 04/11] arm64: dts: qcom: sdm630: fix the qusb2phy ref clock Dmitry Baryshkov
2022-05-21 15:20 ` [PATCH v6 05/11] arm64: dts: qcom: sdm630: rename qusb2phy to qusb2phy0 Dmitry Baryshkov
2022-05-21 16:07   ` Marijn Suijten
2022-05-21 15:20 ` [PATCH v6 06/11] arm64: dts: qcom: sdm630: add second (HS) USB host support Dmitry Baryshkov
2022-05-21 15:20 ` [PATCH v6 07/11] arm64: dts: qcom: sdm630: fix gpu's interconnect path Dmitry Baryshkov
2022-05-21 16:17   ` Marijn Suijten
2022-05-21 16:51     ` Krzysztof Kozlowski
2022-05-21 18:27       ` Marijn Suijten
2022-05-21 15:20 ` [PATCH v6 08/11] arm64: dts: qcom: sdm636-sony-xperia-ganges-mermaid: correct sdc2 pinconf Dmitry Baryshkov
2022-05-21 15:20 ` [PATCH v6 09/11] arm64: dts: qcom: sdm660: move SDHC2 card detect pinconf to board files Dmitry Baryshkov
2022-05-21 16:19   ` Marijn Suijten
2022-05-21 15:20 ` [PATCH v6 10/11] arm64: dts: qcom: sdm660: Add initial Inforce IFC6560 board support Dmitry Baryshkov
2022-05-21 15:20 ` [PATCH v6 11/11] dt-bindings: arm: qcom: document sda660 SoC and ifc6560 board Dmitry Baryshkov
2022-05-21 16:20   ` Marijn Suijten
2022-05-21 16:30     ` Krzysztof Kozlowski
2022-05-21 16:37   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220521181923.uqje7rclvblj6ofk@SoMainline.org \
    --to=marijn.suijten@somainline.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.